78f1cabc3a20670812e95fcaf43bd24ef546516a
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private mockPod(machineName String, ramLimit Long, ramRequest Long) : Pod renamed to private createPodData(machineName String, ramLimit Long, ramRequest Long) : PodData in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactoryTest | From | To | |
| Rename Method private mockPod(machineName String, ramLimit long, ramRequest long) : Pod renamed to private createPodData(machineName String, ramLimit long, ramRequest long) : PodData in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactoryTest | From | To | |
| Change Parameter Type | 7 | ||
| Change Parameter Type cause : Exception to cause : Throwable in method public DevfileException(message String, cause Throwable) in class org.eclipse.che.api.devfile.server.exception.DevfileException | From | To | |
| Change Parameter Type list : KubernetesList to list : List<HasMetadata> in method private asYaml(tool Tool, list List<HasMetadata>) : String in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Change Parameter Type pods : Collection<Pod> to pods : Collection<PodData> in method package addRamAttributes(machines Map<String,InternalMachineConfig>, pods Collection<PodData>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Change Parameter Type list : KubernetesList to list : List<HasMetadata> in method private filter(list List<HasMetadata>, selector Map<String,String>) : List<HasMetadata> in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Change Parameter Type recipeObjects : KubernetesList to recipeObjects : List<HasMetadata> in method private estimateCommandsMachineName(workspaceConfig WorkspaceConfig, tool Tool, recipeObjects List<HasMetadata>) : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Change Parameter Type pods : Collection<Pod> to pods : Collection<PodData> in method package addRamAttributes(machines Map<String,InternalMachineConfig>, pods Collection<PodData>) : void in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactory | From | To | |
| Change Parameter Type clientFactory : KubernetesClientFactory to recipeParser : KubernetesRecipeParser in method public KubernetesEnvironmentFactory(installerRegistry InstallerRegistry, recipeRetriever RecipeRetriever, machinesValidator MachineConfigsValidator, recipeParser KubernetesRecipeParser, envValidator KubernetesEnvironmentValidator, memoryProvisioner MemoryAttributeProvisioner) in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Rename Variable | 1 | ||
| Rename Variable list : List<HasMetadata> to recipeObjects : List<HasMetadata> in method protected doCreate(recipe InternalRecipe, machines Map<String,InternalMachineConfig>, sourceWarnings List<Warning>) : KubernetesEnvironment in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Pod to PodData in method private createPodData(machineName String, ramLimit Long, ramRequest Long) : PodData in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactoryTest | From | To | |
| Change Return Type KubernetesList to List<HasMetadata> in method private unmarshal(tool Tool, recipeContent String) : List<HasMetadata> in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Change Return Type Pod to PodData in method private createPodData(machineName String, ramLimit long, ramRequest long) : PodData in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactoryTest | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private clientFactory : KubernetesClientFactory from class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactoryTest to private clientFactory : KubernetesClientFactory from class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesRecipeParser | From | To | |
| Move Attribute private clientFactory : KubernetesClientFactory from class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory to private clientFactory : KubernetesClientFactory from class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesRecipeParser | From | To | |
| Extract Class | 2 | ||
| Extract Class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesRecipeParser from class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactory | From | To | |
| Extract Class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesRecipeParser from class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Merge Variable | 2 | ||
| Merge Variable [machines : Map<String,InternalMachineConfig>, pods : Map<String,Pod>] to osEnv : OpenShiftEnvironment in method protected doCreate(recipe InternalRecipe, machines Map<String,InternalMachineConfig>, sourceWarnings List<Warning>) : OpenShiftEnvironment in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactory | From | To | |
| Merge Variable [machines : Map<String,InternalMachineConfig>, pods : Map<String,Pod>] to k8sEnv : KubernetesEnvironment in method protected doCreate(recipe InternalRecipe, machines Map<String,InternalMachineConfig>, sourceWarnings List<Warning>) : KubernetesEnvironment in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute clientFactory : KubernetesClientFactory to recipeParser : KubernetesRecipeParser in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Rename Attribute clientFactory : OpenShiftClientFactory to k8sObjectsParser : KubernetesRecipeParser in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactory | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type pods : Set<Pod> to pods : Set<PodData> in method public testProvisionRamAttributesIsInvoked() : void in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactoryTest | From | To | |
| Change Variable Type list : KubernetesList to list : List<HasMetadata> in method public apply(workspaceConfig WorkspaceConfigImpl, k8sTool Tool, contentProvider FileContentProvider) : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Change Variable Type pod : Pod to pod : PodData in method package addRamAttributes(machines Map<String,InternalMachineConfig>, pods Collection<PodData>) : void in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactory | From | To | |
| Change Variable Type pods : Set<Pod> to pods : Set<PodData> in method public testProvisionRamAttributesIsInvoked() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactoryTest | From | To | |
| Change Variable Type pod : Pod to pod : PodData in method package addRamAttributes(machines Map<String,InternalMachineConfig>, pods Collection<PodData>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type clientFactory : KubernetesClientFactory to recipeParser : KubernetesRecipeParser in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To | |
| Change Attribute Type clientFactory : OpenShiftClientFactory to k8sObjectsParser : KubernetesRecipeParser in class org.eclipse.che.workspace.infrastructure.openshift.environment.OpenShiftEnvironmentFactory | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter clientFactory : KubernetesClientFactory to recipeParser : KubernetesRecipeParser in method public KubernetesEnvironmentFactory(installerRegistry InstallerRegistry, recipeRetriever RecipeRetriever, machinesValidator MachineConfigsValidator, recipeParser KubernetesRecipeParser, envValidator KubernetesEnvironmentValidator, memoryProvisioner MemoryAttributeProvisioner) in class org.eclipse.che.workspace.infrastructure.kubernetes.environment.KubernetesEnvironmentFactory | From | To |