che 80493203481fc6b7c3fb93890f14c25344348044

80493203481fc6b7c3fb93890f14c25344348044

Files Diff

Added: 12
Removed: 0
Renamed: 0
Modified: 29

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	9
Pull Up Method protected updateServer(server ServerImpl) : ServerImpl from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to protected updateServer(server ServerImpl) : ServerImpl from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method protected getInternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.DefaultServerEvaluationStrategy to protected getInternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method protected getExternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.LocalDockerServerEvaluationStrategy to protected getExternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method public getOnlineRenderingEvaluation(containerInfo ContainerInfo, internalHost String) : RenderingEvaluation from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to public getOnlineRenderingEvaluation(containerInfo ContainerInfo, internalHost String) : RenderingEvaluation from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method protected getInternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.LocalDockerServerEvaluationStrategy to protected getInternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method public getOfflineRenderingEvaluation(labels Map<String,String>, exposedPorts Set<String>, env String[]) : RenderingEvaluation from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to public getOfflineRenderingEvaluation(labels Map<String,String>, exposedPorts Set<String>, env String[]) : RenderingEvaluation from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method protected getExternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to protected getExternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method public getServers(containerInfo ContainerInfo, internalHost String, serverConfMap Map<String,ServerConfImpl>) : Map<String,ServerImpl> from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to public getServers(containerInfo ContainerInfo, internalHost String, serverConfMap Map<String,ServerConfImpl>) : Map<String,ServerImpl> from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Method protected getExternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.DefaultServerEvaluationStrategy to protected getExternalAddressesAndPorts(containerInfo ContainerInfo, internalHost String) : Map<String,String> from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Rename Variable	2
Rename Variable hostPath : String to mountPath : String in method private getVolumesFrom(volumes String[]) : List<Volume> in class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To
Rename Variable runContainerAsRoot : boolean to resourceRequests : Map<String,Quantity> in method public createContainer(createContainerParams CreateContainerParams) : ContainerCreated in class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To
Pull Up Attribute	6
Pull Up Attribute public CHE_MACHINE_NAME_PROPERTY : String from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to public CHE_MACHINE_NAME_PROPERTY : String from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Attribute private cheDockerCustomExternalProtocol : String from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to private cheDockerCustomExternalProtocol : String from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Attribute public CHE_WORKSPACE_ID_PROPERTY : String from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to public CHE_WORKSPACE_ID_PROPERTY : String from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Attribute public LABEL_CHE_SERVER_REF_KEY : String from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to public LABEL_CHE_SERVER_REF_KEY : String from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Attribute private chePort : String from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to private chePort : String from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Pull Up Attribute private cheDockerCustomExternalTemplate : String from class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy to private cheDockerCustomExternalTemplate : String from class org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy	From	To
Change Return Type	1
Change Return Type String to void in method private createOpenShiftDeployment(deploymentName String, imageName String, sanitizedContainerName String, exposedPorts Set<String>, envVariables String[], volumes String[], resourceLimits Map<String,Quantity>, resourceRequests Map<String,Quantity>) : void in class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To
Move Class	4
Move Class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy.OnlineRenderingEvaluation moved to org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy.OnlineRenderingEvaluation	From	To
Move Class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy.OfflineRenderingEvaluation moved to org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy.OfflineRenderingEvaluation	From	To
Move Class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy.DefaultRenderingEvaluation moved to org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy.DefaultRenderingEvaluation	From	To
Move Class org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy.RenderingEvaluation moved to org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy.RenderingEvaluation	From	To
Parameterize Variable	1
Parameterize Variable imageStreamTag : String to imageStreamName : String in method private getImageStreamTag(imageStreamName String) : ImageStreamTag in class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To
Extract Superclass	1
Extract Superclass org.eclipse.che.plugin.docker.machine.BaseServerEvaluationStrategy from classes [org.eclipse.che.plugin.docker.machine.CustomServerEvaluationStrategy, org.eclipse.che.plugin.docker.machine.DefaultServerEvaluationStrategy, org.eclipse.che.plugin.docker.machine.LocalDockerServerEvaluationStrategy]	From	To
Change Variable Type	1
Change Variable Type runContainerAsRoot : boolean to resourceRequests : Map<String,Quantity> in method public createContainer(createContainerParams CreateContainerParams) : ContainerCreated in class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To
Extract Variable	2
Extract Variable internalProtocol : String in method public getServers(containerInfo ContainerInfo, internalHost String, serverConfMap Map<String,ServerConfImpl>) : Map<String,ServerImpl> from class org.eclipse.che.plugin.docker.machine.ServerEvaluationStrategy	From	To
Extract Variable tagImage : Image in method private getImageInfoFromTag(imageStreamTag ImageStreamTag) : ImageInfo from class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To
Extract Method	2
Extract Method protected getExposedPortsToAddressPorts(address String, ports Map<String,List<PortBinding>>, useExposedPorts boolean) : Map<String,String> extracted from protected getExposedPortsToAddressPorts(address String, ports Map<String,List<PortBinding>>) : Map<String,String> in class org.eclipse.che.plugin.docker.machine.ServerEvaluationStrategy	From	To
Extract Method private getImageStreamTag(imageStreamName String) : ImageStreamTag extracted from private getImageStreamTagFromRepo(imageStreamTagName String) : ImageStreamTag in class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To
Rename Parameter	1
Rename Parameter workspaceID : String to deploymentName : String in method private createOpenShiftDeployment(deploymentName String, imageName String, sanitizedContainerName String, exposedPorts Set<String>, envVariables String[], volumes String[], resourceLimits Map<String,Quantity>, resourceRequests Map<String,Quantity>) : void in class org.eclipse.che.plugin.openshift.client.OpenShiftConnector	From	To

80493203481fc6b7c3fb93890f14c25344348044

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: