806a6da184c069e8cc0f6953c7af97e82994132a
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 24
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type workspaceId : String to runtimeId : RuntimeIdentity in method public getProbes(runtimeId RuntimeIdentity, runtime Runtime) : WorkspaceProbes in class org.eclipse.che.api.workspace.server.hc.probe.WorkspaceProbesFactory | From | To | |
| Change Parameter Type workspaceId : String to runtimeId : RuntimeIdentity in method public getProbes(runtimeId RuntimeIdentity, machineName String, servers Map<String,? extends Server>) : WorkspaceProbes in class org.eclipse.che.api.workspace.server.hc.probe.WorkspaceProbesFactory | From | To | |
| Change Parameter Type workspaceId : String to runtimeId : RuntimeIdentity in method private fillProbes(runtimeId RuntimeIdentity, machineName String, factories List<ProbeFactory>, servers Map<String,? extends Server>) : void in class org.eclipse.che.api.workspace.server.hc.probe.WorkspaceProbesFactory | From | To | |
| Move Method | 5 | ||
| Move Method private sendRunningEvent(machineName String) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to public sendRunningEvent(machineName String, runtimeId RuntimeIdentity) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Move Method private sendServerStatusEvent(machineName String, serverName String, server Server) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to public sendServerStatusEvent(machineName String, serverName String, server Server, runtimeId RuntimeIdentity) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Move Method private sendFailedEvent(machineName String, message String) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to public sendFailedEvent(machineName String, message String, runtimeId RuntimeIdentity) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Move Method protected sendStartingEvent(machineName String) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to public sendStartingEvent(machineName String, runtimeId RuntimeIdentity) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Move Method private sendRuntimeStoppedEvent(errorMsg String) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to public sendRuntimeStoppedEvent(errorMsg String, runtimeId RuntimeIdentity) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private RUNTIME_STOPPED_STATE : String from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to private RUNTIME_STOPPED_STATE : String from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Move Attribute private RUNTIME_RUNNING_STATE : String from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to private RUNTIME_RUNNING_STATE : String from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Move Attribute private eventService : EventService from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime to private eventService : EventService from class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher | From | To | |
| Extract Class | 1 | ||
| Extract Class org.eclipse.che.workspace.infrastructure.kubernetes.util.RuntimeEventsPublisher from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type currentUserId : String to subject : Subject in method public getToken(workspaceId String) : String in class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenProviderImpl | From | To | |
| Extract Variable | 1 | ||
| Extract Variable runtimeId : RuntimeIdentity in method package checkServers() : void from class org.eclipse.che.workspace.infrastructure.docker.DockerInternalRuntime | From | To | |
| Inline Variable | 2 | ||
| Inline Variable container2 : Container in method public startsKubernetesEnvironment() : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntimeTest | From | To | |
| Inline Variable container1 : Container in method public startsKubernetesEnvironment() : void from class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntimeTest | From | To | |
| Extract Method | 6 | ||
| Extract Method public get(userId String, workspaceId String, server Server) : HttpProbeConfig extracted from public get(workspaceId String, server Server) : HttpProbeConfig in class org.eclipse.che.api.workspace.server.hc.probe.server.TerminalServerLivenessProbeConfigFactory | From | To | |
| Extract Method public getToken(userId String, workspaceId String) : String extracted from public getToken(workspaceId String) : String in class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenProviderImpl | From | To | |
| Extract Method public get(userId String, workspaceId String, server Server) : HttpProbeConfig extracted from public get(workspaceId String, server Server) : HttpProbeConfig in class org.eclipse.che.api.workspace.server.hc.probe.server.WsAgentServerLivenessProbeConfigFactory | From | To | |
| Extract Method private wrapAndRethrow(origin Throwable) : void extracted from protected internalStart(startOptions Map<String,String>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Extract Method public get(userId String, workspaceId String, server Server) : HttpProbeConfig extracted from public get(workspaceId String, server Server) : HttpProbeConfig in class org.eclipse.che.api.workspace.server.hc.probe.server.ExecServerLivenessProbeConfigFactory | From | To | |
| Extract Method private publishRunningStatus(machine KubernetesMachine) : Runnable extracted from protected internalStart(startOptions Map<String,String>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Rename Variable | 2 | ||
| Rename Variable allPods : ImmutableMap<String,Pod> to podsMap : ImmutableMap<String,Pod> in method public startsKubernetesEnvironment() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntimeTest | From | To | |
| Rename Variable currentUserId : String to subject : Subject in method public getToken(workspaceId String) : String in class org.eclipse.che.multiuser.machine.authentication.server.MachineTokenProviderImpl | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to CompletableFuture<?> in method public startAsync(serverReadinessHandler Consumer<String>) : CompletableFuture<?> in class org.eclipse.che.api.workspace.server.hc.ServersChecker | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute machineStartTimeoutMin : int to ingressStartTimeout : int in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Rename Attribute eventService : EventService to eventPublisher : RuntimeEventsPublisher in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type eventService : EventService to eventPublisher : RuntimeEventsPublisher in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntime | From | To | |
| Change Attribute Type internalRuntime : KubernetesInternalRuntime to internalRuntime : KubernetesInternalRuntime<KubernetesRuntimeContext<KubernetesEnvironment>> in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntimeTest | From | To | |
| Change Attribute Type context : KubernetesRuntimeContext to context : KubernetesRuntimeContext<KubernetesEnvironment> in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntimeTest | From | To | |
| Change Attribute Type result : CompletableFuture to result : CompletableFuture<?> in class org.eclipse.che.api.workspace.server.hc.ServersChecker | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter workspaceId : String to runtimeId : RuntimeIdentity in method public getProbes(runtimeId RuntimeIdentity, machineName String, servers Map<String,? extends Server>) : WorkspaceProbes in class org.eclipse.che.api.workspace.server.hc.probe.WorkspaceProbesFactory | From | To | |
| Rename Parameter workspaceId : String to runtimeId : RuntimeIdentity in method private fillProbes(runtimeId RuntimeIdentity, machineName String, factories List<ProbeFactory>, servers Map<String,? extends Server>) : void in class org.eclipse.che.api.workspace.server.hc.probe.WorkspaceProbesFactory | From | To | |
| Rename Parameter machineStartTimeoutMin : int to workspaceStartTimeout : int in method public OpenShiftInternalRuntime(workspaceStartTimeout int, ingressStartTimeout int, urlRewriter NoOpURLRewriter, bootstrapperFactory KubernetesBootstrapperFactory, serverCheckerFactory ServersCheckerFactory, volumesStrategy WorkspaceVolumesStrategy, probeScheduler ProbeScheduler, probesFactory WorkspaceProbesFactory, eventPublisher RuntimeEventsPublisher, sharedPool KubernetesSharedPool, context OpenShiftRuntimeContext, project OpenShiftProject, warnings List<Warning>) in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftInternalRuntime | From | To | |
| Rename Parameter workspaceId : String to runtimeId : RuntimeIdentity in method public getProbes(runtimeId RuntimeIdentity, runtime Runtime) : WorkspaceProbes in class org.eclipse.che.api.workspace.server.hc.probe.WorkspaceProbesFactory | From | To |