89a80c002190398b0d5e9d98578121e240f965a2
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 4 | ||
Rename Method public testProvisionVolumesWithSubpathsIntoKubernetesEnviromnent() : void renamed to public testProvisionVolumesWithSubpathsIntoKubernetesEnvironment() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.CommonPVCStrategyTest | From | To | |
Rename Method private provisionCommonPVC(k8sEnv KubernetesEnvironment, identity RuntimeIdentity) : PersistentVolumeClaim renamed to private replacePVCsWithCommon(k8sEnv KubernetesEnvironment, identity RuntimeIdentity) : PersistentVolumeClaim in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.CommonPVCStrategy | From | To | |
Rename Method public testDoNotProvisionPVCsWhenItIsAlreadyExistsForGivenVolumeAndWorkspace() : void renamed to public testDoNotProvisionPVCsWhenItAlreadyExistsForGivenVolumeAndWorkspace() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Rename Method private getVolumeSubPath(workspaceId String, volumeName String, machineName String) : String renamed to private getVolumeSubpath(workspaceId String, volumeName String, machineName String) : String in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategy | From | To | |
Rename Variable | 3 | ||
Rename Variable volumeName : String to pvcForVolume1 : PersistentVolumeClaim in method public testProvisionPVCsForEachVolumeWithUniqueName() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Rename Variable volumeKey : String to cheVolumeName : String in method public provision(k8sEnv KubernetesEnvironment, identity RuntimeIdentity) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.EphemeralWorkspaceAdapter | From | To | |
Rename Variable volumeKeyToNameCache : Map<String,String> to cheVolumeNameToPodVolumeName : Map<String,String> in method public provision(k8sEnv KubernetesEnvironment, identity RuntimeIdentity) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.EphemeralWorkspaceAdapter | From | To | |
Move Attribute | 6 | ||
Move Attribute private MACHINE_2_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.PerWorkspacePVCStrategyTest to private MACHINE_2_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Move Attribute private POD_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.CommonPVCStrategyTest to private POD_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.EphemeralWorkspaceAdapterTest | From | To | |
Move Attribute private MACHINE_3_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.PerWorkspacePVCStrategyTest to private MACHINE_3_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Move Attribute private POD_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.PerWorkspacePVCStrategyTest to private POD_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.EphemeralWorkspaceAdapterTest | From | To | |
Move Attribute private POD_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest to private POD_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.EphemeralWorkspaceAdapterTest | From | To | |
Move Attribute private MACHINE_1_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.PerWorkspacePVCStrategyTest to private MACHINE_1_NAME : String from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Rename Attribute | 4 | ||
Rename Attribute perWorkspaceStrategy : PerWorkspacePVCStrategy to strategy : PerWorkspacePVCStrategy in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.PerWorkspacePVCStrategyTest | From | To | |
Rename Attribute MACHINE_NAME_2 : String to MACHINE_3_NAME : String in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Rename Attribute MACHINE_NAME : String to MACHINE_2_NAME : String in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Rename Attribute POD_ID : String to POD_NAME : String in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.EphemeralWorkspaceAdapterTest | From | To | |
Change Variable Type | 1 | ||
Change Variable Type volumeName : String to pvcForVolume1 : PersistentVolumeClaim in method public testProvisionPVCsForEachVolumeWithUniqueName() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
Extract Variable | 2 | ||
Extract Variable machineConfig : InternalMachineConfig in method private provisionCheVolumes(k8sEnv KubernetesEnvironment, workspaceId String, volumeName2PVC Map<String,PersistentVolumeClaim>) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategy | From | To | |
Extract Variable machineConfig : InternalMachineConfig in method public provision(k8sEnv KubernetesEnvironment, identity RuntimeIdentity) : void from class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.EphemeralWorkspaceAdapter | From | To | |
Rename Parameter | 1 | ||
Rename Parameter provisionedClaims : Map<String,PersistentVolumeClaim> to volumeName2PVC : Map<String,PersistentVolumeClaim> in method private addMachineVolumes(workspaceId String, k8sEnv KubernetesEnvironment, volumeName2PVC Map<String,PersistentVolumeClaim>, pod PodData, container Container, volumes Map<String,Volume>) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.namespace.pvc.UniqueWorkspacePVCStrategy | From | To |