8ff1be36f5a3063e278bc728f81ed161cedb108b
Files Diff
- Added: 8
- Removed: 5
- Renamed: 0
- Modified: 43
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type gitHubClientService : GitHubClientService to gitHubClientService : GitHubServiceClient in method public GitHubHostingService(appContext AppContext, dtoFactory DtoFactory, gitHubClientService GitHubServiceClient, templates GitHubTemplates, securityTokenProvider SecurityTokenProvider, oAuthServiceClient OAuthServiceClient) in class org.eclipse.che.plugin.pullrequest.client.GitHubHostingService | From | To | |
| Change Parameter Type gitHubService : GitHubClientService to gitHubService : GitHubServiceClient in method public GitHubSshKeyUploader(gitHubService GitHubServiceClient, constant GitHubLocalizationConstant, notificationManager NotificationManager, productInfoDataProvider ProductInfoDataProvider, dialogFactory DialogFactory, appContext AppContext, securityTokenProvider SecurityTokenProvider, oAuthServiceClient OAuthServiceClient) in class org.eclipse.che.plugin.github.ide.GitHubSshKeyUploader | From | To | |
| Change Parameter Type gitHubClientService : GitHubClientService to gitHubClientService : GitHubServiceClient in method public GithubImporterPagePresenter(view GithubImporterPageView, gitHubAuthenticatorRegistry OAuth2AuthenticatorRegistry, gitHubClientService GitHubServiceClient, dtoFactory DtoFactory, appContext AppContext, locale GitHubLocalizationConstant, oAuthServiceClient OAuthServiceClient, notificationManager NotificationManager) in class org.eclipse.che.plugin.github.ide.importer.page.GithubImporterPagePresenter | From | To | |
| Pull Up Attribute | 4 | ||
| Pull Up Attribute private notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.fetch.FetchPresenter to protected notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.GitAuthActionPresenter | From | To | |
| Pull Up Attribute private notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.commit.CommitPresenter to protected notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.GitAuthActionPresenter | From | To | |
| Pull Up Attribute private notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.pull.PullPresenter to protected notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.GitAuthActionPresenter | From | To | |
| Pull Up Attribute private notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.push.PushToRemotePresenter to protected notificationManager : NotificationManager from class org.eclipse.che.ide.ext.git.client.GitAuthActionPresenter | From | To | |
| Rename Class | 3 | ||
| Rename Class org.eclipse.che.plugin.github.ide.GitHubClientService renamed to org.eclipse.che.plugin.github.ide.GitHubServiceClient | From | To | |
| Rename Class org.eclipse.che.api.core.cors.CheCorsFilter.CodenvyCorsFilterConfig renamed to org.eclipse.che.api.core.cors.CheCorsFilter.CheCorsFilterConfig | From | To | |
| Rename Class org.eclipse.che.plugin.github.ide.GitHubClientServiceImpl renamed to org.eclipse.che.plugin.github.ide.GitHubServiceClientImpl | From | To | |
| Move Class | 1 | ||
| Move Class org.eclipse.che.ide.ui.dialogs.askcredentials.Credentials moved to org.eclipse.che.ide.api.auth.Credentials | From | To | |
| Move And Rename Attribute | 1 | ||
| Move And Rename Attribute private appContext : AppContext renamed to private oAuthServiceClient : OAuthServiceClient and moved from class org.eclipse.che.ide.ext.git.client.push.PushToRemotePresenter to class org.eclipse.che.ide.projectimport.wizard.ProjectImporter | From | To | |
| Extract Method | 1 | ||
| Extract Method public pushBranchAuthenticated(remote String, localBranchName String, providerName String) : Promise<PushResponse> extracted from public pushBranch(project ProjectConfig, remote String, localBranchName String) : Promise<PushResponse> in class org.eclipse.che.plugin.pullrequest.client.vcs.GitVcsService | From | To | |
| Replace Attribute | 1 | ||
| Replace Attribute private constant : GitLocalizationConstant from class org.eclipse.che.ide.ext.git.client.commit.CommitPresenter with private locale : CoreLocalizationConstant from class org.eclipse.che.ide.factory.utils.FactoryProjectImporter | From | To | |
| Rename Method | 1 | ||
| Rename Method public connect() : GitHub renamed to public oauthConnect(oauthToken String) : GitHub in class org.eclipse.che.plugin.github.server.GitHubFactory | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.eclipse.che.ide.ext.git.client.GitAuthActionPresenter from classes [org.eclipse.che.ide.ext.git.client.commit.CommitPresenter, org.eclipse.che.ide.ext.git.client.fetch.FetchPresenter, org.eclipse.che.ide.ext.git.client.pull.PullPresenter, org.eclipse.che.ide.ext.git.client.push.PushToRemotePresenter] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute securityTokenPærovider : SecurityTokenProvider to securityTokenProvider : SecurityTokenProvider in class org.eclipse.che.plugin.github.ide.authenticator.GitHubAuthenticatorImpl | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.eclipse.che.plugin.github.ide.GitHubServiceClient from classes [org.eclipse.che.plugin.github.ide.GitHubServiceClientImpl] | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type gitHubClientService : GitHubClientService to gitHubClientService : GitHubServiceClient in class org.eclipse.che.plugin.pullrequest.client.GitHubHostingService | From | To | |
| Change Attribute Type gitHubClientService : GitHubClientService to gitHubClientService : GitHubServiceClient in class org.eclipse.che.plugin.github.ide.importer.page.GithubImporterPagePresenter | From | To | |
| Change Attribute Type gitHubService : GitHubClientService to gitHubService : GitHubServiceClient in class org.eclipse.che.plugin.github.ide.GitHubSshKeyUploader | From | To | |
| Change Attribute Type gitHubClientService : GitHubClientService to gitHubClientService : GitHubServiceClient in class org.eclipse.che.plugin.github.ide.importer.page.GithubImporterPagePresenterTest | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter head : String to oauthToken : String in method public getPullRequests(oauthToken String, owner String, repository String) : Promise<GitHubPullRequestList> in class org.eclipse.che.plugin.github.ide.GitHubServiceClient | From | To | |
| Rename Parameter securityTokenPærovider : SecurityTokenProvider to securityTokenProvider : SecurityTokenProvider in method public GitHubAuthenticatorImpl(registry SshKeyUploaderRegistry, sshServiceClient SshServiceClient, view GitHubAuthenticatorView, dialogFactory DialogFactory, locale GitHubLocalizationConstant, notificationManager NotificationManager, appContext AppContext, securityTokenProvider SecurityTokenProvider) in class org.eclipse.che.plugin.github.ide.authenticator.GitHubAuthenticatorImpl | From | To | |
| Rename Parameter head : String to oauthToken : String in method public getPullRequests(oauthToken String, owner String, repository String) : Promise<GitHubPullRequestList> in class org.eclipse.che.plugin.github.ide.GitHubServiceClientImpl | From | To |