95a4f192ce3b5e402fafe4db01963eba84d656e9
Files Diff
- Added: 48
- Removed: 1
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public getaPIVersion() : String renamed to public getApiVersion() : String in class org.eclipse.che.plugin.docker.client.json.Version | From | To | |
| Rename Method public shouldProduceAnErrorWhenPutsResourcesIntoContainer() : void renamed to public shouldProduceErrorWhenPutsResourcesIntoContainerIfResponseCodeIsNotSuccess() : void in class org.eclipse.che.plugin.docker.client.DockerConnectorTest | From | To | |
| Rename Method public setaPIVersion(aPIVersion String) : void renamed to public setApiVersion(apiVersion String) : void in class org.eclipse.che.plugin.docker.client.json.Version | From | To | |
| Rename Variable | 2 | ||
| Rename Variable entity : String to entityBytesArray : byte[] in method public startExec(params StartExecParams, execOutputProcessor MessageProcessor<LogMessage>) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Rename Variable entity : String to entityBytesArray : byte[] in method public createExec(params CreateExecParams) : Exec in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Image[] to List<Image> in method public listImages() : List<Image> in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private RESPONSE_ERROR_CODE : int in class org.eclipse.che.plugin.docker.client.DockerConnectorTest | From | To | |
| Rename Class | 1 | ||
| Rename Class org.eclipse.che.plugin.docker.client.json.ContainerCommited renamed to org.eclipse.che.plugin.docker.client.json.ContainerCommitted | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute msg : String to ERROR_MESSAGE : String in method public shouldProduceErrorWhenPutsResourcesIntoContainerIfResponseCodeIsNotSuccess() : void in class org.eclipse.che.plugin.docker.client.DockerConnectorTest | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [image : String, registry : String] to params : PullParams in method private pull(params PullParams, progressMonitor ProgressMonitor, dockerDaemonUri URI) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute aPIVersion : String to apiVersion : String in class org.eclipse.che.plugin.docker.client.json.Version | From | To | |
| Extract Variable | 1 | ||
| Extract Variable entityBytesArray : byte[] in method protected doStartContainer(container String, hostConfig HostConfig, dockerDaemonUri URI) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type entity : String to entityBytesArray : byte[] in method public startExec(params StartExecParams, execOutputProcessor MessageProcessor<LogMessage>) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Change Variable Type entity : String to entityBytesArray : byte[] in method public createExec(params CreateExecParams) : Exec in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable | 22 | ||
| Inline Variable status : int in method protected doInspectImage(image String, dockerDaemonUri URI) : ImageInfo from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public top(container String, psArgs String...) : ContainerProcesses from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doCreateContainer(containerConfig ContainerConfig, containerName String, dockerDaemonUri URI) : ContainerCreated from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public removeContainer(container String, force boolean, removeVolumes boolean) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doCommit(container String, repository String, tag String, comment String, author String, dockerDaemonUri URI) : String from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public getResource(container String, sourcePath String) : InputStream from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public listImages() : Image[] from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public createExec(container String, detach boolean, cmd String...) : Exec from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public putResource(container String, targetPath String, sourceStream InputStream, noOverwriteDirNonDir boolean) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public getExecInfo(execId String) : ExecInfo from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doInspectContainer(container String, dockerDaemonUri URI) : ContainerInfo from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public getEvents(sinceSecond long, untilSecond long, filters Filters, messageProcessor MessageProcessor<Event>) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public attachContainer(container String, containerLogsProcessor MessageProcessor<LogMessage>, stream boolean) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doPull(image String, tag String, registry String, progressMonitor ProgressMonitor, dockerDaemonUri URI) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public killContainer(container String, signal int) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doRemoveImage(image String, force boolean, dockerDaemonUri URI) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public getSystemInfo() : SystemInfo from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doTag(image String, repository String, tag String, dockerDaemonUri URI) : void from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public getVersion() : Version from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method public waitContainer(container String) : int from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doBuildImage(repository String, tar File, progressMonitor ProgressMonitor, dockerDaemonUri URI, authConfigs AuthConfigs, doForcePull boolean, memoryLimit long, memorySwapLimit long) : String from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Inline Variable status : int in method protected doPush(repository String, tag String, registry String, progressMonitor ProgressMonitor, dockerDaemonUri URI) : String from class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method | 28 | ||
| Extract Method private inspectContainer(params InspectContainerParams, dockerDaemonUri URI) : ContainerInfo extracted from protected doInspectContainer(container String, dockerDaemonUri URI) : ContainerInfo in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public attachContainer(params AttachContainerParams, containerLogsProcessor MessageProcessor<LogMessage>) : void extracted from public attachContainer(container String, containerLogsProcessor MessageProcessor<LogMessage>, stream boolean) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public removeContainer(params RemoveContainerParams) : void extracted from public removeContainer(container String, force boolean, removeVolumes boolean) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private addQueryParamIfNotNull(connection DockerConnection, queryParamName String, paramValue Object) : void extracted from protected doTag(image String, repository String, tag String, dockerDaemonUri URI) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public startExec(params StartExecParams, execOutputProcessor MessageProcessor<LogMessage>) : void extracted from public startExec(execId String, execOutputProcessor MessageProcessor<LogMessage>) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public top(params TopParams) : ContainerProcesses extracted from public top(container String, psArgs String...) : ContainerProcesses in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private addQueryParamIfNotNull(connection DockerConnection, queryParamName String, paramValue Object) : void extracted from protected doCreateContainer(containerConfig ContainerConfig, containerName String, dockerDaemonUri URI) : ContainerCreated in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public getResource(params GetResourceParams) : InputStream extracted from public getResource(container String, sourcePath String) : InputStream in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public putResource(params PutResourceParams) : void extracted from public putResource(container String, targetPath String, sourceStream InputStream, noOverwriteDirNonDir boolean) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private removeImage(params RemoveImageParams, dockerDaemonUri URI) : void extracted from protected doRemoveImage(image String, force boolean, dockerDaemonUri URI) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private inspectImage(params InspectImageParams, dockerDaemonUri URI) : ImageInfo extracted from protected doInspectImage(image String, dockerDaemonUri URI) : ImageInfo in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public killContainer(params KillContainerParams) : void extracted from public killContainer(container String, signal int) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private push(params PushParams, progressMonitor ProgressMonitor, dockerDaemonUri URI) : String extracted from protected doPush(repository String, tag String, registry String, progressMonitor ProgressMonitor, dockerDaemonUri URI) : String in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private commit(params CommitParams, dockerDaemonUri URI) : String extracted from protected doCommit(container String, repository String, tag String, comment String, author String, dockerDaemonUri URI) : String in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public stopContainer(params StopContainerParams) : void extracted from public stopContainer(container String, timeout long, timeunit TimeUnit) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public getExecInfo(params GetExecInfoParams) : ExecInfo extracted from public getExecInfo(execId String) : ExecInfo in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private buildImage(params BuildImageParams, progressMonitor ProgressMonitor, tar File, dockerDaemonUri URI) : String extracted from protected doBuildImage(repository String, tar File, progressMonitor ProgressMonitor, dockerDaemonUri URI, authConfigs AuthConfigs, doForcePull boolean, memoryLimit long, memorySwapLimit long) : String in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private addQueryParamIfNotNull(connection DockerConnection, queryParamName String, paramValue Object) : void extracted from protected doBuildImage(repository String, tar File, progressMonitor ProgressMonitor, dockerDaemonUri URI, authConfigs AuthConfigs, doForcePull boolean, memoryLimit long, memorySwapLimit long) : String in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private tag(params TagParams, dockerDaemonUri URI) : void extracted from protected doTag(image String, repository String, tag String, dockerDaemonUri URI) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private addQueryParamIfNotNull(connection DockerConnection, queryParamName String, paramValue Object) : void extracted from public getEvents(sinceSecond long, untilSecond long, filters Filters, messageProcessor MessageProcessor<Event>) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private pull(params PullParams, progressMonitor ProgressMonitor, dockerDaemonUri URI) : void extracted from protected doPull(image String, tag String, registry String, progressMonitor ProgressMonitor, dockerDaemonUri URI) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public getEvents(params GetEventsParams, messageProcessor MessageProcessor<Event>) : void extracted from public getEvents(sinceSecond long, untilSecond long, filters Filters, messageProcessor MessageProcessor<Event>) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public waitContainer(params WaitContainerParams) : int extracted from public waitContainer(container String) : int in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method public createExec(params CreateExecParams) : Exec extracted from public createExec(container String, detach boolean, cmd String...) : Exec in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private createContainer(params CreateContainerParams, dockerDaemonUri URI) : ContainerCreated extracted from protected doCreateContainer(containerConfig ContainerConfig, containerName String, dockerDaemonUri URI) : ContainerCreated in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private addQueryParamIfNotNull(connection DockerConnection, queryParamName String, paramValue Object) : void extracted from protected doPull(image String, tag String, registry String, progressMonitor ProgressMonitor, dockerDaemonUri URI) : void in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private addQueryParamIfNotNull(connection DockerConnection, queryParamName String, paramValue Object) : void extracted from protected doPush(repository String, tag String, registry String, progressMonitor ProgressMonitor, dockerDaemonUri URI) : String in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Extract Method private addQueryParamIfNotNull(connection DockerConnection, queryParamName String, paramValue Object) : void extracted from protected doCommit(container String, repository String, tag String, comment String, author String, dockerDaemonUri URI) : String in class org.eclipse.che.plugin.docker.client.DockerConnector | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter aPIVersion : String to apiVersion : String in method public setApiVersion(apiVersion String) : void in class org.eclipse.che.plugin.docker.client.json.Version | From | To |