96f35085e888ab3dc9ffe48d45c9daa09f4ae56a
Files Diff
- Added: 26
- Removed: 6
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public shouldReturnEnvironmentWithCorrectRecipeTypeAndContentFromK8SList() : void renamed to public shouldProvisionEnvironmentWithCorrectRecipeTypeAndContentFromOSList() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Rename Method public shouldReturnEmptyOptionalWhenNoRecipeToolIsPresent() : void renamed to public shouldThrowExceptionWhenRecipeContentIsNotAValidYaml() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type devfile : Devfile to workspaceConfig : WorkspaceConfig in method private estimateCommandsMachineName(workspaceConfig WorkspaceConfig, tool Tool, recipeObjects KubernetesList) : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Move Method | 1 | ||
| Move Method private initializeMaps(devfile Devfile) : void from class org.eclipse.che.api.devfile.server.DevfileManager to public initializeMaps(devfile Devfile) : void from class org.eclipse.che.api.devfile.server.DevfileFactory | From | To | |
| Rename Variable | 4 | ||
| Rename Variable toolsCommands : List<Command> to toolCommands : List<? extends Command> in method private estimateCommandsMachineName(workspaceConfig WorkspaceConfig, tool Tool, recipeObjects KubernetesList) : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Rename Variable ws : WorkspaceImpl to wsConfig : WorkspaceConfigImpl in method public shouldFindAvailableNameAndCreateWorkspace() : void in class org.eclipse.che.api.devfile.server.DevfileManagerTest | From | To | |
| Rename Variable command : Command to actualCommand : CommandImpl in method public shouldSetMachineNameAttributeToCommandConfiguredInOpenShiftToolWithOneContainer() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Rename Variable command : Command to actualCommand : CommandImpl in method public shouldNotSetMachineNameAttributeToCommandConfiguredInOpenShiftToolWithMultipleContainers() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private objectMapper : ObjectMapper from class org.eclipse.che.api.devfile.server.DevfileConverterTest to private objectMapper : ObjectMapper from class org.eclipse.che.api.devfile.server.DevfileManagerTest | From | To | |
| Move And Rename Class | 3 | ||
| Move And Rename Class org.eclipse.che.api.devfile.server.KubernetesToolApplierTest moved and renamed to org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Move And Rename Class org.eclipse.che.api.devfile.server.KubernetesToolApplier moved and renamed to org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Move And Rename Class org.eclipse.che.api.devfile.server.DockerimageToolApplierTest moved and renamed to org.eclipse.che.api.devfile.server.convert.tool.dockerimage.DockerimageToolToWorkspaceApplierTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute applier : DockerimageToolApplier to dockerimageToolApplier : DockerimageToolToWorkspaceApplier in class org.eclipse.che.api.devfile.server.convert.tool.dockerimage.DockerimageToolToWorkspaceApplierTest | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type command : Command to actualCommand : CommandImpl in method public shouldNotSetMachineNameAttributeToCommandConfiguredInOpenShiftToolWithMultipleContainers() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Change Variable Type toolsCommands : List<Command> to toolCommands : List<? extends Command> in method private estimateCommandsMachineName(workspaceConfig WorkspaceConfig, tool Tool, recipeObjects KubernetesList) : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Change Variable Type ws : WorkspaceImpl to wsConfig : WorkspaceConfigImpl in method public shouldFindAvailableNameAndCreateWorkspace() : void in class org.eclipse.che.api.devfile.server.DevfileManagerTest | From | To | |
| Change Variable Type command : Command to actualCommand : CommandImpl in method public shouldSetMachineNameAttributeToCommandConfiguredInOpenShiftToolWithOneContainer() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Extract Method | 4 | ||
| Extract Method private getResource(resourceName String) : String extracted from public shouldReturnEnvironmentWithCorrectRecipeTypeAndContentFromK8SList() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Extract Method private getResource(resourceName String) : String extracted from public shouldFilterRecipeWithGivenSelectors() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Extract Method private getResource(resourceName String) : String extracted from public shouldSetMachineNameAttributeToCommandConfiguredInOpenShiftToolWithOneContainer() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Extract Method private getResource(resourceName String) : String extracted from public shouldNotSetMachineNameAttributeToCommandConfiguredInOpenShiftToolWithMultipleContainers() : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type applier : KubernetesToolApplier to applier : KubernetesToolToWorkspaceApplier in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplierTest | From | To | |
| Change Attribute Type applier : DockerimageToolApplier to dockerimageToolApplier : DockerimageToolToWorkspaceApplier in class org.eclipse.che.api.devfile.server.convert.tool.dockerimage.DockerimageToolToWorkspaceApplierTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter devfile : Devfile to workspaceConfig : WorkspaceConfig in method private estimateCommandsMachineName(workspaceConfig WorkspaceConfig, tool Tool, recipeObjects KubernetesList) : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To | |
| Rename Parameter recipeTool : Tool to k8sTool : Tool in method public apply(workspaceConfig WorkspaceConfigImpl, k8sTool Tool, contentProvider FileContentProvider) : void in class org.eclipse.che.api.devfile.server.convert.tool.kubernetes.KubernetesToolToWorkspaceApplier | From | To |