9f88048572795ac8dcb4c40bfff8ae5a773136b7
Files Diff
- Added: 7
- Removed: 1
- Renamed: 0
- Modified: 43
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type completionItem : CompletionItem to completionItem : ExtendedCompletionItem in method public resolveCompletionItem(completionItem ExtendedCompletionItem) : Promise<ExtendedCompletionItem> in class org.eclipse.che.plugin.languageserver.ide.service.TextDocumentServiceClient | From | To | |
| Change Parameter Type diagnosticsMessage : PublishDiagnosticsParams to diagnosticsMessage : ExtendedPublishDiagnosticsParams in method public processDiagnostics(diagnosticsMessage ExtendedPublishDiagnosticsParams) : void in class org.eclipse.che.plugin.languageserver.ide.editor.PublishDiagnosticsProcessor | From | To | |
| Move Method | 2 | ||
| Move Method public getInitializeResult() : InitializeResult from class org.eclipse.che.api.languageserver.registry.LanguageServerDescription to public getInitializeResult() : InitializeResult from class org.eclipse.che.api.languageserver.registry.InitializedLanguageServer | From | To | |
| Move Method protected shutdown() : void from class org.eclipse.che.api.languageserver.registry.ServerInitializerImpl to protected shutdown() : void from class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImpl | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private initializeResult : InitializeResult from class org.eclipse.che.api.languageserver.registry.LanguageServerDescription to private initializeResult : InitializeResult from class org.eclipse.che.api.languageserver.registry.InitializedLanguageServer | From | To | |
| Extract Variable | 14 | ||
| Extract Variable uri : String in method private formatting(documentFormattingParams DocumentFormattingParams) : List<TextEditDto> from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private definition(textDocumentPositionParams TextDocumentPositionParams) : List<LocationDto> from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private didChange(didChangeTextDocumentParams DidChangeTextDocumentParams) : void from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private completion(textDocumentPositionParams TextDocumentPositionParams) : ExtendedCompletionListDto from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private didClose(didCloseTextDocumentParams DidCloseTextDocumentParams) : void from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private rangeFormatting(documentRangeFormattingParams DocumentRangeFormattingParams) : List<TextEditDto> from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private didSave(didSaveTextDocumentParams DidSaveTextDocumentParams) : void from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private documentSymbol(documentSymbolParams DocumentSymbolParams) : List<SymbolInformationDto> from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private hover(positionParams TextDocumentPositionParams) : HoverDto from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private signatureHelp(positionParams TextDocumentPositionParams) : SignatureHelpDto from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private onTypeFormatting(documentOnTypeFormattingParams DocumentOnTypeFormattingParams) : List<TextEditDto> from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private references(referenceParams ReferenceParams) : List<LocationDto> from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private documentHighlight(textDocumentPositionParams TextDocumentPositionParams) : DocumentHighlightDto from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Extract Variable uri : String in method private didOpen(openTextDocumentParams DidOpenTextDocumentParams) : void from class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type server : LanguageServer to cap : ServerCapabilities in method public testFindServer() : void in class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImplTest | From | To | |
| Change Variable Type promise : Promise<ExtendedInitializeResult> to promise : Promise<ServerCapabilities> in method public createEditor(file VirtualFile) : Promise<EditorPartPresenter> in class org.eclipse.che.plugin.languageserver.ide.editor.LanguageServerEditorProvider | From | To | |
| Split Attribute | 3 | ||
| Split Attribute initializeResult : InitializeResult to [serverDescription : LanguageServerDescription, languageServerLauncher : LanguageServerLauncher] in class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImplTest | From | To | |
| Split Attribute languageServerLauncher : LanguageServerLauncher to [pm : ProjectManager, pmp : Provider<ProjectManager>] in class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImplTest | From | To | |
| Split Attribute completableFuture : CompletableFuture<InitializeResult> to [projectsRoot : FolderEntry, pm : ProjectManager] in class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImplTest | From | To | |
| Rename Method | 1 | ||
| Rename Method private findLanguageId(path String) : LanguageDescription renamed to private findLanguage(path String) : LanguageDescription in class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImpl | From | To | |
| Rename Variable | 1 | ||
| Rename Variable server : LanguageServer to cap : ServerCapabilities in method public testFindServer() : void in class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImplTest | From | To | |
| Inline Method | 1 | ||
| Inline Method protected doInitialize(language LanguageDescription, launcher LanguageServerLauncher, projectPath String) : LanguageServer inlined to public initialize(launcher LanguageServerLauncher, client LanguageClient, projectPath String) : CompletableFuture<Pair<LanguageServer,InitializeResult>> in class org.eclipse.che.api.languageserver.registry.ServerInitializerImpl | From | To | |
| Change Return Type | 8 | ||
| Change Return Type Promise<ExtendedInitializeResult> to Promise<ServerCapabilities> in method public getOrInitializeServer(projectPath String, file VirtualFile) : Promise<ServerCapabilities> in class org.eclipse.che.plugin.languageserver.ide.registry.LanguageServerRegistry | From | To | |
| Change Return Type List<DocumentHighlightDto> to DocumentHighlightDto in method private documentHighlight(textDocumentPositionParams TextDocumentPositionParams) : DocumentHighlightDto in class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Change Return Type CompletionItemDto to ExtendedCompletionItemDto in method private completionItemResolve(unresolved ExtendedCompletionItem) : ExtendedCompletionItemDto in class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Change Return Type void to ServerCapabilitiesDto in method public initialize(path String) : ServerCapabilitiesDto in class org.eclipse.che.api.languageserver.service.LanguageRegistryService | From | To | |
| Change Return Type LanguageServer to CompletableFuture<Pair<LanguageServer,InitializeResult>> in method public initialize(launcher LanguageServerLauncher, client LanguageClient, projectPath String) : CompletableFuture<Pair<LanguageServer,InitializeResult>> in class org.eclipse.che.api.languageserver.registry.ServerInitializer | From | To | |
| Change Return Type JsonRpcPromise<Boolean> to Promise<ServerCapabilities> in method public initializeServer(path String) : Promise<ServerCapabilities> in class org.eclipse.che.plugin.languageserver.ide.service.LanguageServerRegistryJsonRpcClient | From | To | |
| Change Return Type LanguageServer to CompletableFuture<Pair<LanguageServer,InitializeResult>> in method public initialize(launcher LanguageServerLauncher, client LanguageClient, projectPath String) : CompletableFuture<Pair<LanguageServer,InitializeResult>> in class org.eclipse.che.api.languageserver.registry.ServerInitializerImpl | From | To | |
| Change Return Type CompletionListDto to ExtendedCompletionListDto in method private completion(textDocumentPositionParams TextDocumentPositionParams) : ExtendedCompletionListDto in class org.eclipse.che.api.languageserver.service.TextDocumentService | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute initializeResult : InitializeResult to languageIds : List<String> in class org.eclipse.che.api.languageserver.registry.LanguageServerDescription | From | To | |
| Rename Attribute languageDescription : LanguageDescription to documentFilters : List<DocumentFilter> in class org.eclipse.che.api.languageserver.registry.LanguageServerDescription | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type languageDescription : LanguageDescription to documentFilters : List<DocumentFilter> in class org.eclipse.che.api.languageserver.registry.LanguageServerDescription | From | To | |
| Change Attribute Type generatedAnnotations : List<DiagnosticAnnotation> to generatedAnnotations : Map<Diagnostic,DiagnosticAnnotation> in class org.eclipse.che.plugin.languageserver.ide.editor.LanguageServerAnnotationModel | From | To | |
| Change Attribute Type diagnostics : List<Diagnostic> to diagnostics : Map<String,List<Diagnostic>> in class org.eclipse.che.plugin.languageserver.ide.editor.LanguageServerAnnotationModel | From | To | |
| Change Attribute Type launchers : Map<String,LanguageServerLauncher> to launchers : List<LanguageServerLauncher> in class org.eclipse.che.api.languageserver.registry.LanguageServerRegistryImpl | From | To | |
| Change Attribute Type initializeResult : InitializeResult to languageIds : List<String> in class org.eclipse.che.api.languageserver.registry.LanguageServerDescription | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getItem() : CompletionItem extracted from private computeProposals(currentWord String, offset int, callback CodeAssistCallback) : void in class org.eclipse.che.plugin.languageserver.ide.editor.codeassist.LanguageServerCodeAssistProcessor & moved to class org.eclipse.che.api.languageserver.shared.model.ExtendedCompletionItem | From | To |