a7e9aeaaddf06a5abf3858a2e8264753b6ab26f8
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method protected createInstanceFromImage(machine Machine, machineContainerName String, creationLogsOutput LineConsumer) : Instance renamed to protected pullImage(machineConfig MachineConfig, machineImageName String, progressMonitor ProgressMonitor) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Rename Variable | 5 | ||
| Rename Variable creationLogsOutput : LineConsumer to machineConfig : MachineConfig in method public invoke(methodInvocation MethodInvocation) : Object in class org.eclipse.che.plugin.docker.machine.local.interceptor.EnableOfflineDockerMachineBuildInterceptor | From | To | |
| Rename Variable dockerfile : Dockerfile to progressMonitor : ProgressMonitor in method public invoke(methodInvocation MethodInvocation) : Object in class org.eclipse.che.plugin.docker.machine.local.interceptor.EnableOfflineDockerMachineBuildInterceptor | From | To | |
| Rename Variable type : String to sourceType : String in method public createInstance(machine Machine, creationLogsOutput LineConsumer) : Instance in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Rename Variable machineContainerName : String to containerName : String in method public createInstance(machine Machine, creationLogsOutput LineConsumer) : Instance in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Rename Variable machineImageName : String to imageName : String in method public createInstance(machine Machine, creationLogsOutput LineConsumer) : Instance in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Inline Method | 2 | ||
| Inline Method private pullImage(dockerMachineSource DockerMachineSource, creationLogsOutput LineConsumer) : void inlined to protected pullImage(machineConfig MachineConfig, machineImageName String, progressMonitor ProgressMonitor) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Inline Method private getDockerFile(recipe Recipe) : Dockerfile inlined to public parseRecipe(recipe Recipe) : Dockerfile in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Instance to void in method protected pullImage(machineConfig MachineConfig, machineImageName String, progressMonitor ProgressMonitor) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute isForcePullEnabled : boolean to doForcePullOnBuild : boolean in method public invoke(methodInvocation MethodInvocation) : Object in class org.eclipse.che.plugin.docker.machine.local.interceptor.EnableOfflineDockerMachineBuildInterceptor | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type creationLogsOutput : LineConsumer to machineConfig : MachineConfig in method public invoke(methodInvocation MethodInvocation) : Object in class org.eclipse.che.plugin.docker.machine.local.interceptor.EnableOfflineDockerMachineBuildInterceptor | From | To | |
| Change Variable Type dockerfile : Dockerfile to progressMonitor : ProgressMonitor in method public invoke(methodInvocation MethodInvocation) : Object in class org.eclipse.che.plugin.docker.machine.local.interceptor.EnableOfflineDockerMachineBuildInterceptor | From | To | |
| Extract Variable | 2 | ||
| Extract Variable config : MachineConfig in method public createInstance(machine Machine, creationLogsOutput LineConsumer) : Instance from class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Extract Variable source : MachineSource in method protected pullImage(machineConfig MachineConfig, machineImageName String, progressMonitor ProgressMonitor) : void from class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Extract Method | 1 | ||
| Extract Method protected buildImage(machineConfig MachineConfig, machineImageName String, doForcePullOnBuild boolean, progressMonitor ProgressMonitor) : void extracted from public createInstance(machine Machine, creationLogsOutput LineConsumer) : Instance in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter machineContainerName : String to machineImageName : String in method protected pullImage(machineConfig MachineConfig, machineImageName String, progressMonitor ProgressMonitor) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To |