aaa8f424cd198e68e128bca939d9ac058b9ea52e
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 50
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method public shouldFailValidationIfDefaultEnvNameIsEmpty() : void renamed to public shouldFailValidationOfChe6WSIfDefaultEnvNameIsEmpty() : void in class org.eclipse.che.api.workspace.server.WorkspaceValidatorTest | From | To | |
Rename Method public shouldFailValidationIfDefaultEnvNameIsNull() : void renamed to public shouldFailValidationOfChe6WSIfDefaultEnvNameIsNull() : void in class org.eclipse.che.api.workspace.server.WorkspaceValidatorTest | From | To | |
Change Return Type | 1 | ||
Change Return Type RuntimeId to RuntimeIdentity in method public getRuntimeId() : RuntimeIdentity in class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState | From | To | |
Move Attribute | 3 | ||
Move Attribute private envName : String from class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState.RuntimeId to private envName : String from class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState | From | To | |
Move Attribute private workspaceId : String from class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState.RuntimeId to private workspaceId : String from class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState | From | To | |
Move Attribute private ownerId : String from class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState.RuntimeId to private ownerId : String from class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState | From | To | |
Change Variable Type | 11 | ||
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldGetMachines() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldUpdateMachineStatus() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldRemoveMachines() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Change Variable Type toRemove : RuntimeId to toRemove : RuntimeIdentity in method public shouldDoNothingIfStateIsAlreadyRemove() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesRuntimeStateCacheTest | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldUpdateMachineStatusServerStatus() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldThrowExceptionWhenServerWasNotFoundOnGetting() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Change Variable Type toRemove : RuntimeId to toRemove : RuntimeIdentity in method public shouldRemoveRuntimeState() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesRuntimeStateCacheTest | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldThrowExceptionWhenServerWasNotFoundOnStatusUpdating() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public onCascadeEvent(event BeforeWorkspaceRemovedEvent) : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.jpa.JpaKubernetesRuntimeStateCache.RemoveKubernetesRuntimeBeforeWorkspaceRemoved | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldUpdateServerStatus() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Change Variable Type runtimeId : RuntimeId to runtimeId : RuntimeIdentity in method public shouldGetServer() : void in class org.eclipse.che.workspace.infrastructure.kubernetes.cache.tck.KubernetesMachinesCacheTest | From | To | |
Extract Variable | 1 | ||
Extract Variable environment : EnvironmentImpl in method public getProjectsRoot() : Path from class org.eclipse.che.ide.context.AppContextImpl | From | To | |
Extract Method | 2 | ||
Extract Method private getValidatedEnvironmentName(workspace WorkspaceImpl, envName String) : String extracted from private startAsync(workspace WorkspaceImpl, envName String, options Map<String,String>) : void in class org.eclipse.che.api.workspace.server.WorkspaceManager | From | To | |
Extract Method private validateEnvironments(config WorkspaceConfig) : void extracted from public validateConfig(config WorkspaceConfig) : void in class org.eclipse.che.api.workspace.server.WorkspaceValidator | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type runtimesStates : Map<RuntimeId,KubernetesRuntimeState> to runtimesStates : Map<RuntimeIdentity,KubernetesRuntimeState> in class org.eclipse.che.workspace.infrastructure.kubernetes.KubernetesInternalRuntimeTest.MapBasedRuntimeStateCache | From | To | |
Rename Parameter | 1 | ||
Rename Parameter obj : Object to o : Object in method public equals(o Object) : boolean in class org.eclipse.che.workspace.infrastructure.kubernetes.model.KubernetesRuntimeState | From | To |