ae4c5521bf2202740fc211ee3d2e94881e414d59
Files Diff
- Added: 7
- Removed: 4
- Renamed: 0
- Modified: 34
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 5 | ||
| Change Parameter Type machine : Machine to machine : MachineImpl in method private createInstanceFromSnapshot(machine MachineImpl, dockerMachineSource DockerMachineSource) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProviderTest | From | To | |
| Change Parameter Type instanceKey : InstanceKey to machineSource : MachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.api.machine.server.spi.InstanceProvider | From | To | |
| Change Parameter Type instanceKey : InstanceKey to machineSource : MachineSource in method public SnapshotImpl(id String, type String, machineSource MachineSource, namespace String, creationDate long, workspaceId String, description String, isDev boolean, machineName String, envName String) in class org.eclipse.che.api.machine.server.model.impl.SnapshotImpl | From | To | |
| Change Parameter Type instanceKey : InstanceKey to machineSource : MachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Change Parameter Type instanceKey : InstanceKey to machineSource : MachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.plugin.machine.ssh.SshMachineInstanceProvider | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.MachineManagerTest to private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.util.RecipeRetriever | From | To | |
| Move Attribute private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.MachineManager to private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.util.RecipeRetrieverTest | From | To | |
| Move Attribute private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.MachineManager to private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.util.RecipeRetriever | From | To | |
| Move Attribute private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.MachineManagerTest to private recipeDownloader : RecipeDownloader from class org.eclipse.che.api.machine.server.util.RecipeRetrieverTest | From | To | |
| Rename Class | 1 | ||
| Rename Class org.eclipse.che.plugin.docker.machine.DockerInstanceKey renamed to org.eclipse.che.plugin.docker.machine.DockerMachineSource | From | To | |
| Extract Variable | 1 | ||
| Extract Variable machine : MachineImpl in method public shouldUseLocalImageOnInstanceCreationFromSnapshot() : void from class org.eclipse.che.plugin.docker.machine.DockerInstanceProviderTest | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type result : InstanceKey to result : MachineSource in method public shouldSaveDockerInstanceStateIntoLocalImage() : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceTest | From | To | |
| Change Variable Type dockerInstanceKey : DockerInstanceKey to dockerMachineSource : DockerMachineSource in method protected createInstanceFromImage(machine Machine, machineContainerName String, creationLogsOutput LineConsumer) : Instance in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Change Variable Type instanceKey : DockerInstanceKey to dockerMachineSource : DockerMachineSource in method public shouldRemoveLocalImageDuringRemovalOfSnapshot() : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProviderTest | From | To | |
| Change Variable Type recipeUrl : String to machineSource : MachineSource in method public onMachineDestroyed(event MachineStateEvent) : void in class org.eclipse.che.ide.extension.machine.client.machine.MachineManagerImpl.restartMachine.addHandler | From | To | |
| Change Variable Type result : InstanceKey to result : MachineSource in method public shouldSaveDockerInstanceStateIntoRepository() : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceTest | From | To | |
| Change Variable Type dockerInstanceKey : DockerInstanceKey to dockerMachineSource : DockerMachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Extract Method | 1 | ||
| Extract Method private startMachine(machineSourceDto MachineSourceDto, displayName String, isDev boolean, operationType MachineOperationType, machineType String) : void extracted from private startMachine(recipeURL String, displayName String, isDev boolean, operationType MachineOperationType, sourceType String, machineType String) : void in class org.eclipse.che.ide.extension.machine.client.machine.MachineManagerImpl | From | To | |
| Rename Method | 2 | ||
| Rename Method public getFullName() : String renamed to public getLocation(includeDigest boolean) : String in class org.eclipse.che.plugin.docker.machine.DockerMachineSource | From | To | |
| Rename Method public createInstance(instanceKey InstanceKey, machine Machine, creationLogsOutput LineConsumer) : Instance renamed to protected createInstanceFromImage(machine Machine, machineContainerName String, creationLogsOutput LineConsumer) : Instance in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Inline Method | 1 | ||
| Inline Method private parseRecipe(recipe Recipe) : SshMachineRecipe inlined to public createInstance(machine Machine, lineConsumer LineConsumer) : Instance in class org.eclipse.che.plugin.machine.ssh.SshMachineInstanceProvider | From | To | |
| Rename Variable | 4 | ||
| Rename Variable instanceKey : DockerInstanceKey to dockerMachineSource : DockerMachineSource in method public shouldRemoveLocalImageDuringRemovalOfSnapshot() : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProviderTest | From | To | |
| Rename Variable recipeUrl : String to machineSource : MachineSource in method public onMachineDestroyed(event MachineStateEvent) : void in class org.eclipse.che.ide.extension.machine.client.machine.MachineManagerImpl.restartMachine.addHandler | From | To | |
| Rename Variable dockerInstanceKey : DockerInstanceKey to dockerMachineSource : DockerMachineSource in method protected createInstanceFromImage(machine Machine, machineContainerName String, creationLogsOutput LineConsumer) : Instance in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Rename Variable dockerInstanceKey : DockerInstanceKey to dockerMachineSource : DockerMachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Change Return Type | 3 | ||
| Change Return Type InstanceKey to MachineSource in method public saveToSnapshot(owner String) : MachineSource in class org.eclipse.che.plugin.docker.machine.DockerInstance | From | To | |
| Change Return Type InstanceKey to MachineSource in method public saveToSnapshot(owner String) : MachineSource in class org.eclipse.che.plugin.machine.ssh.SshMachineInstance | From | To | |
| Change Return Type InstanceKey to MachineSource in method public saveToSnapshot(owner String) : MachineSource in class org.eclipse.che.api.machine.server.spi.Instance | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable sourceDto : MachineSourceDto to machineSourceDto : MachineSourceDto in method private startMachine(machineSourceDto MachineSourceDto, displayName String, isDev boolean, operationType MachineOperationType, machineType String) : void in class org.eclipse.che.ide.extension.machine.client.machine.MachineManagerImpl | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute tag : String to LATEST_TAG : String in method public saveToSnapshot(owner String) : MachineSource in class org.eclipse.che.plugin.docker.machine.DockerInstance | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute instanceKey : InstanceKeyImpl to machineSource : MachineSourceImpl in class org.eclipse.che.api.machine.server.model.impl.SnapshotImpl | From | To | |
| Rename Attribute instanceKey : InstanceKey to machineSource : MachineSource in class org.eclipse.che.api.machine.server.model.impl.SnapshotImpl.SnapshotBuilder | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type instanceKey : InstanceKeyImpl to machineSource : MachineSourceImpl in class org.eclipse.che.api.machine.server.model.impl.SnapshotImpl | From | To | |
| Change Attribute Type instanceKey : InstanceKey to machineSource : MachineSource in class org.eclipse.che.api.machine.server.model.impl.SnapshotImpl.SnapshotBuilder | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter machineLogsConsumer : LineConsumer to lineConsumer : LineConsumer in method public createInstance(machine Machine, lineConsumer LineConsumer) : Instance in class org.eclipse.che.plugin.machine.ssh.SshMachineInstanceProvider | From | To | |
| Rename Parameter instanceKey : InstanceKey to machineSource : MachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.plugin.docker.machine.DockerInstanceProvider | From | To | |
| Rename Parameter instanceKey : InstanceKey to machineSource : MachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.plugin.machine.ssh.SshMachineInstanceProvider | From | To | |
| Rename Parameter instanceKey : InstanceKey to machineSource : MachineSource in method public removeInstanceSnapshot(machineSource MachineSource) : void in class org.eclipse.che.api.machine.server.spi.InstanceProvider | From | To | |
| Rename Parameter instanceKey : InstanceKey to machineSource : MachineSource in method public SnapshotImpl(id String, type String, machineSource MachineSource, namespace String, creationDate long, workspaceId String, description String, isDev boolean, machineName String, envName String) in class org.eclipse.che.api.machine.server.model.impl.SnapshotImpl | From | To |