af2f1098d7fafbac8faf463c5672d23d68ec2c80
Files Diff
- Added: 50
- Removed: 8
- Renamed: 0
- Modified: 43
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public shouldThrowNotFoundExceptionIfMachineManagerExecInDevMachineThrowsNotFoundException() : void renamed to public shouldThrowMachineExceptionIfMachineManagerExecInDevMachineThrowsNotFoundException() : void in class org.eclipse.che.api.workspace.server.launcher.WsAgentLauncherImplTest | From | To | |
| Rename Method public launchTerminal(machine Instance) : void renamed to public launch(machine Instance, agent Agent) : void in class org.eclipse.che.plugin.machine.ssh.SshMachineImplTerminalLauncher | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type wsAgentLauncher : WsAgentLauncher to agentSorter : AgentSorter in method public WorkspaceRuntimes(eventService EventService, environmentEngine CheEnvironmentEngine, agentSorter AgentSorter, launcherFactory AgentLauncherFactory, agentRegistry AgentRegistry) in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Change Parameter Type machine : Machine to machine : Instance in method protected createPingRequest(machine Instance) : HttpJsonRequest in class org.eclipse.che.api.workspace.server.launcher.WsAgentLauncherImpl | From | To | |
| Rename Class | 1 | ||
| Rename Class org.eclipse.che.plugin.docker.machine.ext.provider.ExtServerVolumeProvider renamed to org.eclipse.che.plugin.docker.machine.ext.provider.WsAgentVolumeProvider | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.eclipse.che.api.agent.server.wsagent.WsAgentLauncher moved and renamed to org.eclipse.che.api.agent.server.impl.AgentSorter | From | To | |
| Move Class | 2 | ||
| Move Class org.eclipse.che.api.agent.server.wsagent.WsAgentLauncherImplTest moved to org.eclipse.che.api.workspace.server.launcher.WsAgentLauncherImplTest | From | To | |
| Move Class org.eclipse.che.api.agent.server.wsagent.WsAgentLauncherImpl moved to org.eclipse.che.api.workspace.server.launcher.WsAgentLauncherImpl | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.eclipse.che.api.agent.server.launcher.AbstractAgentLauncher from classes [org.eclipse.che.plugin.machine.ssh.SshMachineImplTerminalLauncher] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute wsAgentLauncher : WsAgentLauncher to agentSorter : AgentSorter in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Attribute extServerArchivePath : String to wsAgentArchivePath : String in class org.eclipse.che.plugin.docker.machine.ext.provider.WsAgentVolumeProvider | From | To | |
| Rename Attribute wsAgentStartCommandLine : String to wsAgentRunCommand : String in class org.eclipse.che.api.workspace.server.launcher.WsAgentLauncherImpl | From | To | |
| Change Package | 1 | ||
| Change Package org.eclipse.che.api.agent.server.wsagent to org.eclipse.che.api.workspace.server.launcher | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type wsAgentLauncher : WsAgentLauncher to agentSorter : AgentSorter in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Change Attribute Type machine : MachineImpl to machine : Instance in class org.eclipse.che.api.workspace.server.launcher.WsAgentLauncherImplTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter wsAgentStartCommandLine : String to wsAgentRunCommand : String in method public WsAgentLauncherImpl(machineProcessManagerProvider Provider<MachineProcessManager>, httpJsonRequestFactory HttpJsonRequestFactory, wsAgentRunCommand String, wsAgentMaxStartTimeMs long, wsAgentPingDelayMs long, wsAgentPingConnectionTimeoutMs int, pingTimedOutErrorMessage String) in class org.eclipse.che.api.workspace.server.launcher.WsAgentLauncherImpl | From | To | |
| Rename Parameter wsAgentLauncher : WsAgentLauncher to agentSorter : AgentSorter in method public WorkspaceRuntimes(eventService EventService, environmentEngine CheEnvironmentEngine, agentSorter AgentSorter, launcherFactory AgentLauncherFactory, agentRegistry AgentRegistry) in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To |