che b1cc0552361f9879321218767c53d8e963e593ab

b1cc0552361f9879321218767c53d8e963e593ab

Files Diff

Added: 35
Removed: 27
Renamed: 0
Modified: 42

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	18
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public NativeGit(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.NativeGit	From	To
Change Parameter Type registry : GitSshKeyUploaderRegistry to registry : SshKeyUploaderRegistry in method public GitHubAuthenticatorImpl(registry SshKeyUploaderRegistry, sshServiceClient SshServiceClient, view GitHubAuthenticatorView, dialogFactory DialogFactory, locale GitHubLocalizationConstant, baseUrl String, notificationManager NotificationManager, appContext AppContext) in class org.eclipse.che.plugin.github.ide.authenticator.GitHubAuthenticatorImpl	From	To
Change Parameter Type constant : SshLocalizationConstant to constant : SshKeyLocalizationConstant in method public SshKeyManagerPresenter(view SshKeyManagerView, service SshServiceClient, appContext AppContext, constant SshKeyLocalizationConstant, uploadSshKeyPresenter UploadSshKeyPresenter, notificationManager NotificationManager, dialogFactory DialogFactory, registry SshKeyUploaderRegistry) in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenter	From	To
Change Parameter Type constant : SshLocalizationConstant to constant : SshKeyLocalizationConstant in method public UploadSshKeyPresenter(view UploadSshKeyView, constant SshKeyLocalizationConstant, restContext String, notificationManager NotificationManager) in class org.eclipse.che.plugin.ssh.key.client.upload.UploadSshKeyPresenter	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public PushCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.PushCommand	From	To
Change Parameter Type registry : GitSshKeyUploaderRegistry to registry : SshKeyUploaderRegistry in method public GitHubExtension(registry SshKeyUploaderRegistry, gitHubSshKeyProvider GitHubSshKeyUploader) in class org.eclipse.che.plugin.github.ide.GitHubExtension	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to gitSshScriptProvider : SshScriptProvider in method public NativeGitConnectionFactory(credentialsLoader CredentialsLoader, gitSshScriptProvider SshScriptProvider, userResolver GitUserResolver) in class org.eclipse.che.git.impl.nativegit.NativeGitConnectionFactory	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public RemoteOperationCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.RemoteOperationCommand	From	To
Change Parameter Type locale : SshLocalizationConstant to locale : SshKeyLocalizationConstant in method public UploadSshKeyViewImpl(locale SshKeyLocalizationConstant) in class org.eclipse.che.plugin.ssh.key.client.upload.UploadSshKeyViewImpl	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public FetchCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.FetchCommand	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public NativeGitConnection(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, userResolver GitUserResolver) in class org.eclipse.che.git.impl.nativegit.NativeGitConnection	From	To
Change Parameter Type registry : GitSshKeyUploaderRegistry to registry : SshKeyUploaderRegistry in method public SshKeyManagerPresenter(view SshKeyManagerView, service SshServiceClient, appContext AppContext, constant SshKeyLocalizationConstant, uploadSshKeyPresenter UploadSshKeyPresenter, notificationManager NotificationManager, dialogFactory DialogFactory, registry SshKeyUploaderRegistry) in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenter	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public BranchDeleteCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.BranchDeleteCommand	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public CloneCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.CloneCommand	From	To
Change Parameter Type locale : SshLocalizationConstant to locale : SshKeyLocalizationConstant in method protected SshKeyManagerViewImpl(resources SshResources, locale SshKeyLocalizationConstant, res CellTableResources) in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerViewImpl	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public LsRemoteCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.LsRemoteCommand	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public BranchRenameCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.BranchRenameCommand	From	To
Change Parameter Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public PullCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.PullCommand	From	To
Move And Rename Class	8
Move And Rename Class org.eclipse.che.git.impl.nativegit.ssh.UnixGitSshScript moved and renamed to org.eclipse.che.plugin.ssh.key.script.UnixSshScript	From	To
Move And Rename Class org.eclipse.che.git.impl.nativegit.ssh.GitSshScriptProvider moved and renamed to org.eclipse.che.plugin.ssh.key.script.SshScriptProvider	From	To
Move And Rename Class org.eclipse.che.ide.ext.git.ssh.client.GitSshKeyUploaderRegistry moved and renamed to org.eclipse.che.plugin.ssh.key.client.SshKeyUploaderRegistry	From	To
Move And Rename Class org.eclipse.che.git.impl.nativegit.ssh.GitSshScript moved and renamed to org.eclipse.che.plugin.ssh.key.script.SshScript	From	To
Move And Rename Class org.eclipse.che.ide.ext.git.ssh.client.SshLocalizationConstant moved and renamed to org.eclipse.che.plugin.ssh.key.client.SshKeyLocalizationConstant	From	To
Move And Rename Class org.eclipse.che.ide.ext.git.ssh.client.inject.SshGinModule moved and renamed to org.eclipse.che.plugin.ssh.key.client.inject.SshKeyGinModule	From	To
Move And Rename Class org.eclipse.che.ide.ext.git.ssh.client.GitSshExtension moved and renamed to org.eclipse.che.plugin.ssh.key.client.SshKeyExtension	From	To
Move And Rename Class org.eclipse.che.git.impl.nativegit.ssh.WindowsGitSshScript moved and renamed to org.eclipse.che.plugin.ssh.key.script.WindowsSshScript	From	To
Move Class	13
Move Class org.eclipse.che.ide.ext.git.ssh.client.manage.SshKeyManagerViewImpl moved to org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerViewImpl	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.upload.UploadSshKeyViewImpl moved to org.eclipse.che.plugin.ssh.key.client.upload.UploadSshKeyViewImpl	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.SshResources moved to org.eclipse.che.plugin.ssh.key.client.SshResources	From	To
Move Class org.eclipse.che.git.impl.nativegit.ssh.SshKeyProviderImpl moved to org.eclipse.che.plugin.ssh.key.script.SshKeyProviderImpl	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.SshKeyUploader moved to org.eclipse.che.plugin.ssh.key.client.SshKeyUploader	From	To
Move Class org.eclipse.che.git.impl.nativegit.ssh.SshKeyProvider moved to org.eclipse.che.plugin.ssh.key.script.SshKeyProvider	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.upload.UploadSshKeyView moved to org.eclipse.che.plugin.ssh.key.client.upload.UploadSshKeyView	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.manage.SshKeyManagerPresenter moved to org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenter	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.upload.UploadSshKeyPresenter moved to org.eclipse.che.plugin.ssh.key.client.upload.UploadSshKeyPresenter	From	To
Move Class org.eclipse.che.git.impl.nativegit.ssh.SshScriptProviderTest moved to org.eclipse.che.plugin.ssh.key.script.SshScriptProviderTest	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.manage.SshKeyManagerView moved to org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerView	From	To
Move Class org.eclipse.che.git.impl.nativegit.ssh.SshKeyUploader moved to org.eclipse.che.plugin.ssh.key.script.SshKeyUploader	From	To
Move Class org.eclipse.che.ide.ext.git.ssh.client.manage.SshKeyManagerPresenterTest moved to org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenterTest	From	To
Change Variable Type	1
Change Variable Type gitSshScript : GitSshScript to sshScript : SshScript in method public checkExistenceScriptFileTest() : void in class org.eclipse.che.plugin.ssh.key.script.SshScriptProviderTest	From	To
Extract Variable	2
Extract Variable parent : Path in method protected ensureExistingSvnConfigFile() : void from class org.eclipse.che.plugin.svn.server.SubversionConfigurationChecker	From	To
Extract Variable credentials : String[] in method private runCommand(env Map<String,String>, args List<String>, projectPath File, paths List<String>) : CommandLineResult from class org.eclipse.che.plugin.svn.server.SubversionApi	From	To
Extract Method	1
Extract Method private deleteSshScript(sshScript SshScript) : void extracted from protected start() : void in class org.eclipse.che.git.impl.nativegit.commands.RemoteOperationCommand	From	To
Rename Method	2
Rename Method public gitSshScript(url String) : GitSshScript renamed to public getSshScript(url String) : SshScript in class org.eclipse.che.plugin.ssh.key.script.SshScriptProvider	From	To
Rename Method private getFailedKey(host String) : void renamed to private removeFailedKey(host String) : void in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenter	From	To
Rename Variable	1
Rename Variable gitSshScript : GitSshScript to sshScript : SshScript in method public checkExistenceScriptFileTest() : void in class org.eclipse.che.plugin.ssh.key.script.SshScriptProviderTest	From	To
Change Return Type	1
Change Return Type GitSshScript to SshScript in method public getSshScript(url String) : SshScript in class org.eclipse.che.plugin.ssh.key.script.SshScriptProvider	From	To
Rename Attribute	3
Rename Attribute gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in class org.eclipse.che.git.impl.nativegit.NativeGit	From	To
Rename Attribute GIT_SSH_SERVICE : String to VCS_SSH_SERVICE : String in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenter	From	To
Rename Attribute gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in class org.eclipse.che.git.impl.nativegit.commands.RemoteOperationCommand	From	To
Change Package	2
Change Package org.eclipse.che.ide.ext.git.ssh to org.eclipse.che.plugin.ssh.key	From	To
Change Package org.eclipse.che.git.impl.nativegit.ssh to org.eclipse.che.plugin.ssh.key.script	From	To
Change Attribute Type	12
Change Attribute Type constant : SshLocalizationConstant to constant : SshKeyLocalizationConstant in class org.eclipse.che.plugin.ssh.key.client.upload.UploadSshKeyPresenter	From	To
Change Attribute Type registry : GitSshKeyUploaderRegistry to registry : SshKeyUploaderRegistry in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenter	From	To
Change Attribute Type constant : SshLocalizationConstant to constant : SshKeyLocalizationConstant in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenter	From	To
Change Attribute Type registry : GitSshKeyUploaderRegistry to registry : SshKeyUploaderRegistry in class org.eclipse.che.plugin.github.ide.authenticator.GitHubAuthenticatorImpl	From	To
Change Attribute Type constant : SshLocalizationConstant to constant : SshKeyLocalizationConstant in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerPresenterTest	From	To
Change Attribute Type registry : GitSshKeyUploaderRegistry to registry : SshKeyUploaderRegistry in class org.eclipse.che.plugin.github.ide.authenticator.GitHubAuthenticatorImplTest	From	To
Change Attribute Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in class org.eclipse.che.git.impl.nativegit.NativeGit	From	To
Change Attribute Type gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in class org.eclipse.che.git.impl.nativegit.commands.RemoteOperationCommand	From	To
Change Attribute Type locale : SshLocalizationConstant to locale : SshKeyLocalizationConstant in class org.eclipse.che.plugin.ssh.key.client.upload.UploadSshKeyViewImpl	From	To
Change Attribute Type scriptProvider : GitSshScriptProvider to scriptProvider : SshScriptProvider in class org.eclipse.che.plugin.ssh.key.script.SshScriptProviderTest	From	To
Change Attribute Type locale : SshLocalizationConstant to locale : SshKeyLocalizationConstant in class org.eclipse.che.plugin.ssh.key.client.manage.SshKeyManagerViewImpl	From	To
Change Attribute Type gitSshScriptProvider : GitSshScriptProvider to gitSshScriptProvider : SshScriptProvider in class org.eclipse.che.git.impl.nativegit.NativeGitConnectionFactory	From	To
Rename Parameter	10
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public BranchRenameCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.BranchRenameCommand	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public PullCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.PullCommand	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public RemoteOperationCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.RemoteOperationCommand	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public FetchCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.FetchCommand	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public NativeGit(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.NativeGit	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public NativeGitConnection(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, userResolver GitUserResolver) in class org.eclipse.che.git.impl.nativegit.NativeGitConnection	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public BranchDeleteCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.BranchDeleteCommand	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public CloneCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.CloneCommand	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public PushCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.PushCommand	From	To
Rename Parameter gitSshScriptProvider : GitSshScriptProvider to sshScriptProvider : SshScriptProvider in method public LsRemoteCommand(repository File, sshScriptProvider SshScriptProvider, credentialsLoader CredentialsLoader, gitAskPassScript GitAskPassScript) in class org.eclipse.che.git.impl.nativegit.commands.LsRemoteCommand	From	To

b1cc0552361f9879321218767c53d8e963e593ab

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: