ba398c9ade2a82251e9e8c9374f6f93443b08c96
Files Diff
- Added: 4
- Removed: 4
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type pvcStrategy : WorkspacePVCStrategy to pvcStrategy : WorkspaceVolumesStrategy in method public WorkspacePVCCleaner(pvcEnabled boolean, projectName String, pvcStrategy WorkspaceVolumesStrategy) in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.WorkspacePVCCleaner | From | To | |
| Change Parameter Type pvcStrategy : WorkspacePVCStrategy to volumesStrategy : WorkspaceVolumesStrategy in method public VolumesProvisioner(pvcEnable boolean, volumesStrategy WorkspaceVolumesStrategy) in class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisioner | From | To | |
| Change Parameter Type projectVolumeProvisioner : PersistentVolumeClaimProvisioner to volumesProvisioner : VolumesProvisioner in method public OpenShiftEnvironmentProvisioner(volumesProvisioner VolumesProvisioner, uniqueNamesProvisioner UniqueNamesProvisioner, tlsRouteProvisioner TlsRouteProvisioner, serversConverter ServersConverter, envVarsConverter EnvVarsConverter, restartPolicyRewriter RestartPolicyRewriter) in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftEnvironmentProvisioner | From | To | |
| Rename Variable | 4 | ||
| Rename Variable machine : String to machineName : String in method public prepare(osEnv OpenShiftEnvironment, workspaceId String) : void in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.CommonPVCStrategy | From | To | |
| Rename Variable machine : InternalMachineConfig to machine1 : InternalMachineConfig in method public setup() : void in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.CommonPVCStrategyTest | From | To | |
| Rename Variable machine : InternalMachineConfig to machine1 : InternalMachineConfig in method public setup() : void in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.UniqueWorkspacePVCStrategyTest | From | To | |
| Rename Variable pvcStrategies : MapBinder<String,WorkspacePVCStrategy> to volumesStrategies : MapBinder<String,WorkspaceVolumesStrategy> in method protected configure() : void in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftInfraModule | From | To | |
| Rename Class | 3 | ||
| Rename Class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.PersistentVolumeClaimProvisionerTest renamed to org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisionerTest | From | To | |
| Rename Class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.PersistentVolumeClaimProvisioner renamed to org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisioner | From | To | |
| Rename Class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.WorkspacePVCStrategy renamed to org.eclipse.che.workspace.infrastructure.openshift.project.pvc.WorkspaceVolumesStrategy | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute pvcProvisioner : PersistentVolumeClaimProvisioner to volumesProvisioner : VolumesProvisioner in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftEnvironmentProvisionerTest | From | To | |
| Rename Attribute persistentVolumeClaimProvisioner : PersistentVolumeClaimProvisioner to volumesProvisioner : VolumesProvisioner in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftEnvironmentProvisioner | From | To | |
| Rename Attribute pvcStrategy : WorkspacePVCStrategy to volumesStrategy : WorkspaceVolumesStrategy in class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisioner | From | To | |
| Rename Attribute pvcStrategy : WorkspacePVCStrategy to volumeStrategy : WorkspaceVolumesStrategy in class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisionerTest | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type pvcStrategies : MapBinder<String,WorkspacePVCStrategy> to volumesStrategies : MapBinder<String,WorkspaceVolumesStrategy> in method protected configure() : void in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftInfraModule | From | To | |
| Extract Method | 2 | ||
| Extract Method private addMachineVolumes(workspaceId String, claims Map<String,PersistentVolumeClaim>, podSpec PodSpec, container Container, machineConfig InternalMachineConfig) : void extracted from public prepare(osEnv OpenShiftEnvironment, workspaceId String) : void in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.UniqueWorkspacePVCStrategy | From | To | |
| Extract Method private addVolumeIfNeeded(podSpec PodSpec, pvcUniqueName String) : void extracted from public prepare(osEnv OpenShiftEnvironment, workspaceId String) : void in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.UniqueWorkspacePVCStrategy | From | To | |
| Inline Variable | 1 | ||
| Inline Variable claims : Map<String,PersistentVolumeClaim> in method public prepare(osEnv OpenShiftEnvironment, workspaceId String) : void from class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.CommonPVCStrategy | From | To | |
| Change Attribute Type | 7 | ||
| Change Attribute Type pvcStrategy : WorkspacePVCStrategy to pvcStrategy : WorkspaceVolumesStrategy in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.WorkspacePVCCleanerTest | From | To | |
| Change Attribute Type provisioner : PersistentVolumeClaimProvisioner to provisioner : VolumesProvisioner in class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisionerTest | From | To | |
| Change Attribute Type pvcStrategy : WorkspacePVCStrategy to volumesStrategy : WorkspaceVolumesStrategy in class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisioner | From | To | |
| Change Attribute Type persistentVolumeClaimProvisioner : PersistentVolumeClaimProvisioner to volumesProvisioner : VolumesProvisioner in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftEnvironmentProvisioner | From | To | |
| Change Attribute Type pvcStrategy : WorkspacePVCStrategy to volumeStrategy : WorkspaceVolumesStrategy in class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisionerTest | From | To | |
| Change Attribute Type pvcProvisioner : PersistentVolumeClaimProvisioner to volumesProvisioner : VolumesProvisioner in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftEnvironmentProvisionerTest | From | To | |
| Change Attribute Type strategy : WorkspacePVCStrategy to strategy : WorkspaceVolumesStrategy in class org.eclipse.che.workspace.infrastructure.openshift.project.pvc.WorkspacePVCCleaner | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter projectVolumeProvisioner : PersistentVolumeClaimProvisioner to volumesProvisioner : VolumesProvisioner in method public OpenShiftEnvironmentProvisioner(volumesProvisioner VolumesProvisioner, uniqueNamesProvisioner UniqueNamesProvisioner, tlsRouteProvisioner TlsRouteProvisioner, serversConverter ServersConverter, envVarsConverter EnvVarsConverter, restartPolicyRewriter RestartPolicyRewriter) in class org.eclipse.che.workspace.infrastructure.openshift.OpenShiftEnvironmentProvisioner | From | To | |
| Rename Parameter pvcStrategy : WorkspacePVCStrategy to volumesStrategy : WorkspaceVolumesStrategy in method public VolumesProvisioner(pvcEnable boolean, volumesStrategy WorkspaceVolumesStrategy) in class org.eclipse.che.workspace.infrastructure.openshift.provision.volume.VolumesProvisioner | From | To |