bf2f1bcd4c9d2fb660674ecbabd20c5addca250f
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 1 | ||
| Merge Attribute [snapshotDao : SnapshotDao, runtimes : WorkspaceRuntimes] to workspaceDao : WorkspaceDao in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Rename Method | 7 | ||
| Rename Method public performAsyncStartShouldUseProvidedEnvInsteadOfDefault() : void renamed to public usesProvidedEnvironmentInsteadOfDefault() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Rename Method public getWorkspaceByIdShouldReturnWorkspaceWithStatusEqualToItsRuntimeStatus() : void renamed to public getsWorkspaceByIdWithRuntime() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Rename Method private createRunningWorkspace() : WorkspaceImpl renamed to private createAndMockWorkspace() : WorkspaceImpl in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Rename Method public removeSnapshot(snapshot SnapshotImpl) : void renamed to public removeBinaries(snapshot SnapshotImpl) : boolean in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Method private performAsyncStart(machineConfig MachineConfig, workspaceId String) : void renamed to private startAsync(machineConfig MachineConfig, workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceManager | From | To | |
| Rename Method public finishSnapshotting(workspaceId String) : void renamed to public snapshot(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Method package performAsyncStart(workspace WorkspaceImpl, envName String, recover boolean) : void renamed to private startAsync(workspace WorkspaceImpl, envName String, recover boolean) : void in class org.eclipse.che.api.workspace.server.WorkspaceManager | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method package createSnapshotSync(namespace String, workspaceId String, envName String) : boolean from class org.eclipse.che.api.workspace.server.WorkspaceManager to private snapshotAndUpdateStatus(workspaceId String) : void from class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Move And Rename Method private removeSnapshotsBinaries(snapshots Collection<? extends SnapshotImpl>) : void from class org.eclipse.che.api.workspace.server.WorkspaceManager to public removeBinaries(snapshots Collection<? extends SnapshotImpl>) : void from class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Move Method | 1 | ||
| Move Method public removesOldSnapshotsWhenNewSnapshotsMetadataSuccessfullySaved() : void from class org.eclipse.che.api.workspace.server.WorkspaceManagerTest to public removesOldSnapshotsWhenNewSnapshotsMetadataSuccessfullySaved() : void from class org.eclipse.che.api.workspace.server.WorkspaceRuntimesTest | From | To | |
| Inline Method | 2 | ||
| Inline Method package publishWorkspaceEvent(type EventType, workspaceId String, error String) : void inlined to private doStart(environment EnvironmentImpl, workspaceId String, envName String, recover boolean) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Inline Method package publishWorkspaceEvent(type EventType, workspaceId String, error String) : void inlined to public stop(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to boolean in method public removeBinaries(snapshot SnapshotImpl) : boolean in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Change Return Type boolean to void in method private snapshotAndUpdateStatus(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private executor : ExecutorService from class org.eclipse.che.api.workspace.server.WorkspaceManager to private executor : ExecutorService from class org.eclipse.che.api.workspace.server.WorkspaceSharedPool | From | To | |
| Move Attribute private executor : ExecutorService from class org.eclipse.che.api.workspace.server.WorkspaceRuntimes to private executor : ExecutorService from class org.eclipse.che.api.workspace.server.WorkspaceSharedPool | From | To | |
| Extract Class | 2 | ||
| Extract Class org.eclipse.che.api.workspace.server.WorkspaceSharedPool from class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Class org.eclipse.che.api.workspace.server.WorkspaceSharedPool from class org.eclipse.che.api.workspace.server.WorkspaceManager | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable workspace2 : WorkspaceImpl to workspace : WorkspaceImpl in method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute eventService : EventService to eventsService : EventService in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Attribute environmentEngine : CheEnvironmentEngine to envEngine : CheEnvironmentEngine in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Attribute executor : ExecutorService to sharedPool : WorkspaceSharedPool in class org.eclipse.che.api.workspace.server.WorkspaceManager | From | To | |
| Rename Attribute stripedLocks : StripedLocks to locks : StripedLocks in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Attribute environmentEngine : CheEnvironmentEngine to envEngine : CheEnvironmentEngine in class org.eclipse.che.api.workspace.server.WorkspaceRuntimesTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type executor : ExecutorService to sharedPool : WorkspaceSharedPool in class org.eclipse.che.api.workspace.server.WorkspaceManager | From | To | |
| Extract Method | 18 | ||
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldBeAbleToStopMachine() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldNotCreateSnapshotIfWorkspaceIsTemporaryAndAutoCreateSnapshotDisactivated() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public workspaceUpdateShouldReturnWorkspaceWithStatusEqualToItsRuntimeStatus() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private removeWorkspaceQuietly(workspace Workspace) : void extracted from package performAsyncStart(workspace WorkspaceImpl, envName String, recover boolean) : void in class org.eclipse.che.api.workspace.server.WorkspaceManager | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldStopWorkspaceEventIfSnapshotCreationFailed() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public getWorkspaceByNameShouldReturnWorkspaceWithStatusEqualToItsRuntimeStatus() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldBeAbleToGetMachineInstanceIfWorkspaceIsStarting() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldNotCreateSnapshotIfWorkspaceIsTemporaryAndAutoCreateSnapshotActivated() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockWorkspace(cfg WorkspaceConfig, namespace String) : WorkspaceImpl extracted from public performAsyncStartShouldUseProvidedEnvInsteadOfDefault() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldBeAbleToGetWorkspacesByNamespace() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldBeAbleToGetMachineInstanceIfWorkspaceIsRunning() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldCreateWorkspaceSnapshotUsingDefaultValueForAutoRestore() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldBeAbleToCreateSnapshot() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockWorkspace(cfg WorkspaceConfig, namespace String) : WorkspaceImpl extracted from public shouldBeAbleToStopWorkspace() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldBeAbleToStopWorkspace() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public shouldRemoveTemporaryWorkspaceAfterStop() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockWorkspace(cfg WorkspaceConfig, namespace String) : WorkspaceImpl extracted from private createRunningWorkspace() : WorkspaceImpl in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Extract Method private createAndMockDescriptor(workspace WorkspaceImpl, status WorkspaceStatus) : RuntimeDescriptor extracted from public getWorkspaceByIdShouldReturnWorkspaceWithStatusEqualToItsRuntimeStatus() : void in class org.eclipse.che.api.workspace.server.WorkspaceManagerTest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter environmentEngine : CheEnvironmentEngine to envEngine : CheEnvironmentEngine in method public WorkspaceRuntimes(eventsService EventService, envEngine CheEnvironmentEngine, agentSorter AgentSorter, launcherFactory AgentLauncherFactory, agentRegistry AgentRegistry, snapshotDao SnapshotDao, sharedPool WorkspaceSharedPool) in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Parameter eventService : EventService to eventsService : EventService in method public WorkspaceRuntimes(eventsService EventService, envEngine CheEnvironmentEngine, agentSorter AgentSorter, launcherFactory AgentLauncherFactory, agentRegistry AgentRegistry, snapshotDao SnapshotDao, sharedPool WorkspaceSharedPool) in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To |