d8a0ac7f7f9fedc157905c0ba07cc312f54681ef
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private getPeekConfig(wsId String) : MachineConfigImpl renamed to private queuePeekOrFail(workspaceId String) : MachineConfigImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Method private rmFirst(elements List<? extends T>, predicate Predicate<T>) : T renamed to private removeFirstMatching(elements List<? extends T>, predicate Predicate<T>) : T in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Variable | 5 | ||
| Rename Variable ex : RuntimeException|MachineException|NotFoundException|SnapshotException|ConflictException to x : ConflictException in method private startMachine(config MachineConfigImpl, workspaceId String, envName String, recover boolean) : MachineImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Variable runtime : WorkspaceRuntimeImpl to machineOpt : Optional<MachineImpl> in method private startMachine(config MachineConfigImpl, workspaceId String, envName String, recover boolean) : MachineImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Variable machineConfigs : List<MachineConfigImpl> to startConfigs : List<MachineConfigImpl> in method public start(workspace WorkspaceImpl, envName String, recover boolean) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Variable activeEnv : EnvironmentImpl to environmentCopy : EnvironmentImpl in method public start(workspace WorkspaceImpl, envName String, recover boolean) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Variable descriptor : RuntimeDescriptor to existingDescriptor : RuntimeDescriptor in method public start(workspace WorkspaceImpl, envName String, recover boolean) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to MachineImpl in method private startMachine(config MachineConfigImpl, workspaceId String, envName String, recover boolean) : MachineImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute isStopping : boolean to status : WorkspaceStatus in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes.RuntimeDescriptor | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type ex : RuntimeException|MachineException|NotFoundException|SnapshotException|ConflictException to x : ConflictException in method private startMachine(config MachineConfigImpl, workspaceId String, envName String, recover boolean) : MachineImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Change Variable Type runtime : WorkspaceRuntimeImpl to machineOpt : Optional<MachineImpl> in method private startMachine(config MachineConfigImpl, workspaceId String, envName String, recover boolean) : MachineImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Variable | 2 | ||
| Extract Variable descriptor : RuntimeDescriptor in method public start(workspace WorkspaceImpl, envName String, recover boolean) : RuntimeDescriptor from class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Variable environmentOpt : Optional<EnvironmentImpl> in method public start(workspace WorkspaceImpl, envName String, recover boolean) : RuntimeDescriptor from class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type isStopping : boolean to status : WorkspaceStatus in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes.RuntimeDescriptor | From | To | |
| Extract Method | 16 | ||
| Extract Method private releaseWriteLock(workspaceId String) : void extracted from public start(workspace WorkspaceImpl, envName String, recover boolean) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private releaseWriteLock(workspaceId String) : void extracted from private startQueue(wsId String, envName String, recover boolean) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireWriteLock(workspaceId String) : void extracted from package cleanupStartResources(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireReadLock(workspaceId String) : void extracted from private getPeekConfig(wsId String) : MachineConfigImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireReadLock(workspaceId String) : void extracted from public hasRuntime(workspaceId String) : boolean in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireWriteLock(workspaceId String) : void extracted from public start(workspace WorkspaceImpl, envName String, recover boolean) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private releaseReadLock(workspaceId String) : void extracted from public get(workspaceId String) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private releaseWriteLock(workspaceId String) : void extracted from package cleanupStartResources(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private releaseWriteLock(workspaceId String) : void extracted from package removeRuntime(wsId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private releaseReadLock(workspaceId String) : void extracted from public hasRuntime(workspaceId String) : boolean in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireWriteLock(workspaceId String) : void extracted from private startQueue(wsId String, envName String, recover boolean) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private releaseReadLock(workspaceId String) : void extracted from private getPeekConfig(wsId String) : MachineConfigImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireWriteLock(workspaceId String) : void extracted from public stop(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private releaseWriteLock(workspaceId String) : void extracted from public stop(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireReadLock(workspaceId String) : void extracted from public get(workspaceId String) : RuntimeDescriptor in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract Method private acquireWriteLock(workspaceId String) : void extracted from package removeRuntime(wsId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method private setRuntimeStatus(status WorkspaceStatus) : void extracted from private startQueue(wsId String, envName String, recover boolean) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes & moved to class org.eclipse.che.api.workspace.server.WorkspaceRuntimes.RuntimeDescriptor | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter wsId : String to workspaceId : String in method private destroyRuntime(workspaceId String, workspace WorkspaceRuntimeImpl) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Parameter wsId : String to workspaceId : String in method private queuePeekOrFail(workspaceId String) : MachineConfigImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Parameter wsId : String to workspaceId : String in method private startMachine(config MachineConfigImpl, workspaceId String, envName String, recover boolean) : MachineImpl in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Parameter wsId : String to workspaceId : String in method private startQueue(workspaceId String, envName String, recover boolean) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To | |
| Rename Parameter wsId : String to workspaceId : String in method package removeRuntime(workspaceId String) : void in class org.eclipse.che.api.workspace.server.WorkspaceRuntimes | From | To |