fa7eb17cdb6296f54d8bcc573d541e8f433e6874
Files Diff
- Added: 42
- Removed: 2
- Renamed: 0
- Modified: 22
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public shouldThrowForbiddenExceptionWhenUserDoesNotHaveReadAccessToRecipe() : void from class org.eclipse.che.api.machine.server.recipe.RecipeServiceTest to public foreignStackShouldNotBeReturnedIfUserHasNotPermission() : void from class org.eclipse.che.api.workspace.server.stack.StackServiceTest | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type recipe : ManagedRecipe to permissible : Permissible in method public hasAccess(permissible Permissible, userId String, permission String) : boolean in class org.eclipse.che.api.machine.server.recipe.PermissionsCheckerImpl | From | To | |
| Change Parameter Type recipe : ManagedRecipe to permissible : Permissible in method public hasAccess(permissible Permissible, userId String, permission String) : boolean in class org.eclipse.che.api.machine.server.recipe.PermissionsChecker | From | To | |
| Rename Class | 2 | ||
| Rename Class org.eclipse.che.api.machine.server.recipe.adapters.PermissionsSerializer renamed to org.eclipse.che.api.machine.server.recipe.adapters.PermissionsAdapter | From | To | |
| Rename Class org.eclipse.che.api.machine.server.recipe.adapters.GroupSerializer renamed to org.eclipse.che.api.machine.server.recipe.adapters.GroupAdapter | From | To | |
| Extract Variable | 3 | ||
| Extract Variable userId : String in method public createRecipe(newRecipe NewRecipe) : Response from class org.eclipse.che.api.machine.server.recipe.RecipeService | From | To | |
| Extract Variable userId : String in method public updateRecipe(update RecipeUpdate) : RecipeDescriptor from class org.eclipse.che.api.machine.server.recipe.RecipeService | From | To | |
| Extract Variable permissions : PermissionsDescriptor in method public shouldNotBeAbleToCreateNewRecipeWithPublicSearchPermissionForUser() : void from class org.eclipse.che.api.machine.server.recipe.RecipeServiceTest | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.eclipse.che.api.machine.shared.Permissible from classes [org.eclipse.che.api.machine.shared.ManagedRecipe] | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter recipe : ManagedRecipe to permissible : Permissible in method public hasAccess(permissible Permissible, userId String, permission String) : boolean in class org.eclipse.che.api.machine.server.recipe.PermissionsCheckerImpl | From | To | |
| Rename Parameter recipe : ManagedRecipe to permissible : Permissible in method public hasAccess(permissible Permissible, userId String, permission String) : boolean in class org.eclipse.che.api.machine.server.recipe.PermissionsChecker | From | To |