e018b2d6622efa4f1897244856974c45efeda99c
Files Diff
- Added: 10
- Removed: 2
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 1 | ||
| Pull Up Method protected addImportRule(rule AbstractImportRule) : void from class com.puppycrawl.tools.checkstyle.checks.imports.ImportControl to protected addImportRule(rule AbstractImportRule) : void from class com.puppycrawl.tools.checkstyle.checks.imports.AbstractImportControl | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type importControl : ImportControl to importControl : AbstractImportControl in method public addChild(importControl AbstractImportControl) : void in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Change Parameter Type parent : ImportControl to parent : PkgImportControl in method package PkgImportControl(parent PkgImportControl, subPackageName String, regex boolean, strategyOnMismatch MismatchStrategy) in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private rules : Deque<AbstractImportRule> from class com.puppycrawl.tools.checkstyle.checks.imports.ImportControl to private rules : Deque<AbstractImportRule> from class com.puppycrawl.tools.checkstyle.checks.imports.AbstractImportControl | From | To | |
| Pull Up Attribute private strategyOnMismatch : MismatchStrategy from class com.puppycrawl.tools.checkstyle.checks.imports.ImportControl to private strategyOnMismatch : MismatchStrategy from class com.puppycrawl.tools.checkstyle.checks.imports.AbstractImportControl | From | To | |
| Change Return Type | 4 | ||
| Change Return Type ImportControl to PkgImportControl in method private getRoot() : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoader | From | To | |
| Change Return Type ImportControl to PkgImportControl in method public load(uri URI) : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoader | From | To | |
| Change Return Type ImportControl to PkgImportControl in method private load(source InputSource, uri URI) : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoader | From | To | |
| Change Return Type ImportControl to AbstractImportControl in method public locateFinest(forPkg String, forFileName String) : AbstractImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private NAME_ATTRIBUTE_NAME : String in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoader | From | To | |
| Rename Class | 2 | ||
| Rename Class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlTest renamed to com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControlTest | From | To | |
| Rename Class com.puppycrawl.tools.checkstyle.checks.imports.ImportControl renamed to com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass com.puppycrawl.tools.checkstyle.checks.imports.AbstractImportControl from classes [com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute fullPackage : String to fullPackageName : String in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type child : ImportControl to child : AbstractImportControl in method public locateFinest(forPkg String, forFileName String) : AbstractImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Change Variable Type finestMatch : ImportControl to finestMatch : AbstractImportControl in method public locateFinest(forPkg String, forFileName String) : AbstractImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Change Variable Type root : ImportControl to root : AbstractImportControl in method public testExtraElementInConfig() : void in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoaderTest | From | To | |
| Change Variable Type match : ImportControl to match : AbstractImportControl in method public locateFinest(forPkg String, forFileName String) : AbstractImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Change Variable Type parentImportControl : ImportControl to parentImportControl : PkgImportControl in method public startElement(namespaceUri String, localName String, qName String, attributes Attributes) : void in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoader | From | To | |
| Change Variable Type root : ImportControl to root : AbstractImportControl in method public testLoad() : void in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoaderTest | From | To | |
| Extract Method | 1 | ||
| Extract Method private createImportRule(qName String, attributes Attributes) : AbstractImportRule extracted from public startElement(namespaceUri String, localName String, qName String, attributes Attributes) : void in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoader | From | To | |
| Change Attribute Type | 10 | ||
| Change Attribute Type icBootRegexpParen : ImportControl to icBootRegexpParen : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControlTest | From | To | |
| Change Attribute Type icRootRegexpParent : ImportControl to icRootRegexpParent : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControlTest | From | To | |
| Change Attribute Type icCommonRegexpChild : ImportControl to icCommonRegexpChild : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControlTest | From | To | |
| Change Attribute Type icRootRegexpChild : ImportControl to icRootRegexpChild : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControlTest | From | To | |
| Change Attribute Type root : ImportControl to root : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlCheck | From | To | |
| Change Attribute Type icRoot : ImportControl to icRoot : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControlTest | From | To | |
| Change Attribute Type currentImportControl : ImportControl to currentImportControl : AbstractImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlCheck | From | To | |
| Change Attribute Type icCommon : ImportControl to icCommon : PkgImportControl in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControlTest | From | To | |
| Change Attribute Type children : List<ImportControl> to children : List<AbstractImportControl> in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Change Attribute Type stack : Deque<ImportControl> to stack : Deque<AbstractImportControl> in class com.puppycrawl.tools.checkstyle.checks.imports.ImportControlLoader | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter pkgName : String to packageName : String in method package PkgImportControl(packageName String, regex boolean, strategyOnMismatch MismatchStrategy) in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To | |
| Rename Parameter subPkg : String to subPackageName : String in method package PkgImportControl(parent PkgImportControl, subPackageName String, regex boolean, strategyOnMismatch MismatchStrategy) in class com.puppycrawl.tools.checkstyle.checks.imports.PkgImportControl | From | To |