fc25f2a95fdee6da60c71ef5794c4c0698011567
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Push Down Method | 12 | ||
Push Down Method public getDependenciesOf(roots List<INPUT>, sorted boolean) : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to public getDependenciesOf(roots List<INPUT>, sorted boolean) : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method private topologicalStableSort(items List<T>, deps Multimap<T,T>) : List<T> from class com.google.javascript.jscomp.deps.SortedDependencies to private topologicalStableSort(items List<T>, deps Multimap<T,T>) : List<T> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method private cycleToString(cycle List<INPUT>) : String from class com.google.javascript.jscomp.deps.SortedDependencies to private cycleToString(cycle List<INPUT>) : String from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method public maybeGetInputProviding(symbol String) : INPUT from class com.google.javascript.jscomp.deps.SortedDependencies to public maybeGetInputProviding(symbol String) : INPUT from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method public getInputsWithoutProvides() : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to public getInputsWithoutProvides() : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method private findCycle(current INPUT, subGraph Set<INPUT>, deps Multimap<INPUT,INPUT>, covered Set<INPUT>) : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to private findCycle(current INPUT, subGraph Set<INPUT>, deps Multimap<INPUT,INPUT>, covered Set<INPUT>) : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method public SortedDependencies(inputs List<INPUT>) from class com.google.javascript.jscomp.deps.SortedDependencies to public ClosureSortedDependencies(inputs List<INPUT>) from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method private findCycle(subGraph List<INPUT>, deps Multimap<INPUT,INPUT>) : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to private findCycle(subGraph List<INPUT>, deps Multimap<INPUT,INPUT>) : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method private findRequireInSubGraphOrFail(input INPUT, subGraph Set<INPUT>) : INPUT from class com.google.javascript.jscomp.deps.SortedDependencies to private findRequireInSubGraphOrFail(input INPUT, subGraph Set<INPUT>) : INPUT from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method public getInputProviding(symbol String) : INPUT from class com.google.javascript.jscomp.deps.SortedDependencies to public getInputProviding(symbol String) : INPUT from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method public getSortedDependenciesOf(roots List<INPUT>) : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to public getSortedDependenciesOf(roots List<INPUT>) : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Method public getSortedList() : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to public getSortedList() : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Extract Subclass | 1 | ||
Extract Subclass com.google.javascript.jscomp.deps.ClosureSortedDependencies from class com.google.javascript.jscomp.deps.SortedDependencies | From | To | |
Push Down Attribute | 4 | ||
Push Down Attribute private provideMap : Map<String,INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to private provideMap : Map<String,INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Attribute private noProvides : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to private noProvides : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Attribute private sortedList : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to private sortedList : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Push Down Attribute private inputs : List<INPUT> from class com.google.javascript.jscomp.deps.SortedDependencies to private inputs : List<INPUT> from class com.google.javascript.jscomp.deps.ClosureSortedDependencies | From | To | |
Extract Method | 10 | ||
Extract Method private testManageDependencies1Impl(es6ModuleOrder boolean) : void extracted from public testManageDependencies1() : void in class com.google.javascript.jscomp.JSModuleGraphTest | From | To | |
Extract Method private assertOrderOrException(shuffle ImmutableList<SimpleDependencyInfo>, expected ImmutableList<SimpleDependencyInfo>, failMessage String) : void extracted from public testSort9() : void in class com.google.javascript.jscomp.deps.SortedDependenciesTest | From | To | |
Extract Method private assertOrderOrException(shuffle ImmutableList<SimpleDependencyInfo>, expected ImmutableList<SimpleDependencyInfo>, failMessage String) : void extracted from public testSort3() : void in class com.google.javascript.jscomp.deps.SortedDependenciesTest | From | To | |
Extract Method private assertOrderOrException(shuffle ImmutableList<SimpleDependencyInfo>, expected ImmutableList<SimpleDependencyInfo>, failMessage String) : void extracted from public testSort8() : void in class com.google.javascript.jscomp.deps.SortedDependenciesTest | From | To | |
Extract Method private testManageDependencies5Impl(es6ModuleOrder boolean) : void extracted from public testManageDependencies5() : void in class com.google.javascript.jscomp.JSModuleGraphTest | From | To | |
Extract Method private testManageDependencies4Impl(es6ModuleOrder boolean) : void extracted from public testManageDependencies4() : void in class com.google.javascript.jscomp.JSModuleGraphTest | From | To | |
Extract Method private assertOrderOrException(shuffle ImmutableList<SimpleDependencyInfo>, expected ImmutableList<SimpleDependencyInfo>, failMessage String) : void extracted from public testSort7() : void in class com.google.javascript.jscomp.deps.SortedDependenciesTest | From | To | |
Extract Method private testManageDependencies3Impl(es6ModuleOrder boolean) : void extracted from public testManageDependencies3() : void in class com.google.javascript.jscomp.JSModuleGraphTest | From | To | |
Extract Method private testManageDependencies2Impl(es6ModuleOrder boolean) : void extracted from public testManageDependencies2() : void in class com.google.javascript.jscomp.JSModuleGraphTest | From | To | |
Extract Method private assertOrderOrException(shuffle ImmutableList<SimpleDependencyInfo>, expected ImmutableList<SimpleDependencyInfo>, failMessage String) : void extracted from public testSort6() : void in class com.google.javascript.jscomp.deps.SortedDependenciesTest | From | To |