94b872637921631cd155f9840b71878cbfac0a8a
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private resetView() : void renamed to private vaultChanged(newVault Vault) : void in class org.cryptomator.ui.controllers.UnlockController | From | To | |
| Rename Method private showVault(vault Vault) : void renamed to private selectedVaultDidChange(property ObservableValue<? extends Vault>, oldValue Vault, newValue Vault) : void in class org.cryptomator.ui.controllers.MainController | From | To | |
| Rename Method private showWelcomeView() : void renamed to private activeControllerDidChange(property ObservableValue<? extends AbstractFXMLViewController>, oldValue AbstractFXMLViewController, newValue AbstractFXMLViewController) : void in class org.cryptomator.ui.controllers.MainController | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type exceptionCallback : CallbackWhenTaskFailed to exceptionCallback : Consumer<Exception> in method public runOnMainThreadWhenFinished(executor ExecutorService, task Future<T>, successCallback Consumer<T>, exceptionCallback Consumer<Exception>) : void in class org.cryptomator.ui.util.FXThreads | From | To | |
| Change Parameter Type successCallback : CallbackWhenTaskFinished<T> to successCallback : Consumer<T> in method public runOnMainThreadWhenFinished(executor ExecutorService, task Future<T>, successCallback Consumer<T>) : void in class org.cryptomator.ui.util.FXThreads | From | To | |
| Change Parameter Type successCallback : CallbackWhenTaskFinished<T> to successCallback : Consumer<T> in method public runOnMainThreadWhenFinished(executor ExecutorService, task Future<T>, successCallback Consumer<T>, exceptionCallback Consumer<Exception>) : void in class org.cryptomator.ui.util.FXThreads | From | To | |
| Inline Method | 1 | ||
| Inline Method private setControlsDisabled(disable boolean) : void inlined to private didClickUnlockButton(event ActionEvent) : void in class org.cryptomator.ui.controllers.UnlockController | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ObjectProperty<Boolean> to BooleanProperty in method public unlockedProperty() : BooleanProperty in class org.cryptomator.ui.model.Vault | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private checkForUpdatesCheckbox : CheckBox from class org.cryptomator.ui.controllers.WelcomeController to private checkForUpdatesCheckbox : CheckBox from class org.cryptomator.ui.controllers.SettingsController | From | To | |
| Move Attribute private settings : Settings from class org.cryptomator.ui.controllers.MainController to private settings : Settings from class org.cryptomator.ui.controllers.SettingsController | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute items : ObservableList<Vault> to vaults : ObservableList<Vault> in method public initialize() : void in class org.cryptomator.ui.controllers.MainController | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute unlockedController : Provider<UnlockedController> to unlockedControllerProvider : Provider<UnlockedController> in class org.cryptomator.ui.controllers.MainController | From | To | |
| Change Attribute Type | 8 | ||
| Change Attribute Type DUMMY_EXCEPTION_CALLBACK : CallbackWhenTaskFailed to DUMMY_EXCEPTION_CALLBACK : Consumer<Exception> in class org.cryptomator.ui.util.FXThreads | From | To | |
| Change Attribute Type vault : Vault to vault : ObjectProperty<Vault> in class org.cryptomator.ui.controllers.ChangePasswordController | From | To | |
| Change Attribute Type fxmlRoot : Parent to fxmlRoot : AtomicReference<Parent> in class org.cryptomator.ui.controllers.AbstractFXMLViewController | From | To | |
| Change Attribute Type vault : Vault to vault : ObjectProperty<Vault> in class org.cryptomator.ui.controllers.MacWarningsController | From | To | |
| Change Attribute Type vault : Vault to vault : ObjectProperty<Vault> in class org.cryptomator.ui.controllers.UnlockController | From | To | |
| Change Attribute Type vault : Vault to vault : ObjectProperty<Vault> in class org.cryptomator.ui.controllers.InitializeController | From | To | |
| Change Attribute Type vault : Vault to vault : ObjectProperty<Vault> in class org.cryptomator.ui.controllers.UnlockedController | From | To | |
| Change Attribute Type unlocked : ObjectProperty<Boolean> to unlocked : BooleanProperty in class org.cryptomator.ui.model.Vault | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter unlockedController : Provider<UnlockedController> to unlockedControllerProvider : Provider<UnlockedController> in method public MainController(settings Settings, vaultFactoy VaultFactory, welcomeController Lazy<WelcomeController>, initializeController Lazy<InitializeController>, unlockController Lazy<UnlockController>, unlockedControllerProvider Provider<UnlockedController>, changePasswordController Lazy<ChangePasswordController>, settingsController Lazy<SettingsController>) in class org.cryptomator.ui.controllers.MainController | From | To | |
| Rename Parameter vault : Vault to newValue : Vault in method private selectedVaultDidChange(property ObservableValue<? extends Vault>, oldValue Vault, newValue Vault) : void in class org.cryptomator.ui.controllers.MainController | From | To |