cryptomator cdf9c28a3874981c66e499fcd9532e12f2cbe9b0

cdf9c28a3874981c66e499fcd9532e12f2cbe9b0

Files Diff

Added: 7
Removed: 7
Renamed: 0
Modified: 19

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	1
Move And Inline Method public getPhysicalPath(resource DavResource) : Path moved from class org.cryptomator.webdav.jackrabbit.ResourcePathUtils to class org.cryptomator.webdav.jackrabbit.AbstractEncryptedNode & inlined to public setProperty(property DavProperty<?>) : void	From	To
Change Parameter Type	22
Change Parameter Type factory : DavResourceFactory to factory : CryptoResourceFactory in method public EncryptedFile(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor, cryptoWarningHandler CryptoWarningHandler) in class org.cryptomator.webdav.jackrabbit.EncryptedFile	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method private createDirectory(locator CryptoLocator, session DavSession) : EncryptedDir in class org.cryptomator.webdav.jackrabbit.CryptoResourceFactory	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method protected AbstractEncryptedNode(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor) in class org.cryptomator.webdav.jackrabbit.AbstractEncryptedNode	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method public EncryptedFilePart(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, request DavServletRequest, lockManager LockManager, cryptor Cryptor, cryptoWarningHandler CryptoWarningHandler, backgroundTaskExecutor ExecutorService) in class org.cryptomator.webdav.jackrabbit.EncryptedFilePart	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method public NonExistingNode(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor) in class org.cryptomator.webdav.jackrabbit.NonExistingNode	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method public MacAuthenticationJob(locator CryptoLocator) in class org.cryptomator.webdav.jackrabbit.EncryptedFilePart.MacAuthenticationJob	From	To
Change Parameter Type factory : DavResourceFactory to factory : CryptoResourceFactory in method public EncryptedDir(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor) in class org.cryptomator.webdav.jackrabbit.EncryptedDir	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method private createFile(locator CryptoLocator, session DavSession) : EncryptedFile in class org.cryptomator.webdav.jackrabbit.CryptoResourceFactory	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method public EncryptedFile(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor, cryptoWarningHandler CryptoWarningHandler) in class org.cryptomator.webdav.jackrabbit.EncryptedFile	From	To
Change Parameter Type ioSupport : CryptorIOSupport to ioSupport : CryptorMetadataSupport in method public decryptFilename(ciphertextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method public getPhysicalFilePath(locator CryptoLocator) : Path in class org.cryptomator.webdav.jackrabbit.ResourcePathUtils	From	To
Change Parameter Type ioSupport : CryptorIOSupport to ioSupport : CryptorMetadataSupport in method public encryptFilename(cleartextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method private createFilePart(locator CryptoLocator, session DavSession, request DavServletRequest) : EncryptedFile in class org.cryptomator.webdav.jackrabbit.CryptoResourceFactory	From	To
Change Parameter Type factory : DavResourceFactory to factory : CryptoResourceFactory in method public EncryptedFilePart(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, request DavServletRequest, lockManager LockManager, cryptor Cryptor, cryptoWarningHandler CryptoWarningHandler, backgroundTaskExecutor ExecutorService) in class org.cryptomator.webdav.jackrabbit.EncryptedFilePart	From	To
Change Parameter Type factory : DavResourceFactory to factory : CryptoResourceFactory in method public NonExistingNode(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor) in class org.cryptomator.webdav.jackrabbit.NonExistingNode	From	To
Change Parameter Type ioSupport : CryptorIOSupport to ioSupport : CryptorMetadataSupport in method private getMetadata(ioSupport CryptorMetadataSupport, metadataGroup String) : LongFilenameMetadata in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Change Parameter Type resource : DavResource to childLocator : CryptoLocator in method private addMemberDir(childLocator CryptoLocator, inputContext InputContext) : void in class org.cryptomator.webdav.jackrabbit.EncryptedDir	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method private createNonExisting(locator CryptoLocator, session DavSession) : NonExistingNode in class org.cryptomator.webdav.jackrabbit.CryptoResourceFactory	From	To
Change Parameter Type ioSupport : CryptorIOSupport to ioSupport : CryptorMetadataSupport in method private storeMetadata(ioSupport CryptorMetadataSupport, metadataGroup String, metadata LongFilenameMetadata) : void in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Change Parameter Type locator : DavResourceLocator to locator : CryptoLocator in method public EncryptedDir(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor) in class org.cryptomator.webdav.jackrabbit.EncryptedDir	From	To
Change Parameter Type resource : DavResource to childLocator : CryptoLocator in method private addMemberFile(childLocator CryptoLocator, inputContext InputContext) : void in class org.cryptomator.webdav.jackrabbit.EncryptedDir	From	To
Change Parameter Type factory : DavResourceFactory to factory : CryptoResourceFactory in method protected AbstractEncryptedNode(factory CryptoResourceFactory, locator CryptoLocator, session DavSession, lockManager LockManager, cryptor Cryptor) in class org.cryptomator.webdav.jackrabbit.AbstractEncryptedNode	From	To
Pull Up Attribute	1
Pull Up Attribute private cryptor : Cryptor from class org.cryptomator.crypto.SamplingDecorator to protected cryptor : Cryptor from class org.cryptomator.crypto.AbstractCryptorDecorator	From	To
Rename Class	3
Rename Class org.cryptomator.crypto.CryptorIOSupport renamed to org.cryptomator.crypto.CryptorMetadataSupport	From	To
Rename Class org.cryptomator.webdav.jackrabbit.DavResourceFactoryImpl renamed to org.cryptomator.webdav.jackrabbit.CryptoResourceFactory	From	To
Rename Class org.cryptomator.crypto.SamplingDecorator renamed to org.cryptomator.crypto.SamplingCryptorDecorator	From	To
Move And Rename Class	1
Move And Rename Class org.cryptomator.webdav.jackrabbit.DavLocatorFactoryImpl.DavResourceLocatorImpl moved and renamed to org.cryptomator.webdav.jackrabbit.CryptoLocator	From	To
Move Class	1
Move Class org.cryptomator.webdav.jackrabbit.BidiLRUMap moved to org.cryptomator.crypto.PathCachingCryptorDecorator.BidiLRUMap	From	To
Change Variable Type	2
Change Variable Type ioSupportMock : CryptorIOSupport to ioSupportMock : CryptorMetadataSupport in method public testEncryptionOfFilenames() : void in class org.cryptomator.crypto.aes256.Aes256CryptorTest	From	To
Change Variable Type other : DavResourceLocatorImpl to other : CryptoLocator in method public equals(obj Object) : boolean in class org.cryptomator.webdav.jackrabbit.CryptoLocator	From	To
Extract Method	1
Extract Method private addMember(childResource AbstractEncryptedNode, inputContext InputContext) : void extracted from public addMember(resource DavResource, inputContext InputContext) : void in class org.cryptomator.webdav.jackrabbit.EncryptedDir	From	To
Rename Method	8
Rename Method public getPhysicalPath(locator DavResourceLocator) : Path renamed to public getPhysicalFilePath(locator CryptoLocator) : Path in class org.cryptomator.webdav.jackrabbit.ResourcePathUtils	From	To
Rename Method public swipeSensitiveDataInternal() : void renamed to public destroy() : void in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Rename Method public writePathSpecificMetadata(encryptedPath String, encryptedMetadata byte[]) : void renamed to public writeMetadata(encryptedPath String, encryptedMetadata byte[]) : void in class org.cryptomator.crypto.aes256.Aes256CryptorTest.CryptoIOSupportMock	From	To
Rename Method public writePathSpecificMetadata(encryptedPath String, encryptedMetadata byte[]) : void renamed to public writeMetadata(metadataGroup String, encryptedMetadata byte[]) : void in class org.cryptomator.crypto.CryptorMetadataSupport	From	To
Rename Method private decryptPathComponent(encrypted String, aesKey SecretKey, macKey SecretKey, ioSupport CryptorIOSupport) : String renamed to public decryptFilename(ciphertextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Rename Method public readPathSpecificMetadata(encryptedPath String) : byte[] renamed to public readMetadata(encryptedPath String) : byte[] in class org.cryptomator.crypto.aes256.Aes256CryptorTest.CryptoIOSupportMock	From	To
Rename Method public readPathSpecificMetadata(encryptedPath String) : byte[] renamed to public readMetadata(metadataGroup String) : byte[] in class org.cryptomator.crypto.CryptorMetadataSupport	From	To
Rename Method private encryptPathComponent(cleartext String, aesKey SecretKey, macKey SecretKey, ioSupport CryptorIOSupport) : String renamed to public encryptFilename(cleartextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Pull Up Method	5
Pull Up Method public decryptedContentLength(encryptedFile SeekableByteChannel) : Long from class org.cryptomator.crypto.SamplingDecorator to public decryptedContentLength(encryptedFile SeekableByteChannel) : Long from class org.cryptomator.crypto.AbstractCryptorDecorator	From	To
Pull Up Method public isAuthentic(encryptedFile SeekableByteChannel) : boolean from class org.cryptomator.crypto.SamplingDecorator to public isAuthentic(encryptedFile SeekableByteChannel) : boolean from class org.cryptomator.crypto.AbstractCryptorDecorator	From	To
Pull Up Method public getPayloadFilesFilter() : Filter<Path> from class org.cryptomator.crypto.SamplingDecorator to public getPayloadFilesFilter() : Filter<Path> from class org.cryptomator.crypto.AbstractCryptorDecorator	From	To
Pull Up Method public encryptMasterKey(out OutputStream, password CharSequence) : void from class org.cryptomator.crypto.SamplingDecorator to public encryptMasterKey(out OutputStream, password CharSequence) : void from class org.cryptomator.crypto.AbstractCryptorDecorator	From	To
Pull Up Method public decryptMasterKey(in InputStream, password CharSequence) : void from class org.cryptomator.crypto.SamplingDecorator to public decryptMasterKey(in InputStream, password CharSequence) : void from class org.cryptomator.crypto.AbstractCryptorDecorator	From	To
Change Return Type	3
Change Return Type DavLocatorFactory to CryptoLocatorFactory in method public getFactory() : CryptoLocatorFactory in class org.cryptomator.webdav.jackrabbit.CryptoLocator	From	To
Change Return Type DavResourceFactory to CryptoResourceFactory in method public getFactory() : CryptoResourceFactory in class org.cryptomator.webdav.jackrabbit.AbstractEncryptedNode	From	To
Change Return Type DavResourceLocator to CryptoLocator in method public getLocator() : CryptoLocator in class org.cryptomator.webdav.jackrabbit.AbstractEncryptedNode	From	To
Replace Variable With Attribute	4
Replace Variable With Attribute macKey : SecretKey to hMacMasterKey : SecretKey in method public decryptFilename(ciphertextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Replace Variable With Attribute aesKey : SecretKey to primaryMasterKey : SecretKey in method public encryptFilename(cleartextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Replace Variable With Attribute macKey : SecretKey to hMacMasterKey : SecretKey in method public encryptFilename(cleartextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Replace Variable With Attribute aesKey : SecretKey to primaryMasterKey : SecretKey in method public decryptFilename(ciphertextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Extract Superclass	1
Extract Superclass org.cryptomator.crypto.AbstractCryptorDecorator from classes [org.cryptomator.crypto.SamplingCryptorDecorator]	From	To
Change Attribute Type	3
Change Attribute Type locator : DavResourceLocator to locator : CryptoLocator in class org.cryptomator.webdav.jackrabbit.EncryptedFilePart.MacAuthenticationJob	From	To
Change Attribute Type locator : DavResourceLocator to locator : CryptoLocator in class org.cryptomator.webdav.jackrabbit.AbstractEncryptedNode	From	To
Change Attribute Type factory : DavResourceFactory to factory : CryptoResourceFactory in class org.cryptomator.webdav.jackrabbit.AbstractEncryptedNode	From	To
Rename Parameter	9
Rename Parameter resource : DavResource to childLocator : CryptoLocator in method private addMemberFile(childLocator CryptoLocator, inputContext InputContext) : void in class org.cryptomator.webdav.jackrabbit.EncryptedDir	From	To
Rename Parameter encrypted : String to ciphertextName : String in method public decryptFilename(ciphertextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Rename Parameter metadataFile : String to metadataGroup : String in method private storeMetadata(ioSupport CryptorMetadataSupport, metadataGroup String, metadata LongFilenameMetadata) : void in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Rename Parameter metadataFile : String to metadataGroup : String in method private getMetadata(ioSupport CryptorMetadataSupport, metadataGroup String) : LongFilenameMetadata in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To
Rename Parameter resource : DavResource to childLocator : CryptoLocator in method private addMemberDir(childLocator CryptoLocator, inputContext InputContext) : void in class org.cryptomator.webdav.jackrabbit.EncryptedDir	From	To
Rename Parameter ioException : IOException to cause : IOException in method public IORuntimeException(cause IOException) in class org.cryptomator.webdav.exceptions.IORuntimeException	From	To
Rename Parameter encryptedPath : String to metadataGroup : String in method public readMetadata(metadataGroup String) : byte[] in class org.cryptomator.crypto.CryptorMetadataSupport	From	To
Rename Parameter encryptedPath : String to metadataGroup : String in method public writeMetadata(metadataGroup String, encryptedMetadata byte[]) : void in class org.cryptomator.crypto.CryptorMetadataSupport	From	To
Rename Parameter cleartext : String to cleartextName : String in method public encryptFilename(cleartextName String, ioSupport CryptorMetadataSupport) : String in class org.cryptomator.crypto.aes256.Aes256Cryptor	From	To

cdf9c28a3874981c66e499fcd9532e12f2cbe9b0

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: