cucumber-jvm f84035870c2b6a94c07bf8dda829f335b549c4c5

f84035870c2b6a94c07bf8dda829f335b549c4c5

Files Diff

Added: 29
Removed: 0
Renamed: 0
Modified: 58

Link to commit

Dependency Action
Added
	org.assertj:assertj-core:1.7.1
	uk.co.datumedge:hamcrest-json:0.2

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	2
Move And Rename Method public getGlue() : Glue from class cucumber.runner.Runner to public get() : Glue from class cucumber.runtime.TestGlueHelper	From	To
Move And Rename Method public EventBus(stopWatch TimeService) from class cucumber.runner.EventBus to public TimeServiceEventBus(stopWatch TimeService) from class cucumber.runner.TimeServiceEventBus	From	To
Move And Inline Method	1
Move And Inline Method public runFeatureWithFormatter(feature CucumberFeature, stepsToResult Map<String,Result>, stepsToLocation Map<String,String>, hooks List<SimpleEntry<String,Result>>, hookLocations List<String>, hookActions List<Answer<Object>>, stepHookDuration long, formatter Formatter) : void moved from class cucumber.runtime.TestHelper to class cucumber.runtime.formatter.HTMLFormatterTest & inlined to private runFeaturesWithFormatter() : String	From	To
Extract Subclass	1
Extract Subclass cucumber.runner.SynchronizedEventBus from class cucumber.runner.EventBus	From	To
Change Parameter Type	2
Change Parameter Type events : List<Event> to events : Iterable<Event> in method public sendAll(events Iterable<Event>) : void in class cucumber.runner.AbstractEventPublisher	From	To
Change Parameter Type bus : EventBus to eventPublisher : EventPublisher in method public Plugins(classLoader ClassLoader, pluginFactory PluginFactory, eventPublisher EventPublisher, runtimeOptions RuntimeOptions) in class cucumber.runtime.formatter.Plugins	From	To
Move Method	1
Move Method package sendAll(events List<Event>) : void from class cucumber.runner.EventBus to public sendAll(events Iterable<Event>) : void from class cucumber.runner.AbstractEventPublisher	From	To
Move Attribute	4
Move Attribute private handlers : Map<Class<? extends Event>,List<EventHandler>> from class cucumber.runner.EventBus to protected handlers : Map<Class<? extends Event>,List<EventHandler>> from class cucumber.runner.AbstractEventPublisher	From	To
Move Attribute private runner : Runner from class cucumber.runtime.Runtime to private runner : Runner from class cucumber.runtime.SingletonRunnerSupplier	From	To
Move Attribute private exitStatus : ExitStatus from class cucumber.runtime.RuntimeTest to private exitStatus : ExitStatus from class cucumber.runtime.Runtime	From	To
Move Attribute private stopWatch : TimeService from class cucumber.runner.EventBus to private stopWatch : TimeService from class cucumber.runner.TimeServiceEventBus	From	To
Merge Variable	1
Merge Variable [keyword : String, uri : String] to message : String in method private handleTestStepFinished(stepText String, result Result) : void in class cucumber.api.testng.TestNGReporter	From	To
Extract Variable	1
Extract Variable runner : Runner in method public runScenario(pickle PickleEvent) : void from class cucumber.api.testng.TestNGCucumberRunner	From	To
Change Variable Type	11
Change Variable Type stepHookDuration : long to stepDuration : Long in method public testDurationCalculationOfStepsAndHooks() : void in class cucumber.runtime.formatter.TestNGFormatterTest	From	To
Change Variable Type stepHookDuration : long to stepDuration : Long in method public should_handle_failure_in_before_hook() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Change Variable Type runnerSupplier : RunnerSupplier to glue : Glue in method public after_hooks_execute_before_objects_are_disposed() : void in class cucumber.runtime.HookTest	From	To
Change Variable Type stepHookDuration : long to stepDuration : Long in method public should_handle_failure_in_before_hook_with_background() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Change Variable Type stepHookDuration : long to stepDuration : Long in method public testScenarioWithFailedAfterHook() : void in class cucumber.runtime.formatter.TestNGFormatterTest	From	To
Change Variable Type stepHookDuration : long to stepDuration : Long in method public should_handle_failure_in_after_hook() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Change Variable Type stepHookDuration : long to stepDuration : Long in method public should_accumulate_time_from_steps_and_hooks() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Change Variable Type stepHookDuration : long to stepDuration : Long in method public should_handle_pending_in_before_hook() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Change Variable Type glueSupplier : RuntimeGlueSupplier to glueSupplier : GlueSupplier in method public after_hooks_execute_before_objects_are_disposed() : void in class cucumber.runtime.HookTest	From	To
Change Variable Type stepHookDuration : long to stepDuration : Long in method public testScenarioWithFailedBeforeHook() : void in class cucumber.runtime.formatter.TestNGFormatterTest	From	To
Change Variable Type formatter : Formatter to formatter : EventListener in method private setEventBusOnEventListenerPlugins(plugin Object) : void in class cucumber.runtime.formatter.Plugins	From	To
Inline Variable	1
Inline Variable resultDuration : Long in method private mapStatusToResult(status Result.Type, error Throwable, duration long) : Result from class cucumber.runner.TestStep	From	To
Rename Method	5
Rename Method package uri(uri String) : void renamed to private handleTestStepFinished(stepText String, result Result) : void in class cucumber.api.testng.TestNGReporter	From	To
Rename Method private runFeaturesWithRerunFormatter(features List<CucumberFeature>, stepsToResult Map<String,Result>, hooks List<SimpleEntry<String,Result>>, isStrict boolean) : String renamed to private runFeaturesWithFormatter(isStrict boolean) : String in class cucumber.runtime.formatter.RerunFormatterTest	From	To
Rename Method private runFeatureWithHTMLFormatter(feature CucumberFeature, stepsToResult Map<String,Result>, stepsToLocation Map<String,String>, hooks List<SimpleEntry<String,Result>>, hookActions List<Answer<Object>>, stepHookDuration long) : String renamed to private runFeaturesWithFormatter() : String in class cucumber.runtime.formatter.HTMLFormatterTest	From	To
Rename Method private runFeatureWithPrettyFormatter(feature CucumberFeature, stepsToLocation Map<String,String>, stepsToResult Map<String,Result>, hooks List<SimpleEntry<String,Result>>, hookActions List<Answer<Object>>, monochrome boolean) : String renamed to private runFeaturesWithFormatter(monochrome boolean) : String in class cucumber.runtime.formatter.PrettyFormatterTest	From	To
Rename Method private runFeatureWithJUnitFormatter(feature CucumberFeature, stepsToResult Map<String,Result>, hooks List<SimpleEntry<String,Result>>, stepHookDuration long) : String renamed to private runFeaturesWithFormatter() : String in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Push Down Method	4
Push Down Method public getTime() : Long from class cucumber.runner.EventBus to public getTime() : Long from class cucumber.runner.SynchronizedEventBus	From	To
Push Down Method public removeHandlerFor(eventType Class<T>, handler EventHandler<T>) : void from class cucumber.runner.EventBus to public removeHandlerFor(eventType Class<T>, handler EventHandler<T>) : void from class cucumber.runner.SynchronizedEventBus	From	To
Push Down Method public send(event Event) : void from class cucumber.runner.EventBus to public send(event Event) : void from class cucumber.runner.SynchronizedEventBus	From	To
Push Down Method public registerHandlerFor(eventType Class<T>, handler EventHandler<T>) : void from class cucumber.runner.EventBus to public registerHandlerFor(eventType Class<T>, handler EventHandler<T>) : void from class cucumber.runner.SynchronizedEventBus	From	To
Inline Method	4
Inline Method private monochrome(value boolean) : boolean inlined to public should_color_code_error_message_according_to_the_result() : void in class cucumber.runtime.formatter.PrettyFormatterTest	From	To
Inline Method private monochrome(value boolean) : boolean inlined to public should_color_code_steps_according_to_the_result() : void in class cucumber.runtime.formatter.PrettyFormatterTest	From	To
Inline Method private monochrome(value boolean) : boolean inlined to public should_color_code_locations_as_comments() : void in class cucumber.runtime.formatter.PrettyFormatterTest	From	To
Inline Method private strict(value boolean) : boolean inlined to public should_put_data_in_report_when_exit_code_is_non_zero() : void in class cucumber.runtime.formatter.RerunFormatterTest	From	To
Rename Variable	11
Rename Variable runnerSupplier : RunnerSupplier to glue : Glue in method public after_hooks_execute_before_objects_are_disposed() : void in class cucumber.runtime.HookTest	From	To
Rename Variable htmlFormatter : HTMLFormatter to formatter : HTMLFormatter in method private runFeaturesWithFormatter() : String in class cucumber.runtime.formatter.HTMLFormatterTest	From	To
Rename Variable keyword : String to format : String in method private handleTestStepFinished(stepText String, result Result) : void in class cucumber.api.testng.TestNGReporter	From	To
Rename Variable junitFormatter : JUnitFormatter to formatter : JUnitFormatter in method private runFeaturesWithFormatter() : String in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Rename Variable testStep : TestStep to step : TestStep in method public step_execution_time_is_measured() : void in class cucumber.runner.PickleStepTestStepTest	From	To
Rename Variable buffer : StringBuffer to report : StringBuffer in method private runFeaturesWithFormatter(isStrict boolean) : String in class cucumber.runtime.formatter.RerunFormatterTest	From	To
Rename Variable prettyFormatter : PrettyFormatter to formatter : PrettyFormatter in method private runFeaturesWithFormatter(monochrome boolean) : String in class cucumber.runtime.formatter.PrettyFormatterTest	From	To
Rename Variable out : StringBuilder to report : StringBuilder in method private runFeaturesWithFormatter(monochrome boolean) : String in class cucumber.runtime.formatter.PrettyFormatterTest	From	To
Rename Variable rerunFormatter : RerunFormatter to formatter : RerunFormatter in method private runFeaturesWithFormatter(isStrict boolean) : String in class cucumber.runtime.formatter.RerunFormatterTest	From	To
Rename Variable exitstatus : byte to exitStatus : byte in method public main(argv String[]) : void in class cucumber.api.cli.Main	From	To
Rename Variable out : StringBuilder to report : StringBuilder in method private runFeaturesWithFormatter() : String in class cucumber.runtime.formatter.HTMLFormatterTest	From	To
Replace Variable With Attribute	12
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public should_handle_failure_in_before_hook() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : Long to stepDuration : Long in method public should_handle_embed_from_a_hook() : void in class cucumber.runtime.formatter.JSONFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : Long to stepDuration : Long in method public should_handle_write_from_a_hook() : void in class cucumber.runtime.formatter.JSONFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public testScenarioWithFailedAfterHook() : void in class cucumber.runtime.formatter.TestNGFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public should_handle_failure_in_before_hook_with_background() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public should_accumulate_time_from_steps_and_hooks() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public testScenarioWithFailedBeforeHook() : void in class cucumber.runtime.formatter.TestNGFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public testDurationCalculationOfStepsAndHooks() : void in class cucumber.runtime.formatter.TestNGFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : Long to stepDuration : Long in method public should_format_scenario_with_hooks() : void in class cucumber.runtime.formatter.JSONFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public should_handle_failure_in_after_hook() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : Long to stepDuration : Long in method public should_add_step_hooks_to_step() : void in class cucumber.runtime.formatter.JSONFormatterTest	From	To
Replace Variable With Attribute stepHookDuration : long to stepDuration : Long in method public should_handle_pending_in_before_hook() : void in class cucumber.runtime.formatter.JUnitFormatterTest	From	To
Extract Superclass	1
Extract Superclass cucumber.api.event.TestCaseEvent from classes [cucumber.api.event.EmbedEvent, cucumber.api.event.TestCaseFinished, cucumber.api.event.TestCaseStarted, cucumber.api.event.TestStepFinished, cucumber.api.event.TestStepStarted, cucumber.api.event.WriteEvent]	From	To
Rename Attribute	3
Rename Attribute runFinishHandler : EventHandler<TestRunFinished> to testCaseFinishedHandler : EventHandler<TestCaseFinished> in class cucumber.api.testng.TestNGReporter	From	To
Rename Attribute runner : Runner to runnerSupplier : RunnerSupplier in class cucumber.runtime.Runtime	From	To
Rename Attribute bus : EventBus to eventPublisher : EventPublisher in class cucumber.runtime.formatter.Plugins	From	To
Extract Interface	2
Extract Interface cucumber.api.formatter.ConcurrentFormatter from classes [cucumber.runtime.formatter.NullFormatter, cucumber.runtime.formatter.PrettyFormatter, cucumber.runtime.formatter.ProgressFormatter]	From	To
Extract Interface cucumber.api.event.ConcurrentEventListener from classes [cucumber.api.testng.TestNGReporter]	From	To
Change Attribute Type	4
Change Attribute Type bus : EventBus to eventPublisher : EventPublisher in class cucumber.runtime.formatter.Plugins	From	To
Change Attribute Type eventBus : EventBus to eventBus : SynchronizedEventBus in class cucumber.runtime.ThreadLocalRunnerSupplier	From	To
Change Attribute Type runFinishHandler : EventHandler<TestRunFinished> to testCaseFinishedHandler : EventHandler<TestCaseFinished> in class cucumber.api.testng.TestNGReporter	From	To
Change Attribute Type runner : Runner to runnerSupplier : RunnerSupplier in class cucumber.runtime.Runtime	From	To
Extract And Move Method	2
Extract And Move Method public exitStatus() : byte extracted from public run(argv String[], classLoader ClassLoader) : byte in class cucumber.api.cli.Main & moved to class cucumber.runtime.Runtime	From	To
Extract And Move Method public builder() : Builder extracted from private runFeatureWithPrettyFormatter(feature CucumberFeature, stepsToLocation Map<String,String>, stepsToResult Map<String,Result>, hooks List<SimpleEntry<String,Result>>, hookActions List<Answer<Object>>, monochrome boolean) : String in class cucumber.runtime.formatter.PrettyFormatterTest & moved to class cucumber.runtime.TestHelper	From	To
Rename Parameter	2
Rename Parameter uri : String to stepText : String in method private handleTestStepFinished(stepText String, result Result) : void in class cucumber.api.testng.TestNGReporter	From	To
Rename Parameter bus : EventBus to eventPublisher : EventPublisher in method public Plugins(classLoader ClassLoader, pluginFactory PluginFactory, eventPublisher EventPublisher, runtimeOptions RuntimeOptions) in class cucumber.runtime.formatter.Plugins	From	To

f84035870c2b6a94c07bf8dda829f335b549c4c5

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: