073ea68197cdc37e2ca9414da96e9df39ec49fcc
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 63
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getAllocatedByteCount() : int renamed to public getPayloadByteCount(valueCount int) : int in class org.apache.drill.exec.vector.$ | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public getPayloadByteCount() : int moved from class org.apache.drill.exec.vector.$ to class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer.ColumnSize & inlined to public ColumnSize(v ValueVector, prefix String, valueCount int) | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type ignoreWrappers : VectorWrapper[] to ignoreWrappers : VectorWrapper<?>[] in method public InternalBatch(incoming RecordBatch, ignoreWrappers VectorWrapper<?>[], oContext OperatorContext) in class org.apache.drill.exec.physical.impl.aggregate.InternalBatch | From | To | |
| Rename Variable | 4 | ||
| Rename Variable dayString : String to yearString : String in method public getAsStringBuilder(index int) : StringBuilder in class org.apache.drill.exec.vector.$.Accessor | From | To | |
| Rename Variable mergeLimit : int to memMergeLimit : int in method public consolidateBatches(allocMemory long, inMemCount int, spilledRunsCount int) : MergeTask in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Rename Variable colSize : ColumnSize to ledger : BufferLedger in method public RecordBatchSizer(va VectorAccessible, sv2 SelectionVector2) in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer | From | To | |
| Rename Variable yearString : String to dayString : String in method public getAsStringBuilder(index int) : StringBuilder in class org.apache.drill.exec.vector.$.Accessor | From | To | |
| Change Return Type | 5 | ||
| Change Return Type RecordBatchSizer to void in method private analyzeIncomingBatch(incoming VectorAccessible) : void in class org.apache.drill.exec.physical.impl.xsort.managed.SortImpl | From | To | |
| Change Return Type int to BatchSizeEstimate in method public getSpillBatchSize() : BatchSizeEstimate in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Change Return Type int to BatchSizeEstimate in method public getInputBatchSize() : BatchSizeEstimate in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Change Return Type void to boolean in method public updateEstimates(batchDataSize int, batchRowWidth int, batchRowCount int) : boolean in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Change Return Type int to BatchSizeEstimate in method public getMergeBatchSize() : BatchSizeEstimate in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute numNullables : int to nullableCount : int in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer | From | To | |
| Rename Attribute density : int to prefix : String in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer.ColumnSize | From | To | |
| Rename Attribute variableWidth : boolean to isVariableWidth : boolean in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer.ColumnSize | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type seconds : long to seconds : int in method public getAsStringBuilder(index int) : StringBuilder in class org.apache.drill.exec.vector.$.Accessor | From | To | |
| Change Variable Type seconds : int to seconds : long in method public getAsStringBuilder(index int) : StringBuilder in class org.apache.drill.exec.vector.$.Accessor | From | To | |
| Change Variable Type memoryLimit : long to memoryLimit : int in method public testLowMemory() : void in class org.apache.drill.exec.physical.impl.xsort.managed.TestExternalSortInternals | From | To | |
| Change Variable Type colSize : ColumnSize to ledger : BufferLedger in method public RecordBatchSizer(va VectorAccessible, sv2 SelectionVector2) in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type density : int to prefix : String in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer.ColumnSize | From | To | |
| Extract Method | 2 | ||
| Extract Method private computeEstimates() : void extracted from public RecordBatchSizer(va VectorAccessible, sv2 SelectionVector2) in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer | From | To | |
| Extract Method private isRegistrySyncNeeded() : boolean extracted from public syncWithRemoteRegistry(version long) : boolean in class org.apache.drill.exec.expr.fn.FunctionImplementationRegistry | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter memoryLimit : long to opMemoryLimit : long in method public SortMemoryManager(config SortConfig, opMemoryLimit long) in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Rename Parameter count : int to size : int in method public generateTestData(size int) : void in class org.apache.drill.exec.vector.$.Mutator | From | To | |
| Rename Parameter batchSize : int to batchDataSize : int in method public updateEstimates(batchDataSize int, batchRowWidth int, batchRowCount int) : boolean in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Rename Parameter size : int to count : int in method public generateTestData(count int) : void in class org.apache.drill.exec.vector.$.Mutator | From | To | |
| Rename Parameter batchSize : int to batchDataSize : int in method private updateInputEstimates(batchDataSize int, batchRowWidth int, batchRowCount int) : boolean in class org.apache.drill.exec.physical.impl.xsort.managed.SortMemoryManager | From | To | |
| Rename Parameter vv : ValueVector to v : ValueVector in method public ColumnSize(v ValueVector, prefix String, valueCount int) in class org.apache.drill.exec.physical.impl.spill.RecordBatchSizer.ColumnSize | From | To |