drill 0dbd501c0e2b46073dc3308f81c293452139822b

0dbd501c0e2b46073dc3308f81c293452139822b

Files Diff

Added: 17
Removed: 5
Renamed: 0
Modified: 51

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public UnresolvedSchemaColumn(inCol RequestedColumn, colDefn ColumnMetadata) from class org.apache.drill.exec.physical.impl.scan.project.AbstractUnresolvedColumn.UnresolvedSchemaColumn to public UnresolvedColumn(inCol RequestedColumn, colDefn ColumnMetadata) from class org.apache.drill.exec.physical.impl.scan.project.AbstractUnresolvedColumn.UnresolvedColumn	From	To
Change Parameter Type	14
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildMapArray(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildSimpleList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in method public ContainerState(loader LoaderInternals, vectorCache ResultVectorCache, projectionSet ProjectionSet) in class org.apache.drill.exec.physical.rowSet.impl.ContainerState	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildUnion(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in method protected TupleState(events LoaderInternals, vectorCache ResultVectorCache, projectionSet ProjectionSet) in class org.apache.drill.exec.physical.rowSet.impl.TupleState	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildRepeatedList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildSingleMap(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in method public SingleMapState(events LoaderInternals, vectorCache ResultVectorCache, projectionSet ProjectionSet) in class org.apache.drill.exec.physical.rowSet.impl.TupleState.SingleMapState	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildPrimitive(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in method public MapState(events LoaderInternals, vectorCache ResultVectorCache, projectionSet ProjectionSet) in class org.apache.drill.exec.physical.rowSet.impl.TupleState.MapState	From	To
Change Parameter Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in method public MapArrayState(events LoaderInternals, vectorCache ResultVectorCache, projectionSet ProjectionSet) in class org.apache.drill.exec.physical.rowSet.impl.TupleState.MapArrayState	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildUnionList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Parameter Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildMap(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Move Method	5
Move Method public projectionType(columnName String) : ProjectionType from class org.apache.drill.exec.vector.accessor.writer.MapWriter.DummyMapWriter to public projectionType() : ProjectionType from class org.apache.drill.exec.physical.impl.scan.project.projSet.AbstractReadColProj	From	To
Move Method public outputSchema() : TupleMetadata from class org.apache.drill.exec.physical.rowSet.impl.DefaultSchemaTransformer to protected outputSchema() : TupleMetadata from class org.apache.drill.exec.physical.impl.scan.project.ScanSchemaOrchestrator.ScanSchemaOptions	From	To
Move Method public projectionType(columnName String) : ProjectionType from class org.apache.drill.exec.vector.accessor.writer.AbstractTupleWriter to public projectionType() : ProjectionType from class org.apache.drill.exec.physical.impl.scan.project.projSet.AbstractReadColProj	From	To
Move Method public metadata() : ColumnMetadata from class org.apache.drill.exec.physical.impl.scan.project.AbstractUnresolvedColumn.UnresolvedSchemaColumn to public metadata() : ColumnMetadata from class org.apache.drill.exec.physical.impl.scan.project.AbstractUnresolvedColumn.UnresolvedColumn	From	To
Move Method public projectionType(columnName String) : ProjectionType from class org.apache.drill.exec.vector.accessor.writer.MapWriter.DummyArrayMapWriter to public projectionType() : ProjectionType from class org.apache.drill.exec.physical.impl.scan.project.projSet.AbstractReadColProj	From	To
Move Attribute	1
Move Attribute private colDefn : ColumnMetadata from class org.apache.drill.exec.physical.impl.scan.project.AbstractUnresolvedColumn.UnresolvedSchemaColumn to private colDefn : ColumnMetadata from class org.apache.drill.exec.physical.impl.scan.project.AbstractUnresolvedColumn.UnresolvedColumn	From	To
Extract Class	1
Extract Class org.apache.drill.exec.physical.impl.scan.project.projSet.TypeConverter.Builder from class org.apache.drill.exec.physical.impl.scan.project.ScanSchemaOrchestrator.ScanOrchestratorBuilder	From	To
Move And Rename Class	1
Move And Rename Class org.apache.drill.exec.physical.rowSet.impl.SchemaTransformer.ColumnTransform moved and renamed to org.apache.drill.exec.physical.rowSet.ProjectionSet.ColumnReadProjection	From	To
Move Class	2
Move Class org.apache.drill.exec.physical.rowSet.impl.TestProjectedTuple moved to org.apache.drill.exec.physical.rowSet.project.TestProjectedTuple	From	To
Move Class org.apache.drill.exec.record.metadata.ProjectionType moved to org.apache.drill.exec.physical.rowSet.project.ProjectionType	From	To
Extract Variable	2
Extract Variable bCol : ColumnProjection in method public testOutputSchemaWildcard() : void from class org.apache.drill.exec.physical.impl.scan.project.TestScanLevelProjection	From	To
Extract Variable aCol : ColumnProjection in method public testOutputSchemaWildcard() : void from class org.apache.drill.exec.physical.impl.scan.project.TestScanLevelProjection	From	To
Change Variable Type	1
Change Variable Type outputCol : ColumnTransform to colProj : ColumnReadProjection in method public buildColumn(parent ContainerState, columnSchema ColumnMetadata) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Inline Variable	4
Inline Variable a1Md : ColumnMetadata in method public testArrayProjection() : void from class org.apache.drill.exec.physical.rowSet.impl.TestResultSetLoaderProjection	From	To
Inline Variable a3Md : ColumnMetadata in method public testArrayProjection() : void from class org.apache.drill.exec.physical.rowSet.impl.TestResultSetLoaderProjection	From	To
Inline Variable allowRequiredNulls : boolean in method protected ScanSchemaOptions(builder ScanOrchestratorBuilder) from class org.apache.drill.exec.physical.impl.scan.project.ScanSchemaOrchestrator.ScanSchemaOptions	From	To
Inline Variable a2Md : ColumnMetadata in method public testArrayProjection() : void from class org.apache.drill.exec.physical.rowSet.impl.TestResultSetLoaderProjection	From	To
Rename Method	1
Rename Method public projectNone() : boolean renamed to public isEmptyProjection() : boolean in class org.apache.drill.exec.physical.impl.scan.project.ScanLevelProjection	From	To
Rename Variable	1
Rename Variable outputCol : ColumnTransform to colProj : ColumnReadProjection in method public buildColumn(parent ContainerState, columnSchema ColumnMetadata) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Change Return Type	2
Change Return Type RequestedTuple to ProjectionSet in method public projectionSet() : ProjectionSet in class org.apache.drill.exec.physical.rowSet.impl.ContainerState	From	To
Change Return Type void to boolean in method private expandOutputSchema() : boolean in class org.apache.drill.exec.physical.impl.scan.project.ScanLevelProjection	From	To
Rename Attribute	1
Rename Attribute context : CustomErrorContext to errorContext : CustomErrorContext in class org.apache.drill.exec.physical.impl.scan.project.ScanSchemaOrchestrator.ScanOrchestratorBuilder	From	To
Change Attribute Type	4
Change Attribute Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in class org.apache.drill.exec.physical.rowSet.impl.ContainerState	From	To
Change Attribute Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in class org.apache.drill.exec.physical.rowSet.impl.ResultSetLoaderImpl.ResultSetOptions	From	To
Change Attribute Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in class org.apache.drill.exec.physical.rowSet.impl.OptionBuilder	From	To
Change Attribute Type projectionSet : RequestedTuple to projectionSet : ProjectionSet in class org.apache.drill.exec.physical.rowSet.impl.ResultSetLoaderImpl	From	To
Rename Parameter	10
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildMap(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter other : ProjectionType to readType : ProjectionType in method public isCompatible(readType ProjectionType) : boolean in class org.apache.drill.exec.physical.rowSet.project.ProjectionType	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildMapArray(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildSimpleList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildRepeatedList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildSingleMap(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildPrimitive(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildUnionList(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To
Rename Parameter outputCol : ColumnTransform to colProj : ColumnReadProjection in method private buildUnion(parent ContainerState, colProj ColumnReadProjection) : ColumnState in class org.apache.drill.exec.physical.rowSet.impl.ColumnBuilder	From	To

0dbd501c0e2b46073dc3308f81c293452139822b

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: