0dd0e833714120c77e3e7ef34de654f5246953b9
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 31
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method public readIntLittleEndian(in ByteBuf, offset int) : int from class org.apache.drill.exec.store.parquet.columnreaders.NullableFixedByteAlignedReaders.NullableDateReader to public readIntLittleEndian(in DrillBuf, offset int) : int from class org.apache.drill.exec.store.parquet.columnreaders.ColumnReader | From | To | |
| Pull Up Method public readIntLittleEndian(in ByteBuf, offset int) : int from class org.apache.drill.exec.store.parquet.columnreaders.FixedByteAlignedReader.DateReader to public readIntLittleEndian(in DrillBuf, offset int) : int from class org.apache.drill.exec.store.parquet.columnreaders.ColumnReader | From | To | |
| Change Parameter Type | 6 | ||
| Change Parameter Type in : ByteBuf to in : DrillBuf in method public readIntLittleEndian(in DrillBuf, offset int) : int in class org.apache.drill.exec.store.parquet.columnreaders.ColumnReader | From | To | |
| Change Parameter Type compressedByteBuf : ByteBuf to compressedByteBuf : DrillBuf in method public decompress(codecName CompressionCodecName, compressedByteBuf DrillBuf, uncompressedByteBuf DrillBuf, compressedSize int, uncompressedSize int) : void in class parquet.hadoop.CodecFactoryExposer | From | To | |
| Change Parameter Type parentStatus : ColumnReader to parentStatus : ColumnReader<?> in method package PageReader(parentStatus ColumnReader<?>, fs FileSystem, path Path, columnChunkMetaData ColumnChunkMetaData) in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Change Parameter Type uncompressedByteBuf : ByteBuf to uncompressedByteBuf : DrillBuf in method public decompress(codecName CompressionCodecName, compressedByteBuf DrillBuf, uncompressedByteBuf DrillBuf, compressedSize int, uncompressedSize int) : void in class parquet.hadoop.CodecFactoryExposer | From | To | |
| Change Parameter Type buf : PooledUnsafeDirectByteBuf to buf : AbstractByteBuf in method private UnsafeDirectLittleEndian(buf AbstractByteBuf, fake boolean) in class io.netty.buffer.UnsafeDirectLittleEndian | From | To | |
| Change Return Type | 1 | ||
| Change Return Type BytesInput to void in method public decompress(codecName CompressionCodecName, compressedByteBuf DrillBuf, uncompressedByteBuf DrillBuf, compressedSize int, uncompressedSize int) : void in class parquet.hadoop.CodecFactoryExposer | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute b : ByteBuf to pageData : DrillBuf in method public clearBuffers() : void in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute pageDataByteArray : DrillBuf to pageData : DrillBuf in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type b : ByteBuf to pageData : DrillBuf in method public clearBuffers() : void in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Change Variable Type compressedData : ByteBuf to compressedData : DrillBuf in method public next() : boolean in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Change Variable Type compressedData : ByteBuf to compressedData : DrillBuf in method private loadDictionaryIfExists(parentStatus ColumnReader<?>, columnChunkMetaData ColumnChunkMetaData, f FSDataInputStream) : void in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type wrapped : PooledUnsafeDirectByteBuf to wrapped : AbstractByteBuf in class io.netty.buffer.UnsafeDirectLittleEndian | From | To | |
| Change Attribute Type nullableVarBinaryVector : org.apache.drill.exec.vector.NullableVarBinaryVector to nullableVarBinaryVector : NullableVarBinaryVector in class org.apache.drill.exec.store.parquet.columnreaders.VarLengthColumnReaders.NullableVarBinaryColumn | From | To | |
| Change Attribute Type vectorData : ByteBuf to vectorData : DrillBuf in class org.apache.drill.exec.store.parquet.columnreaders.ColumnReader | From | To | |
| Extract Method | 4 | ||
| Extract Method private fail() : UnsupportedOperationException extracted from protected newDirectBuffer(initialCapacity int, maxCapacity int) : UnsafeDirectLittleEndian in class io.netty.buffer.PooledByteBufAllocatorL | From | To | |
| Extract Method private send(fragmentBatch FragmentRecordBatch, body DrillBuf, minor int, ack AckSender, shared boolean) : void extracted from protected handle(connection BitServerConnection, rpcType int, pBody ByteBuf, body ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.data.DataServer | From | To | |
| Extract Method private loadDictionaryIfExists(parentStatus ColumnReader<?>, columnChunkMetaData ColumnChunkMetaData, f FSDataInputStream) : void extracted from package PageReader(parentStatus ColumnReader, fs FileSystem, path Path, columnChunkMetaData ColumnChunkMetaData) in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To |