drill 11602456b3e7b334c6cd060e633f5668d32d80e9

11602456b3e7b334c6cd060e633f5668d32d80e9

Files Diff

Added: 1
Removed: 1
Renamed: 0
Modified: 52

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Replace Attribute	1
Replace Attribute package optManager : OptionManager from class org.apache.drill.exec.physical.unit.PhysicalOpUnitTestBase with private optionManager : OptionManager from class org.apache.drill.exec.expr.fn.FunctionImplementationRegistry	From	To
Rename Variable	1
Rename Variable blocksInMethod : int to exprsInMethod : int in method package flushCode() : void in class org.apache.drill.exec.expr.ClassGenerator	From	To
Pull Up Attribute	2
Pull Up Attribute private c : DrillConfig from class org.apache.drill.exec.physical.impl.TestCastFunctions to private c : DrillConfig from class org.apache.drill.exec.ExecTest	From	To
Pull Up Attribute private c : DrillConfig from class org.apache.drill.exec.physical.impl.common.TestHashTable to private c : DrillConfig from class org.apache.drill.exec.ExecTest	From	To
Extract Variable	1
Extract Variable funcReg : FunctionImplementationRegistry in method private getExpressionCode(expression String, batch RecordBatch) : String from class org.apache.drill.exec.expr.ExpressionTest	From	To
Change Variable Type	1
Change Variable Type b : LinkedList<JBlock> to b : LinkedList<SizedJBlock> in method private rotateBlock(mode BlkCreateMode) : void in class org.apache.drill.exec.expr.ClassGenerator	From	To
Extract Method	2
Extract Method private rotateBlock(mode BlkCreateMode) : void extracted from public rotateBlock() : void in class org.apache.drill.exec.expr.ClassGenerator	From	To
Extract Method public get(definition TemplateClassDefinition<T>, funcRegistry FunctionImplementationRegistry, optionManager OptionManager) : CodeGenerator<T> extracted from public get(definition TemplateClassDefinition<T>, funcRegistry FunctionImplementationRegistry) : CodeGenerator<T> in class org.apache.drill.exec.expr.CodeGenerator	From	To
Change Attribute Type	1
Change Attribute Type blocks : LinkedList<JBlock>[] to blocks : LinkedList<SizedJBlock>[] in class org.apache.drill.exec.expr.ClassGenerator	From	To
Extract And Move Method	39
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testDumpCat(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.client.DumpCatTest & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testUnion(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.union.TestSimpleUnion & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public orderedEqualityLeftJoin(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.join.TestMergeJoin & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public runTest(bitContext DrillbitContext, connection UserServer.UserClientConnection, expression String, expectedResults int) : void in class org.apache.drill.exec.physical.impl.TestComparisonFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastNumException(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testFilter(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.filter.TestSimpleFilter & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public sortOneKeyAscending(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.sort.TestSimpleSort & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public runTest(bitContext DrillbitContext, connection UserServer.UserClientConnection, expectedResults Object[], planPath String) : void in class org.apache.drill.exec.physical.impl.TestImplicitCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testByteSubstring(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestSimpleFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastBigInt(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastInt(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from private doTest(bitContext DrillbitContext, connection UserClientConnection, file String) : SimpleRootExec in class org.apache.drill.exec.physical.impl.agg.TestAgg & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testLimit(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.limit.TestSimpleLimit & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public simpleEqualityJoin(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.join.TestMergeJoin & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public runTest(bitContext DrillbitContext, connection UserServer.UserClientConnection, expectedResults Object[], planPath String) : void in class org.apache.drill.exec.fn.impl.TestNewMathFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testSubstringNegative(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestSimpleFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public project(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.project.TestSimpleProjection & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testSubstring(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestSimpleFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testFilter(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.trace.TestTraceOutputDump & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastFloat4(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public orderedEqualityInnerJoin(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.join.TestMergeJoin & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testFilter(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.trace.TestTraceMultiRecordBatch & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testSimpleIterator(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.record.TestRecordIterator & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testLimitNoEnd(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.limit.TestSimpleLimit & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public runTest(bitContext DrillbitContext, connection UserServer.UserClientConnection, expectedResults Object[], planPath String) : void in class org.apache.drill.exec.physical.impl.TestStringFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testMarkResetIterator(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.record.TestRecordIterator & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastNested(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from private doPhysicalTest(bitContext DrillbitContext, connection UserClientConnection, file String) : SimpleRootExec in class org.apache.drill.exec.physical.impl.TestOptiqPlans & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testJoinBatchSize(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.join.TestMergeJoin & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testRepeated(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.fn.impl.TestRepeatedFunction & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public sortTwoKeysOneAscendingOneDescending(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.sort.TestSimpleSort & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from private testHJMockScanCommon(bitContext DrillbitContext, connection UserServer.UserClientConnection, physicalPlan String, expectedRows int) : void in class org.apache.drill.exec.physical.impl.join.TestHashJoin & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testLimitAcrossBatches(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.limit.TestSimpleLimit & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastVarBinary(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastVarChar(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public orderedEqualityMultiBatchJoin(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.join.TestMergeJoin & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testBasicMathFunctions(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.fn.impl.TestMathFunctions & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testSV4Filter(bitContext DrillbitContext, connection UserClientConnection) : void in class org.apache.drill.exec.physical.impl.filter.TestSimpleFilter & moved to class org.apache.drill.exec.ExecTest	From	To
Extract And Move Method protected mockDrillbitContext(bitContext DrillbitContext) : void extracted from public testCastFloat8(bitContext DrillbitContext, connection UserServer.UserClientConnection) : void in class org.apache.drill.exec.physical.impl.TestCastFunctions & moved to class org.apache.drill.exec.ExecTest	From	To

11602456b3e7b334c6cd060e633f5668d32d80e9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: