12f57f0ca0ea9651ad763a5c01eb5708ba3f245a
Files Diff
- Added: 36
- Removed: 1
- Renamed: 0
- Modified: 57
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type scanRel : RelNode to scanRel : DrillScanRelBase in method public getLeadingRowCount(condition RexNode, tabIdxName String, scanRel DrillScanRelBase) : double in class org.apache.drill.exec.planner.index.Statistics | From | To | |
| Change Parameter Type scanRel : RelNode to scanRel : DrillScanRelBase in method public getLeadingRowCount(condition RexNode, tabIdxName String, scanRel DrillScanRelBase) : double in class org.apache.drill.exec.planner.index.MapRDBStatistics | From | To | |
| Change Parameter Type desiredFields : Map<String,DesiredField> to desiredFields : Map<String,FieldsReWriterUtil.DesiredField> in method public ProjectPushInfo(fields List<SchemaPath>, desiredFields Map<String,FieldsReWriterUtil.DesiredField>) in class org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectPushInfo | From | To | |
| Move Method | 2 | ||
| Move Method public getGroupScan() : GroupScan from class org.apache.drill.exec.planner.physical.ScanPrel to public getGroupScan() : GroupScan from class org.apache.drill.exec.planner.common.DrillScanRelBase | From | To | |
| Move Method private getFieldsInformation(rowType RelDataType, projects List<RexNode>) : ProjectPushInfo from class org.apache.drill.exec.planner.logical.DrillPushProjectIntoScanRule to public getFieldsInformation(rowType RelDataType, projects List<RexNode>) : ProjectPushInfo from class org.apache.drill.exec.planner.common.DrillRelOptUtil | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private groupScan : GroupScan from class org.apache.drill.exec.planner.logical.DrillScanRel to private groupScan : GroupScan from class org.apache.drill.exec.planner.common.DrillScanRelBase | From | To | |
| Move Attribute | 1 | ||
| Move Attribute protected groupScan : GroupScan from class org.apache.drill.exec.planner.physical.ScanPrel to private groupScan : GroupScan from class org.apache.drill.exec.planner.common.DrillScanRelBase | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.drill.exec.planner.physical.LimitUnionExchangeTransposeRule renamed to org.apache.drill.exec.planner.physical.LimitExchangeTransposeRule | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.drill.exec.planner.physical.PrelUtil.RefFieldsVisitor moved and renamed to org.apache.drill.exec.planner.index.SimpleRexRemap.FieldsMarker | From | To | |
| Move Class | 2 | ||
| Move Class org.apache.drill.exec.planner.logical.DrillPushProjectIntoScanRule.ProjectFieldsVisitor moved to org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectFieldsVisitor | From | To | |
| Move Class org.apache.drill.exec.planner.logical.DrillPushProjectIntoScanRule.ProjectPushInfo moved to org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectPushInfo | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type newScan : DrillScanPrel to newScan : ScanPrel in method public onMatch(call RelOptRuleCall) : void in class org.apache.drill.exec.planner.physical.ScanPrule | From | To | |
| Change Variable Type child : PhysicalOperator to child : SubScan in method public visitGroupScan(groupScan GroupScan, iNode IndexedFragmentNode) : PhysicalOperator in class org.apache.drill.exec.planner.fragment.Materializer | From | To | |
| Change Variable Type unionExchangePrel : UnionExchangePrel to exchangePrel : ExchangePrel in method public onMatch(call RelOptRuleCall) : void in class org.apache.drill.exec.planner.physical.LimitExchangeTransposeRule | From | To | |
| Change Variable Type desiredField : DesiredField to desiredField : FieldsReWriterUtil.DesiredField in method private addDesiredField(name String, type RelDataType, originalNode RexNode) : void in class org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectFieldsVisitor | From | To | |
| Change Variable Type desiredField : DesiredField to desiredField : FieldsReWriterUtil.DesiredField in method public ProjectPushInfo(fields List<SchemaPath>, desiredFields Map<String,FieldsReWriterUtil.DesiredField>) in class org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectPushInfo | From | To | |
| Change Variable Type entry : Map.Entry<String,DesiredField> to entry : Map.Entry<String,FieldsReWriterUtil.DesiredField> in method public ProjectPushInfo(fields List<SchemaPath>, desiredFields Map<String,FieldsReWriterUtil.DesiredField>) in class org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectPushInfo | From | To | |
| Extract Method | 5 | ||
| Extract Method private newPath(segment PathSegment, node RexNode) : PathSegment extracted from public visitCall(call RexCall) : PathSegment in class org.apache.drill.exec.planner.index.SimpleRexRemap.FieldsMarker | From | To | |
| Extract Method private internalNext() : IterOutcome extracted from public next() : IterOutcome in class org.apache.drill.exec.physical.impl.ScanBatch | From | To | |
| Extract Method private shouldContinueAfterNoRecords() : boolean extracted from public next() : IterOutcome in class org.apache.drill.exec.physical.impl.ScanBatch | From | To | |
| Extract Method private cleanAndReturnNone() : IterOutcome extracted from public next() : IterOutcome in class org.apache.drill.exec.physical.impl.ScanBatch | From | To | |
| Extract Method public computeHashJoinCostWithRowCntKeySize(planner RelOptPlanner, probeRowCount double, buildRowCount double, keySize int) : RelOptCost extracted from private computeHashJoinCostWithKeySize(planner RelOptPlanner, keySize int, mq RelMetadataQuery) : RelOptCost in class org.apache.drill.exec.planner.common.DrillJoinRelBase | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public getGroupScan() : GroupScan from class org.apache.drill.exec.planner.logical.DrillScanRel to public getGroupScan() : GroupScan from class org.apache.drill.exec.planner.common.DrillScanRelBase | From | To | |
| Rename Variable | 2 | ||
| Rename Variable newUnionExch : RelNode to newExch : RelNode in method public onMatch(call RelOptRuleCall) : void in class org.apache.drill.exec.planner.physical.LimitExchangeTransposeRule | From | To | |
| Rename Variable unionExchangePrel : UnionExchangePrel to exchangePrel : ExchangePrel in method public onMatch(call RelOptRuleCall) : void in class org.apache.drill.exec.planner.physical.LimitExchangeTransposeRule | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to boolean in method public setRecordMatched(index int) : boolean in class org.apache.drill.exec.physical.impl.join.HashJoinHelper | From | To | |
| Change Return Type FieldsReWriter to FieldsReWriterUtil.FieldsReWriter in method public getInputReWriter() : FieldsReWriterUtil.FieldsReWriter in class org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectPushInfo | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type desiredFields : Set<DesiredField> to desiredFields : Map<RexNode,String> in class org.apache.drill.exec.planner.index.SimpleRexRemap.FieldsMarker | From | To | |
| Change Attribute Type reWriter : FieldsReWriter to reWriter : FieldsReWriterUtil.FieldsReWriter in class org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectPushInfo | From | To | |
| Change Attribute Type desiredFields : Map<String,DesiredField> to desiredFields : Map<String,FieldsReWriterUtil.DesiredField> in class org.apache.drill.exec.planner.common.DrillRelOptUtil.ProjectFieldsVisitor | From | To |