180dd5648ab604b6396d91ba69a2f777f19bf79c
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 2 | ||
| Merge Attribute [handler : ControlMessageHandler, context : BootStrapContext] to config : ControlConnectionConfig in class org.apache.drill.exec.rpc.control.ControllerImpl | From | To | |
| Merge Attribute [allocator : BufferAllocator, localIdentity : DrillbitEndpoint, handler : ControlMessageHandler, context : BootStrapContext] to config : ControlConnectionConfig in class org.apache.drill.exec.rpc.control.ControlConnectionManager | From | To | |
| Rename Method | 3 | ||
| Rename Method public finalizeSession() : void renamed to public finalizeSaslSession() : void in class org.apache.drill.exec.rpc.AbstractServerConnection | From | To | |
| Rename Method public getAllocator() : BufferAllocator renamed to public getSaslClient() : SaslClient in class org.apache.drill.exec.rpc.control.ControlConnection | From | To | |
| Rename Method public setEndpoint(endpoint DrillbitEndpoint) : void renamed to package setLocalEndpoint(endpoint DrillbitEndpoint) : void in class org.apache.drill.exec.rpc.control.ConnectionManagerRegistry | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Response to void in method public handle(connection ControlConnection, rpcType int, pBody ByteBuf, dBody ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.work.batch.ControlMessageHandler | From | To | |
| Change Return Type BufferAllocator to SaslClient in method public getSaslClient() : SaslClient in class org.apache.drill.exec.rpc.control.ControlConnection | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlClient to private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlConnectionConfig | From | To | |
| Move Attribute private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlServer to private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlConnectionConfig | From | To | |
| Move Attribute private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ConnectionManagerRegistry to private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlConnectionConfig | From | To | |
| Move Attribute private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlConnectionManager to private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlConnectionConfig | From | To | |
| Move Attribute private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControllerImpl to private handler : ControlMessageHandler from class org.apache.drill.exec.rpc.control.ControlConnectionConfig | From | To | |
| Extract Class | 5 | ||
| Extract Class org.apache.drill.exec.rpc.control.ControlConnectionConfig from class org.apache.drill.exec.rpc.control.ControlClient | From | To | |
| Extract Class org.apache.drill.exec.rpc.control.ControlConnectionConfig from class org.apache.drill.exec.rpc.control.ControlServer | From | To | |
| Extract Class org.apache.drill.exec.rpc.control.ControlConnectionConfig from class org.apache.drill.exec.rpc.control.ControlConnectionManager | From | To | |
| Extract Class org.apache.drill.exec.rpc.control.ControlConnectionConfig from class org.apache.drill.exec.rpc.control.ConnectionManagerRegistry | From | To | |
| Extract Class org.apache.drill.exec.rpc.control.ControlConnectionConfig from class org.apache.drill.exec.rpc.control.ControllerImpl | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [context : BootStrapContext, allocator : BufferAllocator] to config : ControlConnectionConfig in method public ControlClient(config ControlConnectionConfig, remoteEndpoint DrillbitEndpoint, closeHandlerFactory ControlConnectionManager.CloseHandlerCreator) in class org.apache.drill.exec.rpc.control.ControlClient | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute endpoint : DrillbitEndpoint to remoteEndpoint : DrillbitEndpoint in class org.apache.drill.exec.rpc.control.ControlConnectionManager | From | To | |
| Extract Variable | 1 | ||
| Extract Variable builder : BitControlHandshake.Builder in method public getHandshakeResponse(inbound BitControlHandshake) : MessageLite from class org.apache.drill.exec.rpc.control.ControlServer.getHandshakeHandler | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type logger : org.slf4j.Logger to logger : Logger in class org.apache.drill.exec.rpc.control.ControlConnection | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter endpoint : DrillbitEndpoint to remoteEndpoint : DrillbitEndpoint in method public getConnectionManager(remoteEndpoint DrillbitEndpoint) : ControlConnectionManager in class org.apache.drill.exec.rpc.control.ConnectionManagerRegistry | From | To |