349ac5ad431a6814f0a065bf16dee635cc6d3274
Files Diff
- Added: 21
- Removed: 0
- Renamed: 0
- Modified: 35
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public builder() : Builder renamed to public standardFixture(dirTestWatcher BaseDirTestWatcher) : OperatorFixture in class org.apache.drill.test.OperatorFixture | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type needsSpill : boolean to calc : HashJoinMemoryCalculator.BuildSidePartitioning in method public appendInnerRow(buildContainer VectorContainer, ind int, hashCode int, calc HashJoinMemoryCalculator.BuildSidePartitioning) : void in class org.apache.drill.exec.physical.impl.common.HashPartition | From | To | |
| Rename Variable | 3 | ||
| Rename Variable conditionsSize : int to comparators : List<Comparator> in method private setupHashTable() : void in class org.apache.drill.exec.physical.impl.join.HashJoinBatch | From | To | |
| Rename Variable cond : JoinCondition to rightPath : SchemaPath in method public HashJoinBatch(popConfig HashJoinPOP, context FragmentContext, left RecordBatch, right RecordBatch) in class org.apache.drill.exec.physical.impl.join.HashJoinBatch | From | To | |
| Rename Variable v : VectorWrapper<?> to vectorWrapper : VectorWrapper<?> in method private allocateVectors() : void in class org.apache.drill.exec.physical.impl.join.HashJoinBatch | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Builder to OperatorFixture in method public standardFixture(dirTestWatcher BaseDirTestWatcher) : OperatorFixture in class org.apache.drill.test.OperatorFixture | From | To | |
| Extract Attribute | 2 | ||
| Extract Attribute public EQUALITY_CONDITION : String in class org.apache.drill.exec.planner.logical.DrillJoinRel | From | To | |
| Extract Attribute public HASH_VALUE_COLUMN_NAME : String in class org.apache.drill.exec.physical.impl.common.HashPartition | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute vcList : List<VectorContainer> to tmpBatchesList : List<VectorContainer> in method public spillThisPartition() : void in class org.apache.drill.exec.physical.impl.common.HashPartition | From | To | |
| Extract Variable | 1 | ||
| Extract Variable valueVector : ValueVector in method private allocateVectors() : void from class org.apache.drill.exec.physical.impl.join.HashJoinBatch | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type conditionsSize : int to comparators : List<Comparator> in method private setupHashTable() : void in class org.apache.drill.exec.physical.impl.join.HashJoinBatch | From | To | |
| Change Variable Type cond : JoinCondition to rightPath : SchemaPath in method public HashJoinBatch(popConfig HashJoinPOP, context FragmentContext, left RecordBatch, right RecordBatch) in class org.apache.drill.exec.physical.impl.join.HashJoinBatch | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.apache.drill.exec.physical.impl.join.HashJoinMemoryCalculator.PartitionStat from classes [org.apache.drill.exec.physical.impl.common.HashPartition] | From | To | |
| Extract Method | 1 | ||
| Extract Method public builder(dirTestWatcher BaseDirTestWatcher) : Builder extracted from public builder() : Builder in class org.apache.drill.test.OperatorFixture | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type dirTestWatcher : DirTestWatcher to dirTestWatcher : BaseDirTestWatcher in class org.apache.drill.exec.cache.TestBatchSerialization | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter size : int to count : int in method public generateTestData(count int) : void in class org.apache.drill.exec.vector.$.Mutator | From | To | |
| Rename Parameter count : int to size : int in method public generateTestData(size int) : void in class org.apache.drill.exec.vector.$.Mutator | From | To | |
| Rename Parameter needsSpill : boolean to calc : HashJoinMemoryCalculator.BuildSidePartitioning in method public appendInnerRow(buildContainer VectorContainer, ind int, hashCode int, calc HashJoinMemoryCalculator.BuildSidePartitioning) : void in class org.apache.drill.exec.physical.impl.common.HashPartition | From | To |