39582bd60c9eaaaa9b16aba4f099d434e927e7e5
Files Diff
- Added: 3
- Removed: 5
- Renamed: 0
- Modified: 49
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type codecFactory : DirectCodecFactory to codecFactory : CodecFactory in method public ParquetRecordReader(fragmentContext FragmentContext, path String, rowGroupIndex int, fs FileSystem, codecFactory CodecFactory, footer ParquetMetadata, columns List<SchemaPath>) in class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader | From | To | |
| Change Parameter Type codecFactory : DirectCodecFactory to codecFactory : CodecFactory in method public ParquetRecordReader(fragmentContext FragmentContext, batchSize long, path String, rowGroupIndex int, fs FileSystem, codecFactory CodecFactory, footer ParquetMetadata, columns List<SchemaPath>) in class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader | From | To | |
| Change Parameter Type codecFactory : DirectCodecFactory to codecFactory : CodecFactory in method public ColumnChunkIncReadStore(rowCount long, codecFactory CodecFactory, allocator BufferAllocator, fs FileSystem, path Path) in class org.apache.parquet.hadoop.ColumnChunkIncReadStore | From | To | |
| Rename Variable | 1 | ||
| Rename Variable uncompressedData : DrillBuf to dictionaryData : DrillBuf in method private readDictionaryPage(pageHeader PageHeader, parentStatus ColumnReader<?>) : void in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Change Return Type | 2 | ||
| Change Return Type parquet.schema.Type to Type in method private getType(field MaterializedField) : Type in class org.apache.drill.exec.store.parquet.ParquetRecordWriter | From | To | |
| Change Return Type DirectCodecFactory to CodecFactory in method public getCodecFactory() : CodecFactory in class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader | From | To | |
| Move Class | 2 | ||
| Move Class parquet.hadoop.ColumnChunkIncReadStore moved to org.apache.parquet.hadoop.ColumnChunkIncReadStore | From | To | |
| Move Class parquet.hadoop.ColumnChunkPageWriteStoreExposer moved to org.apache.parquet.hadoop.ColumnChunkPageWriteStoreExposer | From | To | |
| Extract Variable | 1 | ||
| Extract Variable uncompressedSize : int in method private readDictionaryPage(pageHeader PageHeader, parentStatus ColumnReader<?>) : void from class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Extract Method | 4 | ||
| Extract Method public readPage(compressedSize int, uncompressedSize int, dest DrillBuf) : void extracted from public next() : boolean in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Extract Method private readDictionaryPage(pageHeader PageHeader, parentStatus ColumnReader<?>) : void extracted from public next() : boolean in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Extract Method public readPage(compressedSize int, uncompressedSize int, dest DrillBuf) : void extracted from private loadDictionaryIfExists(parentStatus ColumnReader<?>, columnChunkMetaData ColumnChunkMetaData, f FSDataInputStream) : void in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Extract Method private readDictionaryPage(pageHeader PageHeader, parentStatus ColumnReader<?>) : void extracted from private loadDictionaryIfExists(parentStatus ColumnReader<?>, columnChunkMetaData ColumnChunkMetaData, f FSDataInputStream) : void in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type recordReader : parquet.io.RecordReader<Void> to recordReader : RecordReader<Void> in class org.apache.drill.exec.store.parquet2.DrillParquetReader | From | To | |
| Change Attribute Type codecFactory : DirectCodecFactory to codecFactory : CodecFactory in class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader | From | To | |
| Change Attribute Type codecFactory : DirectCodecFactory to codecFactory : CodecFactory in class org.apache.drill.exec.store.parquet.ParquetRecordWriter | From | To | |
| Change Attribute Type codecFactory : DirectCodecFactory to codecFactory : CodecFactory in class org.apache.parquet.hadoop.ColumnChunkIncReadStore | From | To | |
| Change Attribute Type codecFactory : DirectCodecFactory to codecFactory : CodecFactory in class org.apache.drill.exec.store.parquet.columnreaders.PageReader | From | To |