3bccec9110c7ff86fa3cf04baa81a1747e1f5b9e
Files Diff
- Added: 30
- Removed: 8
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private setupAddRecords(cg ClassGenerator<WindowFramer>, valueExprs LogicalExpression[]) : void renamed to private setupOutputAggregatedValues(cg ClassGenerator<WindowFramer>, valueExprs List<LogicalExpression>) : void in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Change Parameter Type | 6 | ||
| Change Parameter Type container : VectorAccessible to container : VectorContainer in method public setup(batches List<WindowDataBatch>, container VectorContainer) : void in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Parameter Type valueExprs : LogicalExpression[] to valueExprs : List<LogicalExpression> in method private setupOutputAggregatedValues(cg ClassGenerator<WindowFramer>, valueExprs List<LogicalExpression>) : void in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Change Parameter Type container : VectorAccessible to container : VectorContainer in method public setup(batches List<WindowDataBatch>, container VectorContainer) : void in class org.apache.drill.exec.physical.impl.window.WindowFramer | From | To | |
| Change Parameter Type batches : List<RecordBatchData> to batches : List<WindowDataBatch> in method public setup(batches List<WindowDataBatch>, container VectorContainer) : void in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Parameter Type exprs : LogicalExpression[] to exprs : List<LogicalExpression> in method private setupIsFunction(cg ClassGenerator<WindowFramer>, exprs List<LogicalExpression>, leftMapping MappingSet, rightMapping MappingSet) : void in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Change Parameter Type batches : List<RecordBatchData> to batches : List<WindowDataBatch> in method public setup(batches List<WindowDataBatch>, container VectorContainer) : void in class org.apache.drill.exec.physical.impl.window.WindowFramer | From | To | |
| Rename Variable | 1 | ||
| Rename Variable cont : VectorAccessible to recordCount : int in method private computePartitionSize(start int) : int in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.drill.exec.physical.impl.window.WindowFrameTemplate renamed to org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type batch : RecordBatchData to batch : WindowDataBatch in method private computePartitionSize(start int) : int in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Variable Type cont : VectorAccessible to recordCount : int in method private computePartitionSize(start int) : int in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Extract Variable | 1 | ||
| Extract Variable MSORT_BATCH_MAXSIZE : int in method public setup(context FragmentContext, allocator BufferAllocator, vector4 SelectionVector4, hyperBatch VectorContainer) : void from class org.apache.drill.exec.physical.impl.xsort.MSortTemplate | From | To | |
| Extract Method | 3 | ||
| Extract Method private cleanup() : void extracted from public close() : void in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Extract Method private cleanup() : void extracted from public innerNext() : IterOutcome in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Extract Method private allocateOutgoing() : void extracted from public doWork() : void in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type container : VectorAccessible to container : VectorContainer in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Attribute Type batches : List<RecordBatchData> to batches : List<WindowDataBatch> in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Attribute Type partition : Interval to partition : Partition in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Attribute Type batches : List<RecordBatchData> to batches : List<WindowDataBatch> in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To |