527f1fd2452fdb3fd30c0cc154222a099e352f93
Files Diff
- Added: 10
- Removed: 0
- Renamed: 0
- Modified: 32
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method public testDecimalPartitionPruning() : void from class org.apache.drill.exec.store.parquet.TestParquetMetadataCache to public testDecimalPruningWithNullPartition() : void from class org.apache.drill.exec.store.parquet.TestPushDownAndPruningForDecimal | From | To | |
| Move And Rename Method private getStat(min Object, max Object, numNulls long, primitiveType PrimitiveType.PrimitiveTypeName, originalType OriginalType, scale int, precision int) : ColumnStatistics from class org.apache.drill.exec.store.parquet.stat.ParquetMetaStatCollector to package build() : ColumnStatistics from class org.apache.drill.exec.store.parquet.stat.ParquetMetaStatCollector.ColumnStatisticsBuilder | From | To | |
| Change Parameter Type | 6 | ||
| Change Parameter Type formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public readMetadataDirs(fs FileSystem, path Path, metaContext MetadataContext, readerConfig ParquetReaderConfig) : ParquetTableMetadataDirs in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Change Parameter Type formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public readBlockMeta(fs FileSystem, path Path, metaContext MetadataContext, readerConfig ParquetReaderConfig) : ParquetTableMetadataBase in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Change Parameter Type formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public getParquetTableMetadata(fileStatusMap Map<FileStatus,FileSystem>, readerConfig ParquetReaderConfig) : ParquetTableMetadata_v3 in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Change Parameter Type formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public getParquetTableMetadata(fs FileSystem, path String, readerConfig ParquetReaderConfig) : ParquetTableMetadata_v3 in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Change Parameter Type formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public createMeta(fs FileSystem, path String, readerConfig ParquetReaderConfig) : void in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Change Parameter Type formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method private Metadata(readerConfig ParquetReaderConfig) in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Move Method | 1 | ||
| Move Method private convertToDrillDateValue(dateValue int) : long from class org.apache.drill.exec.store.parquet.stat.ParquetMetaStatCollector to private convertToDrillDateValue(dateValue int) : long from class org.apache.drill.exec.store.parquet.stat.ParquetMetaStatCollector.ColumnStatisticsBuilder | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private ENABLE_TIME_READ_COUNTER : String from class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator to public ENABLE_TIME_READ_COUNTER : String from class org.apache.drill.exec.store.parquet.ParquetReaderConfig | From | To | |
| Move Attribute private ENABLE_BYTES_TOTAL_COUNTER : String from class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator to public ENABLE_BYTES_TOTAL_COUNTER : String from class org.apache.drill.exec.store.parquet.ParquetReaderConfig | From | To | |
| Move Attribute private ENABLE_BYTES_READ_COUNTER : String from class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator to public ENABLE_BYTES_READ_COUNTER : String from class org.apache.drill.exec.store.parquet.ParquetReaderConfig | From | To | |
| Move Attribute private formatConfig : ParquetFormatConfig from class org.apache.drill.exec.store.parquet.metadata.Metadata to private formatConfig : ParquetFormatConfig from class org.apache.drill.exec.store.parquet.ParquetReaderConfig.Builder | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.drill.exec.store.parquet.ParquetReaderConfig from class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator | From | To | |
| Extract Variable | 1 | ||
| Extract Variable minBytes : byte[] in method private setMinMaxValues(columnMetadata ColumnMetadata, rowCount long, allowBinaryMetadata boolean, needsDecoding boolean) : void from class org.apache.drill.exec.store.parquet.ParquetReaderUtility | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type autoCorrectCorruptDates : boolean to readerConfig : ParquetReaderConfig in method protected getBatch(context ExecutorFragmentContext, rowGroupScan AbstractParquetRowGroupScan, oContext OperatorContext) : ScanBatch in class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator | From | To | |
| Extract Method | 2 | ||
| Extract Method public getGroupScan(userName String, selection FileSelection, columns List<SchemaPath>, options OptionManager) : AbstractFileGroupScan extracted from public getGroupScan(userName String, selection FileSelection, columns List<SchemaPath>) : AbstractFileGroupScan in class org.apache.drill.exec.store.parquet.ParquetFormatPlugin | From | To | |
| Extract Method public getPhysicalScan(userName String, selection JSONOptions, columns List<SchemaPath>, options SessionOptionManager) : AbstractGroupScan extracted from public getPhysicalScan(userName String, selection JSONOptions, columns List<SchemaPath>) : AbstractGroupScan in class org.apache.drill.exec.store.dfs.FileSystemPlugin | From | To | |
| Rename Method | 2 | ||
| Rename Method public correctBinaryInMetadataCache(parquetTableMetadata ParquetTableMetadataBase) : void renamed to public transformBinaryInMetadataCache(parquetTableMetadata ParquetTableMetadataBase, readerConfig ParquetReaderConfig) : void in class org.apache.drill.exec.store.parquet.ParquetReaderUtility | From | To | |
| Rename Method private convertMinMaxValues(columnMetadata ColumnMetadata, rowCount long) : void renamed to private setMinMaxValues(columnMetadata ColumnMetadata, rowCount long, allowBinaryMetadata boolean, needsDecoding boolean) : void in class org.apache.drill.exec.store.parquet.ParquetReaderUtility | From | To | |
| Rename Variable | 2 | ||
| Rename Variable autoCorrectCorruptDates : boolean to readerConfig : ParquetReaderConfig in method protected getBatch(context ExecutorFragmentContext, rowGroupScan AbstractParquetRowGroupScan, oContext OperatorContext) : ScanBatch in class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator | From | To | |
| Rename Variable qualifedPred : RexNode to qualifiedPred : RexNode in method protected doOnMatch(call RelOptRuleCall, filter FilterPrel, project ProjectPrel, scan ScanPrel) : void in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method protected initInternal() : void in class org.apache.drill.exec.store.hive.HiveDrillNativeParquetScan | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public getParquetTableMetadata(fs FileSystem, path String, readerConfig ParquetReaderConfig) : ParquetTableMetadata_v3 in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Rename Parameter formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public createMeta(fs FileSystem, path String, readerConfig ParquetReaderConfig) : void in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Rename Parameter formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method private Metadata(readerConfig ParquetReaderConfig) in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Rename Parameter formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public readMetadataDirs(fs FileSystem, path Path, metaContext MetadataContext, readerConfig ParquetReaderConfig) : ParquetTableMetadataDirs in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Rename Parameter formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public readBlockMeta(fs FileSystem, path Path, metaContext MetadataContext, readerConfig ParquetReaderConfig) : ParquetTableMetadataBase in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To | |
| Rename Parameter formatConfig : ParquetFormatConfig to readerConfig : ParquetReaderConfig in method public getParquetTableMetadata(fileStatusMap Map<FileStatus,FileSystem>, readerConfig ParquetReaderConfig) : ParquetTableMetadata_v3 in class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To |