drill 59aae348478d242d9e08c46df609e94c5436e63f

59aae348478d242d9e08c46df609e94c5436e63f

Files Diff

Added: 12
Removed: 0
Renamed: 0
Modified: 58

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	1
Move And Inline Method public getDestinations() : List<DrillbitEndpoint> moved from class org.apache.drill.exec.physical.config.BroadcastSender to class org.apache.drill.exec.physical.impl.broadcastsender.BroadcastSenderRootExec & inlined to public BroadcastSenderRootExec(context FragmentContext, incoming RecordBatch, config BroadcastSender)	From	To
Change Parameter Type	8
Change Parameter Type destinations : List<DrillbitEndpoint> to destinations : List<MinorFragmentEndpoint> in method public BroadcastSender(oppositeMajorFragmentId int, child PhysicalOperator, destinations List<MinorFragmentEndpoint>) in class org.apache.drill.exec.physical.config.BroadcastSender	From	To
Change Parameter Type affinity : float to affinity : double in method public EndpointAffinity(endpoint DrillbitEndpoint, affinity double) in class org.apache.drill.exec.physical.EndpointAffinity	From	To
Change Parameter Type endpoints : List<DrillbitEndpoint> to endpoints : List<MinorFragmentEndpoint> in method public HashPartitionSender(oppositeMajorFragmentId int, child PhysicalOperator, expr LogicalExpression, endpoints List<MinorFragmentEndpoint>) in class org.apache.drill.exec.physical.config.HashPartitionSender	From	To
Change Parameter Type senderLocations : List<CoordinationProtos.DrillbitEndpoint> to receiverLocations : List<DrillbitEndpoint> in method protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void in class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Change Parameter Type senders : List<DrillbitEndpoint> to senders : List<MinorFragmentEndpoint> in method public MergingReceiverPOP(oppositeMajorFragmentId int, senders List<MinorFragmentEndpoint>, orderings List<Ordering>) in class org.apache.drill.exec.physical.config.MergingReceiverPOP	From	To
Change Parameter Type senders : List<DrillbitEndpoint> to senders : List<MinorFragmentEndpoint> in method public UnorderedReceiver(oppositeMajorFragmentId int, senders List<MinorFragmentEndpoint>) in class org.apache.drill.exec.physical.config.UnorderedReceiver	From	To
Change Parameter Type endpoints : List<DrillbitEndpoint> to endpoints : List<MinorFragmentEndpoint> in method public OrderedPartitionSender(orderings List<Ordering>, ref FieldReference, child PhysicalOperator, endpoints List<MinorFragmentEndpoint>, oppositeMajorFragmentId int, sendingWidth int, recordsToSample int, samplingFactor int, completionFactor float) in class org.apache.drill.exec.physical.config.OrderedPartitionSender	From	To
Change Parameter Type receiverLocations : List<CoordinationProtos.DrillbitEndpoint> to senderLocations : List<DrillbitEndpoint> in method protected setupSenders(senderLocations List<DrillbitEndpoint>) : void in class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Move Method	4
Move Method public getMaxWidth() : int from class org.apache.drill.exec.planner.fragment.Stats to public getMaxWidth() : int from class org.apache.drill.exec.planner.fragment.ParallelizationInfo	From	To
Move Method public visitGroupScan(groupScan GroupScan, wrapper Wrapper) : Void from class org.apache.drill.exec.planner.fragment.StatsCollector.OpStatsCollector to public visitGroupScan(groupScan GroupScan, wrapper Wrapper) : Void from class org.apache.drill.exec.planner.fragment.StatsCollector	From	To
Move Method public visitStore(store Store, wrapper Wrapper) : Void from class org.apache.drill.exec.planner.fragment.StatsCollector.OpStatsCollector to public visitStore(store Store, wrapper Wrapper) : Void from class org.apache.drill.exec.planner.fragment.StatsCollector	From	To
Move Method public visitOp(op PhysicalOperator, wrapper Wrapper) : Void from class org.apache.drill.exec.planner.fragment.StatsCollector.OpStatsCollector to public visitOp(op PhysicalOperator, wrapper Wrapper) : Void from class org.apache.drill.exec.planner.fragment.StatsCollector	From	To
Pull Up Attribute	9
Pull Up Attribute private receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.HashToRandomExchange to protected receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.OrderedPartitionExchange to protected receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.OrderedPartitionExchange to protected senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.BroadcastExchange to protected senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.BroadcastExchange to protected receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.HashToRandomExchange to protected senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.UnionExchange to protected senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.HashToMergeExchange to protected receiverLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Attribute private senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.config.HashToMergeExchange to protected senderLocations : List<DrillbitEndpoint> from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Move Attribute	1
Move Attribute private maxWidth : int from class org.apache.drill.exec.planner.fragment.Stats to private maxWidth : int from class org.apache.drill.exec.planner.fragment.ParallelizationInfo.ParallelizationInfoCollector	From	To
Extract Class	1
Extract Class org.apache.drill.exec.planner.fragment.ParallelizationInfo.ParallelizationInfoCollector from class org.apache.drill.exec.planner.fragment.Stats	From	To
Merge Variable	1
Merge Variable [fieldId : int, endpoint : DrillbitEndpoint] to destination : MinorFragmentEndpoint in method public setup(context FragmentContext, incoming RecordBatch, popConfig HashPartitionSender, stats OperatorStats, sendingAccountor SendingAccountor, oContext OperatorContext, statusHandler StatusHandler) : void in class org.apache.drill.exec.physical.impl.partitionsender.PartitionerTemplate	From	To
Move And Rename Attribute	1
Move And Rename Attribute private endpoints : List<DrillbitEndpoint> renamed to protected destinations : List<MinorFragmentEndpoint> and moved from class org.apache.drill.exec.physical.config.HashPartitionSender to class org.apache.drill.exec.physical.base.AbstractSender	From	To
Extract Variable	1
Extract Variable optionManager : OptionManager in method public SimpleParallelizer(context QueryContext) from class org.apache.drill.exec.planner.fragment.SimpleParallelizer	From	To
Change Variable Type	2
Change Variable Type destinations : List<DrillbitEndpoint> to destinations : List<MinorFragmentEndpoint> in method public BroadcastSenderRootExec(context FragmentContext, incoming RecordBatch, config BroadcastSender) in class org.apache.drill.exec.physical.impl.broadcastsender.BroadcastSenderRootExec	From	To
Change Variable Type endpoint : DrillbitEndpoint to destination : MinorFragmentEndpoint in method public sendEmptyBatch(isLast boolean) : void in class org.apache.drill.exec.physical.impl.partitionsender.PartitionSenderRootExec	From	To
Extract Method	1
Extract Method public getRootFragmentFromPlanString(reader PhysicalPlanReader, planString String) : Fragment extracted from public getRootFragment(reader PhysicalPlanReader, file String) : Fragment in class org.apache.drill.exec.pop.PopUnitTestBase	From	To
Pull Up Method	15
Pull Up Method public getNumSenders() : int from class org.apache.drill.exec.physical.config.MergingReceiverPOP to public getNumSenders() : int from class org.apache.drill.exec.physical.base.AbstractReceiver	From	To
Pull Up Method protected setupSenders(senderLocations List<CoordinationProtos.DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.SingleMergeExchange to protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.store.mock.MockGroupScanPOP to public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.physical.base.AbstractGroupScan	From	To
Pull Up Method protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.OrderedPartitionExchange to protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.OrderedPartitionExchange to protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.BroadcastExchange to protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.HashToRandomExchange to protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.store.sys.SystemTableScan to public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.physical.base.AbstractGroupScan	From	To
Pull Up Method public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.store.ischema.InfoSchemaGroupScan to public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.physical.base.AbstractGroupScan	From	To
Pull Up Method public getNumSenders() : int from class org.apache.drill.exec.physical.config.UnorderedReceiver to public getNumSenders() : int from class org.apache.drill.exec.physical.base.AbstractReceiver	From	To
Pull Up Method protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.HashToRandomExchange to protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.HashToMergeExchange to protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.HashToMergeExchange to protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Pull Up Method public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.store.direct.DirectGroupScan to public getOperatorAffinity() : List<EndpointAffinity> from class org.apache.drill.exec.physical.base.AbstractGroupScan	From	To
Pull Up Method protected setupReceivers(receiverLocations List<CoordinationProtos.DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.config.BroadcastExchange to protected setupSenders(senderLocations List<DrillbitEndpoint>) : void from class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Rename Variable	1
Rename Variable endpoint : DrillbitEndpoint to destination : MinorFragmentEndpoint in method public sendEmptyBatch(isLast boolean) : void in class org.apache.drill.exec.physical.impl.partitionsender.PartitionSenderRootExec	From	To
Change Return Type	4
Change Return Type List<DrillbitEndpoint> to List<MinorFragmentEndpoint> in method public abstract getDestinations() : List<MinorFragmentEndpoint> in class org.apache.drill.exec.physical.base.Sender	From	To
Change Return Type List<DrillbitEndpoint> to List<MinorFragmentEndpoint> in method public getDestinations() : List<MinorFragmentEndpoint> in class org.apache.drill.exec.physical.config.SingleSender	From	To
Change Return Type float to double in method public getAffinity() : double in class org.apache.drill.exec.physical.EndpointAffinity	From	To
Change Return Type List<DrillbitEndpoint> to List<MinorFragmentEndpoint> in method public abstract getProvidingEndpoints() : List<MinorFragmentEndpoint> in class org.apache.drill.exec.physical.base.Receiver	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute opposite : FragmentHandle to oppositeHandle : FragmentHandle in method public SingleSenderRootExec(context FragmentContext, batch RecordBatch, config SingleSender) in class org.apache.drill.exec.physical.impl.SingleSenderCreator.SingleSenderRootExec	From	To
Rename Attribute	1
Rename Attribute bit : Drillbit to bits : Drillbit[] in class org.apache.drill.BaseTestQuery	From	To
Change Attribute Type	4
Change Attribute Type sendingExchange : Exchange to sendingExchange : ExchangeFragmentPair in class org.apache.drill.exec.planner.fragment.Fragment	From	To
Change Attribute Type bit : Drillbit to bits : Drillbit[] in class org.apache.drill.BaseTestQuery	From	To
Change Attribute Type affinity : float to affinity : double in class org.apache.drill.exec.physical.EndpointAffinity	From	To
Change Attribute Type incoming : List<DrillbitEndpoint> to incoming : List<MinorFragmentEndpoint> in class org.apache.drill.exec.work.batch.AbstractDataCollector	From	To
Extract And Move Method	1
Extract And Move Method public getDestinations() : List<MinorFragmentEndpoint> extracted from public getDestination() : DrillbitEndpoint in class org.apache.drill.exec.physical.config.SingleSender & moved to class org.apache.drill.exec.physical.base.AbstractSender	From	To
Rename Parameter	10
Rename Parameter receiverLocations : List<CoordinationProtos.DrillbitEndpoint> to senderLocations : List<DrillbitEndpoint> in method protected setupSenders(senderLocations List<DrillbitEndpoint>) : void in class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Rename Parameter senderLocations : List<CoordinationProtos.DrillbitEndpoint> to receiverLocations : List<DrillbitEndpoint> in method protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void in class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Rename Parameter exepectedFragmentCount : int to expectedFragmentCount : int in method private print(fragmentFile String, bitCount int, expectedFragmentCount int) : void in class org.apache.drill.exec.pop.TestFragmentChecker	From	To
Rename Parameter senderLocations : List<DrillbitEndpoint> to receiverLocations : List<DrillbitEndpoint> in method protected setupReceivers(receiverLocations List<DrillbitEndpoint>) : void in class org.apache.drill.exec.physical.base.AbstractExchange	From	To
Rename Parameter receiverLocations : List<DrillbitEndpoint> to senderLocations : List<DrillbitEndpoint> in method protected setupSenders(senderLocations List<DrillbitEndpoint>) : void in class org.apache.drill.exec.physical.base.AbstractExchange	From	To

59aae348478d242d9e08c46df609e94c5436e63f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: