6cc89e99c7f557ffb04f16c0857d3b03a744fad4
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 22
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 3 | ||
| Move Method private searchSchemaTree(schema SchemaPlus, schemaPath List<String>) : SchemaPlus from class org.apache.drill.exec.planner.sql.handlers.AbstractSqlHandler to private searchSchemaTree(schema SchemaPlus, schemaPath List<String>) : SchemaPlus from class org.apache.drill.exec.planner.sql.SchemaUtilites | From | To | |
| Move Method public isRootSchema(schema SchemaPlus) : boolean from class org.apache.drill.exec.planner.sql.handlers.AbstractSqlHandler to public isRootSchema(schema SchemaPlus) : boolean from class org.apache.drill.exec.planner.sql.SchemaUtilites | From | To | |
| Move Method public findSchema(rootSchema SchemaPlus, defaultSchema SchemaPlus, schemaPath List<String>) : SchemaPlus from class org.apache.drill.exec.planner.sql.handlers.AbstractSqlHandler to public findSchema(defaultSchema SchemaPlus, schemaPath List<String>) : SchemaPlus from class org.apache.drill.exec.planner.sql.SchemaUtilites | From | To | |
| Rename Variable | 2 | ||
| Rename Variable schema : WorkspaceSchema to wsSchema : WorkspaceSchema in method public getPlan(sqlNode SqlNode) : PhysicalPlan in class org.apache.drill.exec.planner.sql.handlers.ShowFileHandler | From | To | |
| Rename Variable defaultSchema : String to newDefaultSchemaPath : String in method public getPlan(sqlNode SqlNode) : PhysicalPlan in class org.apache.drill.exec.planner.sql.handlers.UseSchemaHandler | From | To | |
| Change Return Type | 1 | ||
| Change Return Type boolean to void in method public setDefaultSchemaPath(newDefaultSchemaPath String, currentDefaultSchema SchemaPlus) : void in class org.apache.drill.exec.rpc.user.UserSession | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private TEMP_SCHEMA : String from class org.apache.drill.exec.sql.TestViewSupport to protected TEMP_SCHEMA : String from class org.apache.drill.BaseTestQuery | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.drill.exec.planner.sql.SchemaUtilites from class org.apache.drill.exec.planner.sql.handlers.AbstractSqlHandler | From | To | |
| Extract Variable | 1 | ||
| Extract Variable newViewName : String in method public getPlan(sqlNode SqlNode) : PhysicalPlan from class org.apache.drill.exec.planner.sql.handlers.ViewHandler.CreateView | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter fullPath : String to newDefaultSchemaPath : String in method public setDefaultSchemaPath(newDefaultSchemaPath String, currentDefaultSchema SchemaPlus) : void in class org.apache.drill.exec.rpc.user.UserSession | From | To | |
| Rename Parameter schema : SchemaPlus to currentDefaultSchema : SchemaPlus in method public setDefaultSchemaPath(newDefaultSchemaPath String, currentDefaultSchema SchemaPlus) : void in class org.apache.drill.exec.rpc.user.UserSession | From | To | |
| Rename Parameter errorMsg : String to expErrorMsg : String in method private ctasErrorTestHelper(ctasSql String, expErrorMsg String) : void in class org.apache.drill.exec.sql.TestCTAS | From | To | |
| Rename Parameter errorMsg : String to expErrorMsg : String in method private createViewErrorTestHelper(viewSql String, expErrorMsg String) : void in class org.apache.drill.exec.sql.TestViewSupport | From | To |