7a25d9d86b9324dc4c3121a51e3d964bdb7b0284
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Replace Attribute | 1 | ||
Replace Attribute private query_v_student_u1g1_750 : String from class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization with protected hivePluginName : String from class org.apache.drill.exec.impersonation.hive.BaseTestHiveImpersonation | From | To | |
Rename Method | 22 | ||
Rename Method public showTables_user0() : void renamed to public user0_showTables() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public select_user0_2() : void renamed to public user0_forbidden_g_voter_role0() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public selectUser1_db_general() : void renamed to public user1_allowed_g_voter_all_755() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public select_user1_2() : void renamed to public user1_allowed_g_voter_role0() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public select_user1_1() : void renamed to public user1_forbidden_g_student_user0() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public select_user2_1() : void renamed to public user2_allowed_g_voter_role0() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public select_user0_1() : void renamed to public user0_allowed_g_student_user0() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public selectUser0_db_general() : void renamed to public user0_allowed_g_voter_all_755() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public selectUser0_v_partitioned_student_u1g1_750() : void renamed to public user0_forbidden_g_voter_u1_700() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public selectUser0_db_u1g1_only() : void renamed to public user0_forbidden_g_voter_u2g1_750() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public select_user2_2() : void renamed to public user2_allowed_g_student_user2() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public selectUser1_db_u0_only() : void renamed to public user1_forbidden_g_student_u0_700() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public selectUser2_v_partitioned_student_u0g0_750() : void renamed to public user2_forbidden_g_student_u0_700() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public selectUser2_v_student_u0g0_750() : void renamed to public user1_allowed_vw_voter_role0_but_forbidden_vw_student_user2() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public showTables_user1() : void renamed to public user1_showTables() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public selectUser0_v_student_u1g1_750() : void renamed to public user0_forbidden_u1g1_student_all_755() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public select_user2_3() : void renamed to public user2_allowed_g_voter_role0_and_g_student_user2() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public selectUser0_v_student_u1g1_750() : void renamed to private queryHiveViewNotAuthorized(usr String, viewName String) : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method private queryViewHelper(queryUser String, query String) : void renamed to private queryHiveView(usr String, viewName String) : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Method public selectUser2_v_student_u0g0_750() : void renamed to public user2_forbidden_g_student_u0g0_750() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public selectUser0_db_u0_only() : void renamed to public user0_allowed_g_student_u0_700() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Rename Method public select_user1_3() : void renamed to public user1_allowed_g_voter_role0_but_forbidden_g_student_user2() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Pull Up Method | 2 | ||
Pull Up Method private createTbl(driver Driver, db String, tbl String, tblDef String, data String) : void from class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization to package createTable(driver Driver, db String, tbl String, tblDef String, data String) : void from class org.apache.drill.exec.impersonation.hive.BaseTestHiveImpersonation | From | To | |
Pull Up Method private createTable(hiveDriver Driver, db String, tbl String, tblDef String, tblData String, user String, group String, permissions short) : void from class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization to package setStoragePermissions(db String, tbl String, user String, group String, permissions short) : void from class org.apache.drill.exec.impersonation.hive.BaseTestHiveImpersonation | From | To | |
Move And Rename Method | 1 | ||
Move And Rename Method private getRelDataTypeFromHivePrimitiveType(typeFactory RelDataTypeFactory, pTypeInfo PrimitiveTypeInfo) : RelDataType from class org.apache.drill.exec.store.hive.schema.DrillHiveTable to private getRelDataType(primitiveTypeInfo PrimitiveTypeInfo) : RelDataType from class org.apache.drill.exec.planner.types.HiveToRelDataTypeConverter | From | To | |
Rename Variable | 1 | ||
Rename Variable fieldNameList : List<String> to fieldNames : List<String> in method public getRowType(typeFactory RelDataTypeFactory) : RelDataType in class org.apache.drill.exec.store.hive.schema.DrillHiveTable | From | To | |
Change Return Type | 1 | ||
Change Return Type DrillTable to Table in method package getDrillTable(dbName String, t String) : Table in class org.apache.drill.exec.store.hive.schema.HiveSchemaFactory.HiveSchema | From | To | |
Extract Attribute | 3 | ||
Extract Attribute private _755 : short in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Attribute private _700 : short in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Attribute private _750 : short in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Replace Variable With Attribute | 1 | ||
Replace Variable With Attribute pluginName : String to hivePluginName : String in method protected fromInfoSchemaHelper(db String, expectedTables List<String>, expectedTableTypes List<TableType>) : void in class org.apache.drill.exec.impersonation.hive.BaseTestHiveImpersonation | From | To | |
Extract Method | 12 | ||
Extract Method private queryTableNotFound(db String, table String) : void extracted from public selectUser0_db_u1g1_only() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method protected expandViewForImpersonatedUser(context ToRelContext, rowType RelDataType, workspaceSchemaPath List<String>, tokenSchemaTree SchemaPlus) : RelNode extracted from public toRel(context ToRelContext, relOptTable RelOptTable) : RelNode in class org.apache.drill.exec.planner.logical.DrillViewTable | From | To | |
Extract Method private queryHiveTableOrView(db String, table String) : void extracted from public selectUser0_db_u0_only() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private queryTableNotFound(db String, table String) : void extracted from public selectUser1_db_u0_only() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private queryTableNotFound(db String, table String) : void extracted from public selectUser2_v_partitioned_student_u0g0_750() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private queryTableNotFound(db String, table String) : void extracted from public selectUser0_v_partitioned_student_u1g1_750() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private queryHiveTableOrView(db String, table String) : void extracted from public selectUser0_db_general() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private queryHiveTableOrView(db String, table String) : void extracted from public selectUser1_db_general() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private queryTableNotFound(db String, table String) : void extracted from public selectUser0_v_student_u1g1_750() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private queryTableNotFound(db String, table String) : void extracted from public selectUser2_v_student_u0g0_750() : void in class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract Method private getUser(impersonated String, notImpersonated String) : String extracted from package getDrillTable(dbName String, t String) : DrillTable in class org.apache.drill.exec.store.hive.schema.HiveSchemaFactory.HiveSchema | From | To | |
Extract And Move Method | 2 | ||
Extract And Move Method private createHiveView(driver Driver, db String, viewName String, tableName String) : void extracted from private generateTestData() : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization & moved to class org.apache.drill.exec.impersonation.hive.TestStorageBasedHiveAuthorization | From | To | |
Extract And Move Method public closeSilently(closeables AutoCloseable...) : void extracted from public close() : void in class org.apache.drill.exec.store.hive.schema.HiveSchemaFactory & moved to class org.apache.drill.common.AutoCloseables | From | To | |
Rename Parameter | 3 | ||
Rename Parameter pTypeInfo : PrimitiveTypeInfo to primitiveTypeInfo : PrimitiveTypeInfo in method private getRelDataType(primitiveTypeInfo PrimitiveTypeInfo) : RelDataType in class org.apache.drill.exec.planner.types.HiveToRelDataTypeConverter | From | To | |
Rename Parameter query : String to viewName : String in method private queryHiveView(usr String, viewName String) : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To | |
Rename Parameter queryUser : String to usr : String in method private queryHiveView(usr String, viewName String) : void in class org.apache.drill.exec.impersonation.hive.TestSqlStdBasedAuthorization | From | To |