7afeb8e2968ad6af4fbb58238454878ec140eab8
Files Diff
- Added: 11
- Removed: 5
- Renamed: 0
- Modified: 24
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 5 | ||
| Change Parameter Type childWriter : AbstractObjectWriter to childWriter : WriterPosition in method public OffsetVectorState(writer WriterPosition, mainVector ValueVector, childWriter WriterPosition) in class org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.OffsetVectorState | From | To | |
| Change Parameter Type resultSetLoader : ResultSetLoaderImpl to loader : LoaderInternals in method public ColumnState(loader LoaderInternals, writer AbstractObjectWriter, vectorState VectorState) in class org.apache.drill.exec.physical.rowSet.impl.ColumnState | From | To | |
| Change Parameter Type writer : AbstractObjectWriter to writer : ArrayWriter in method public RepeatedVectorState(writer ArrayWriter, vector RepeatedValueVector) in class org.apache.drill.exec.physical.rowSet.impl.RepeatedVectorState | From | To | |
| Change Parameter Type writer : AbstractScalarWriter to writer : WriterPosition in method public FixedWidthVectorState(writer WriterPosition, mainVector ValueVector) in class org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.FixedWidthVectorState | From | To | |
| Change Parameter Type resultSetLoader : ResultSetLoaderImpl to loader : LoaderInternals in method public PrimitiveColumnState(loader LoaderInternals, colWriter AbstractObjectWriter, vectorState VectorState) in class org.apache.drill.exec.physical.rowSet.impl.ColumnState.PrimitiveColumnState | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private vectorCache : ResultVectorCache from class org.apache.drill.exec.physical.rowSet.impl.ResultSetLoaderImpl to protected vectorCache : ResultVectorCache from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Move Attribute private schema : ColumnMetadata from class org.apache.drill.exec.physical.rowSet.impl.RepeatedVectorState to private schema : ColumnMetadata from class org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.VariableWidthVectorState | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.ValuesVectorState renamed to org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.SimpleVectorState | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.drill.exec.physical.rowSet.impl.NullableVectorState.BitsVectorState moved and renamed to org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.FixedWidthVectorState | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.drill.exec.physical.rowSet.impl.PrimitiveColumnState moved to org.apache.drill.exec.physical.rowSet.impl.ColumnState.PrimitiveColumnState | From | To | |
| Extract Method | 3 | ||
| Extract Method private populateMap(mapVector AbstractMapVector, mapSchema TupleMetadata, inUnion boolean) : void extracted from private buildMap(schema ColumnMetadata) : AbstractMapVector in class org.apache.drill.exec.physical.rowSet.model.single.BuildVectorsFromMetadata | From | To | |
| Extract Method public startBatch(schemaOnly boolean) : void extracted from public startBatch() : void in class org.apache.drill.exec.physical.rowSet.impl.ResultSetLoaderImpl | From | To | |
| Extract Method public makeProvider(colMetadata ColumnMetadata) : MetadataProvider extracted from public childProvider(colMetadata ColumnMetadata) : MetadataProvider in class org.apache.drill.exec.physical.rowSet.model.MetadataProvider.MetadataCreator | From | To | |
| Rename Method | 4 | ||
| Rename Method public reset() : void renamed to public close() : void in class org.apache.drill.exec.physical.rowSet.impl.SingleVectorState | From | To | |
| Rename Method public reset() : void renamed to public close() : void in class org.apache.drill.exec.physical.rowSet.impl.NullableVectorState | From | To | |
| Rename Method public reset() : void renamed to public close() : void in class org.apache.drill.exec.physical.rowSet.impl.VectorState | From | To | |
| Rename Method public reset() : void renamed to public close() : void in class org.apache.drill.exec.physical.rowSet.impl.RepeatedVectorState | From | To | |
| Pull Up Method | 7 | ||
| Pull Up Method public abstract innerCardinality() : int from class org.apache.drill.exec.physical.rowSet.impl.TupleState to public abstract innerCardinality() : int from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Pull Up Method public harvestWithLookAhead() : void from class org.apache.drill.exec.physical.rowSet.impl.TupleState to public harvestWithLookAhead() : void from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Pull Up Method public rollover() : void from class org.apache.drill.exec.physical.rowSet.impl.TupleState to public rollover() : void from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Pull Up Method public updateCardinality(cardinality int) : void from class org.apache.drill.exec.physical.rowSet.impl.TupleState to public updateCardinality() : void from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Pull Up Method public projectionType(columnName String) : ProjectionType from class org.apache.drill.exec.physical.rowSet.impl.TupleState to public projectionType(columnName String) : ProjectionType from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Pull Up Method public close() : void from class org.apache.drill.exec.physical.rowSet.impl.TupleState to public close() : void from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Pull Up Method public startBatch() : void from class org.apache.drill.exec.physical.rowSet.impl.TupleState to public startBatch(schemaOnly boolean) : void from class org.apache.drill.exec.physical.rowSet.impl.ContainerState | From | To | |
| Change Return Type | 3 | ||
| Change Return Type ValueVector to T in method public vector() : T in class org.apache.drill.exec.physical.rowSet.impl.ColumnState | From | To | |
| Change Return Type ValueVector to T in method public vector() : T in class org.apache.drill.exec.physical.rowSet.impl.NullVectorState | From | To | |
| Change Return Type ValueVector to T in method public vector() : T in class org.apache.drill.exec.physical.rowSet.impl.VectorState | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.apache.drill.exec.physical.rowSet.impl.ContainerState from classes [org.apache.drill.exec.physical.rowSet.impl.TupleState] | From | To | |
| Extract Superclass org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.SimpleVectorState from classes [org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.FixedWidthVectorState] | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute outerCardinality : int to cardinality : int in class org.apache.drill.exec.physical.rowSet.impl.ColumnState | From | To | |
| Rename Attribute resultSetLoader : ResultSetLoaderImpl to loader : LoaderInternals in class org.apache.drill.exec.physical.rowSet.impl.ColumnState | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.apache.drill.exec.physical.rowSet.impl.LoaderInternals from classes [org.apache.drill.exec.physical.rowSet.impl.ResultSetLoaderImpl] | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type childWriter : AbstractObjectWriter to childWriter : WriterPosition in class org.apache.drill.exec.physical.rowSet.impl.SingleVectorState.OffsetVectorState | From | To | |
| Change Attribute Type valuesState : ValuesVectorState to valuesState : SimpleVectorState in class org.apache.drill.exec.physical.rowSet.impl.NullableVectorState | From | To | |
| Change Attribute Type valuesState : ValuesVectorState to valuesState : SimpleVectorState in class org.apache.drill.exec.physical.rowSet.impl.RepeatedVectorState | From | To | |
| Change Attribute Type resultSetLoader : ResultSetLoaderImpl to loader : LoaderInternals in class org.apache.drill.exec.physical.rowSet.impl.ColumnState | From | To | |
| Change Attribute Type projectionSet : ProjectionSet to projectionSet : RequestedTuple in class org.apache.drill.exec.physical.rowSet.impl.ResultSetLoaderImpl | From | To | |
| Change Attribute Type bitsState : ValuesVectorState to bitsState : SimpleVectorState in class org.apache.drill.exec.physical.rowSet.impl.NullableVectorState | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter resultSetLoader : ResultSetLoaderImpl to loader : LoaderInternals in method public PrimitiveColumnState(loader LoaderInternals, colWriter AbstractObjectWriter, vectorState VectorState) in class org.apache.drill.exec.physical.rowSet.impl.ColumnState.PrimitiveColumnState | From | To | |
| Rename Parameter resultSetLoader : ResultSetLoaderImpl to loader : LoaderInternals in method public ColumnState(loader LoaderInternals, writer AbstractObjectWriter, vectorState VectorState) in class org.apache.drill.exec.physical.rowSet.impl.ColumnState | From | To |