7ea212a26dca9b5eca2719300df27751e73dbbcf
Files Diff
- Added: 12
- Removed: 0
- Renamed: 0
- Modified: 42
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Move And Inline Method | 1 | ||
Move And Inline Method public getMergedClass(set ClassSet, precompiledClass byte[], generatedClass ClassNode) : MergedClassResult moved from class org.apache.drill.exec.compile.MergeAdapter to class org.apache.drill.exec.compile.ClassTransformer & inlined to public getImplementationClass(classLoader QueryClassLoader, templateDefinition TemplateClassDefinition<?>, entireClass String, materializedClassName String) : Class<?> | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type frames : Frame<?>[] to frames : Frame<BasicValue>[] in method public TrackingInstructionList(frames Frame<BasicValue>[], inner InsnList) in class org.apache.drill.exec.compile.bytecode.TrackingInstructionList | From | To | |
Move Attribute | 6 | ||
Move Attribute package logger : org.slf4j.Logger from class org.apache.drill.exec.compile.CodeCompiler to private logger : Logger from class org.apache.drill.exec.compile.LogWriter | From | To | |
Move Attribute package isFunctionReturn : boolean from class org.apache.drill.exec.compile.bytecode.ReplacingBasicValue to package isFunctionReturn : boolean from class org.apache.drill.exec.compile.bytecode.ReplacingBasicValue.FlagSet | From | To | |
Move Attribute package logger : org.slf4j.Logger from class org.apache.drill.exec.compile.bytecode.ReplacingInterpreter to private logger : Logger from class org.apache.drill.exec.compile.LogWriter | From | To | |
Move Attribute package logger : org.slf4j.Logger from class org.apache.drill.exec.compile.bytecode.TrackingInstructionList to private logger : Logger from class org.apache.drill.exec.compile.LogWriter | From | To | |
Move Attribute package logger : org.slf4j.Logger from class org.apache.drill.exec.compile.bytecode.ReplaceMethodInvoke to private logger : Logger from class org.apache.drill.exec.compile.LogWriter | From | To | |
Move Attribute package logger : org.slf4j.Logger from class org.apache.drill.TestTpchDistributed to private logger : Logger from class org.apache.drill.exec.compile.LogWriter | From | To | |
Extract Class | 1 | ||
Extract Class org.apache.drill.exec.compile.bytecode.ReplacingBasicValue.FlagSet from class org.apache.drill.exec.compile.bytecode.ReplacingBasicValue | From | To | |
Change Variable Type | 2 | ||
Change Variable Type a : Analyzer<BasicValue> to analyzer : MethodAnalyzer<BasicValue> in method public visitEnd() : void in class org.apache.drill.exec.compile.bytecode.ScalarReplacementNode | From | To | |
Change Variable Type o : Object to basicValue : BasicValue in method private filterReplacement(basicValue BasicValue) : ReplacingBasicValue in class org.apache.drill.exec.compile.bytecode.InstructionModifier | From | To | |
Extract Variable | 4 | ||
Extract Variable methodVisitor : MethodVisitor in method public visitEnd() : void from class org.apache.drill.exec.compile.bytecode.ScalarReplacementNode | From | To | |
Extract Variable object : Object in method private getPartialValue(name String, type OptionType, literal SqlLiteral) : OptionValue from class org.apache.drill.exec.server.options.TypeValidators | From | To | |
Extract Variable typeName : SqlTypeName in method private getPartialValue(name String, type OptionType, literal SqlLiteral) : OptionValue from class org.apache.drill.exec.server.options.TypeValidators | From | To | |
Extract Variable replacingValue : ReplacingBasicValue in method private filterReplacement(basicValue BasicValue) : ReplacingBasicValue from class org.apache.drill.exec.compile.bytecode.InstructionModifier | From | To | |
Inline Variable | 1 | ||
Inline Variable t : Type in method public createLocalAndTrasfer(adder DirectSorter) : int from class org.apache.drill.exec.compile.bytecode.ValueHolderIden | From | To | |
Extract Method | 2 | ||
Extract Method private addLocals(adder DirectSorter, defaultFirst int) : int extracted from public getHolderSub(adder DirectSorter) : ValueHolderSub in class org.apache.drill.exec.compile.bytecode.ValueHolderIden | From | To | |
Extract Method private addLocals(adder DirectSorter, defaultFirst int) : int extracted from public createLocalAndTrasfer(adder DirectSorter) : int in class org.apache.drill.exec.compile.bytecode.ValueHolderIden | From | To | |
Rename Method | 4 | ||
Rename Method private dup(t Type) : int renamed to private getDupOpcode(type Type) : int in class org.apache.drill.exec.compile.bytecode.ValueHolderIden | From | To | |
Rename Method private field(name String, mv InstructionModifier) : int renamed to private getFieldIndex(name String, mv InstructionModifier) : int in class org.apache.drill.exec.compile.bytecode.ValueHolderIden.ValueHolderSub | From | To | |
Rename Method private getReturn() : ReplacingBasicValue renamed to private filterReplacement(basicValue BasicValue) : ReplacingBasicValue in class org.apache.drill.exec.compile.bytecode.InstructionModifier | From | To | |
Rename Method public createLocalAndTrasfer(adder DirectSorter) : int renamed to public createLocalAndTransfer(adder DirectSorter) : int in class org.apache.drill.exec.compile.bytecode.ValueHolderIden | From | To | |
Rename Variable | 2 | ||
Rename Variable a : Analyzer<BasicValue> to analyzer : MethodAnalyzer<BasicValue> in method public visitEnd() : void in class org.apache.drill.exec.compile.bytecode.ScalarReplacementNode | From | To | |
Rename Variable v : ReplacingBasicValue to value : ReplacingBasicValue in method public visitFieldInsn(opcode int, owner String, name String, desc String) : void in class org.apache.drill.exec.compile.bytecode.InstructionModifier | From | To | |
Change Return Type | 1 | ||
Change Return Type void to int in method public transferToExternal(adder DirectSorter, owner String, name String, desc String) : int in class org.apache.drill.exec.compile.bytecode.ValueHolderIden.ValueHolderSub | From | To | |
Replace Variable With Attribute | 1 | ||
Replace Variable With Attribute insn : AbstractInsnNode to currentInsn : AbstractInsnNode in method public accept(mv MethodVisitor) : void in class org.apache.drill.exec.compile.bytecode.TrackingInstructionList | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable o : Object to basicValue : BasicValue in method private filterReplacement(basicValue BasicValue) : ReplacingBasicValue in class org.apache.drill.exec.compile.bytecode.InstructionModifier | From | To | |
Rename Attribute | 1 | ||
Rename Attribute systemOptionManager : OptionManager to optionManager : OptionManager in class org.apache.drill.exec.compile.CodeCompiler | From | To | |
Change Attribute Type | 3 | ||
Change Attribute Type nextFrame : Frame<?> to nextFrame : Frame<BasicValue> in class org.apache.drill.exec.compile.bytecode.TrackingInstructionList | From | To | |
Change Attribute Type currentFrame : Frame<?> to currentFrame : Frame<BasicValue> in class org.apache.drill.exec.compile.bytecode.TrackingInstructionList | From | To | |
Change Attribute Type frames : Frame<?>[] to frames : Frame<BasicValue>[] in class org.apache.drill.exec.compile.bytecode.TrackingInstructionList | From | To | |
Rename Parameter | 4 | ||
Rename Parameter index : int to offset : int in method private initType(offset int, t Type, v DirectSorter) : void in class org.apache.drill.exec.compile.bytecode.ValueHolderIden | From | To | |
Rename Parameter systemOptionManager : OptionManager to optionManager : OptionManager in method public CodeCompiler(config DrillConfig, optionManager OptionManager) in class org.apache.drill.exec.compile.CodeCompiler | From | To | |
Rename Parameter type : OptionType to optionType : OptionType in method public setOption(name String, literal SqlLiteral, optionType OptionType) : void in class org.apache.drill.exec.server.options.FallbackOptionManager | From | To | |
Rename Parameter t : Type to type : Type in method private getDupOpcode(type Type) : int in class org.apache.drill.exec.compile.bytecode.ValueHolderIden | From | To |