drill 814f553f2fe58c6d2d2095fbf71158fcda424658

814f553f2fe58c6d2d2095fbf71158fcda424658

Files Diff

Added: 1
Removed: 1
Renamed: 0
Modified: 21

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private getFileName() : String renamed to private getPath() : Path in class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer	From	To
Pull Up Method	11
Pull Up Method public cleanup() : void from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to public cleanup() : void from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public finished() : void from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to private allStreamsFinished() : void from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method private clearBufferWithBody() : void from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to private clearBufferWithBody() : void from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public SpoolingRawBatchBuffer(context FragmentContext, fragmentCount int) from class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer to public BaseRawBatchBuffer(context FragmentContext, fragmentCount int) from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public kill(context FragmentContext) : void from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to public kill(context FragmentContext) : void from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public enqueue(batch RawFragmentBatch) : void from class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer to public enqueue(batch RawFragmentBatch) : void from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public UnlimitedRawBatchBuffer(context FragmentContext, fragmentCount int) from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to public BaseRawBatchBuffer(context FragmentContext, fragmentCount int) from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public getNext() : RawFragmentBatch from class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer to public getNext() : RawFragmentBatch from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public enqueue(batch RawFragmentBatch) : void from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to public enqueue(batch RawFragmentBatch) : void from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method private isFinished() : boolean from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to protected isTerminated() : boolean from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Method public getNext() : RawFragmentBatch from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to public getNext() : RawFragmentBatch from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Attribute	7
Pull Up Attribute private context : FragmentContext from class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer to protected context : FragmentContext from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Attribute private state : BufferState from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to private state : BufferState from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Attribute private outOfMemory : AtomicBoolean from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to protected outOfMemory : AtomicBoolean from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Attribute private context : FragmentContext from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to protected context : FragmentContext from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Attribute private fragmentCount : int from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to private fragmentCount : int from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Attribute private streamCounter : int from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to private streamCounter : int from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Pull Up Attribute private bufferSizePerSocket : int from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to protected bufferSizePerSocket : int from class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Change Return Type	1
Change Return Type String to Path in method private getPath() : Path in class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer	From	To
Move Attribute	2
Move Attribute private buffer : LinkedBlockingDeque<RawFragmentBatchWrapper> from class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer to private buffer : LinkedBlockingDeque<RawFragmentBatchWrapper> from class org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer.SpoolingBufferQueue	From	To
Move Attribute private buffer : LinkedBlockingDeque<RawFragmentBatch> from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer to private buffer : LinkedBlockingDeque<RawFragmentBatch> from class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer.UnlimitedBufferQueue	From	To
Move Class	1
Move Class org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer.BufferState moved to org.apache.drill.exec.work.batch.BaseRawBatchBuffer.BufferState	From	To
Extract Superclass	1
Extract Superclass org.apache.drill.exec.work.batch.BaseRawBatchBuffer from classes [org.apache.drill.exec.work.batch.SpoolingRawBatchBuffer, org.apache.drill.exec.work.batch.UnlimitedRawBatchBuffer]	From	To
Extract Method	4
Extract Method protected handleOutOfMemory(batch RawFragmentBatch) : void extracted from public enqueue(batch RawFragmentBatch) : void in class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Extract Method private decrementStreamCounter() : int extracted from public getNext() : RawFragmentBatch in class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Extract Method private completedStreams() : int extracted from public cleanup() : void in class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To
Extract Method private assertAckSent(batch RawFragmentBatch) : void extracted from public getNext() : RawFragmentBatch in class org.apache.drill.exec.work.batch.BaseRawBatchBuffer	From	To

814f553f2fe58c6d2d2095fbf71158fcda424658

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: