89f2633f612a645666de8f51dcb19c6f8044a95e
Files Diff
- Added: 33
- Removed: 1
- Renamed: 0
- Modified: 38
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method public getTempDir(dirName String) : String from class org.apache.drill.BaseTestQuery to public getTempDir(dirName String) : String from class org.apache.drill.exec.ExecTest | From | To | |
| Pull Up Method public AdminOptionValidator(name String, def String) from class org.apache.drill.exec.server.options.TypeValidators.AdminOptionValidator to public StringValidator(name String, def String, isAdminOption boolean) from class org.apache.drill.exec.server.options.TypeValidators.StringValidator | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute config : DrillConfig to c : DrillConfig in method public testHashFunctionResolution() : void in class org.apache.drill.exec.physical.impl.TestSimpleFunctions | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute drillFuncRegistry : DrillFunctionRegistry to localFunctionRegistry : LocalFunctionRegistry in class org.apache.drill.exec.expr.fn.FunctionImplementationRegistry | From | To | |
| Extract Variable | 1 | ||
| Extract Variable serializer : InstanceSerializer<V> in method public putIfAbsent(key String, value V) : V from class org.apache.drill.exec.coord.zk.ZkEphemeralStore | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type drillFuncRegistry : DrillFunctionRegistry to localFunctionRegistry : LocalFunctionRegistry in class org.apache.drill.exec.expr.fn.FunctionImplementationRegistry | From | To | |
| Extract Method | 8 | ||
| Extract Method public get(path String, consistent boolean, version DataChangeVersion) : byte[] extracted from public get(path String, consistent boolean) : byte[] in class org.apache.drill.exec.coord.zk.ZookeeperClient | From | To | |
| Extract Method public get(key String, consistencyFlag boolean, version DataChangeVersion) : V extracted from public get(key String) : V in class org.apache.drill.exec.store.sys.store.ZookeeperPersistentStore | From | To | |
| Extract Method private getPhysicalPlan(handler AbstractSqlHandler, sqlNode SqlNode, context QueryContext) : PhysicalPlan extracted from public getPlan(context QueryContext, sql String, textPlan Pointer<String>) : PhysicalPlan in class org.apache.drill.exec.planner.sql.DrillSqlWorker | From | To | |
| Extract Method public get(key String, dataChangeVersion DataChangeVersion) : V extracted from public get(key String) : V in class org.apache.drill.exec.testing.store.NoWriteLocalStore | From | To | |
| Extract Method public put(path String, data byte[], version DataChangeVersion) : void extracted from public put(path String, data byte[]) : void in class org.apache.drill.exec.coord.zk.ZookeeperClient | From | To | |
| Extract Method private findExactMatchingDrillFunction(name String, argTypes List<MajorType>, returnType MajorType, retry boolean) : DrillFuncHolder extracted from public findExactMatchingDrillFunction(name String, argTypes List<MajorType>, returnType MajorType) : DrillFuncHolder in class org.apache.drill.exec.expr.fn.FunctionImplementationRegistry | From | To | |
| Extract Method public put(key String, value V, version DataChangeVersion) : void extracted from public put(key String, value V) : void in class org.apache.drill.exec.store.sys.store.ZookeeperPersistentStore | From | To | |
| Extract Method public put(key String, value V, dataChangeVersion DataChangeVersion) : void extracted from public put(key String, value V) : void in class org.apache.drill.exec.testing.store.NoWriteLocalStore | From | To |