8e19d61b07c2e2f5e197c2a255efe137398ed3bd
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public testExceptionLeftNlJoin() : void renamed to public testNlJoinWithLargeRightInputFailure() : void in class org.apache.drill.exec.physical.impl.join.TestNestedLoopJoin | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type batch : VectorAccessible to batches : Map<VectorAccessible,BatchReference> in method public materialize(expr LogicalExpression, batches Map<VectorAccessible,BatchReference>, errorCollector ErrorCollector, functionLookupContext FunctionLookupContext, allowComplexWriterExpr boolean, unionTypeEnabled boolean) : LogicalExpression in class org.apache.drill.exec.expr.ExpressionTreeMaterializer | From | To | |
| Change Parameter Type batch : VectorAccessible to batches : Map<VectorAccessible,BatchReference> in method public MaterializeVisitor(batches Map<VectorAccessible,BatchReference>, errorCollector ErrorCollector, allowComplexWriter boolean, unionTypeEnabled boolean) in class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor | From | To | |
| Change Parameter Type input : RelNode to inputs : List<RelNode> in method package RexToDrill(context DrillParseContext, inputs List<RelNode>) in class org.apache.drill.exec.planner.logical.DrillOptiq.RexToDrill | From | To | |
| Rename Variable | 3 | ||
| Rename Variable nljoin : NestedLoopJoinPOP to nlj : NestedLoopJoinPOP in method public getPhysicalOperator(creator PhysicalPlanCreator) : PhysicalOperator in class org.apache.drill.exec.planner.physical.NestedLoopJoinPrel | From | To | |
| Rename Variable vw : VectorWrapper<?> to vectorWrapper : VectorWrapper<?> in method protected buildSchema() : void in class org.apache.drill.exec.physical.impl.join.NestedLoopJoinBatch | From | To | |
| Rename Variable jtype : JoinRelType to condition : LogicalExpression in method public getPhysicalOperator(creator PhysicalPlanCreator) : PhysicalOperator in class org.apache.drill.exec.planner.physical.NestedLoopJoinPrel | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private nextRightRecordToProcess : int from class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate to private nextRightRecordToProcess : int from class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate.IterationStatusTracker | From | To | |
| Move Attribute private nextRightBatchToProcess : int from class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate to private nextRightBatchToProcess : int from class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate.IterationStatusTracker | From | To | |
| Move Attribute private nextLeftRecordToProcess : int from class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate to private nextLeftRecordToProcess : int from class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate.IterationStatusTracker | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate.IterationStatusTracker from class org.apache.drill.exec.physical.impl.join.NestedLoopJoinTemplate | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute input : RelNode to inputs : List<RelNode> in class org.apache.drill.exec.planner.logical.DrillOptiq.RexToDrill | From | To | |
| Rename Attribute batch : VectorAccessible to batches : Map<VectorAccessible,BatchReference> in class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor | From | To | |
| Rename Attribute conditions : List<JoinCondition> to condition : LogicalExpression in class org.apache.drill.exec.physical.config.NestedLoopJoinPOP | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type result : Long to result : long in method public testNLJWithEmptyBatch() : void in class org.apache.drill.exec.physical.impl.join.TestNestedLoopJoin | From | To | |
| Change Variable Type jtype : JoinRelType to condition : LogicalExpression in method public getPhysicalOperator(creator PhysicalPlanCreator) : PhysicalOperator in class org.apache.drill.exec.planner.physical.NestedLoopJoinPrel | From | To | |
| Extract Variable | 1 | ||
| Extract Variable batchName : DirectExpression in method private visitValueVectorReadExpression(e ValueVectorReadExpression, generator ClassGenerator<?>) : HoldingContainer from class org.apache.drill.exec.expr.EvaluationVisitor.EvalVisitor | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type batch : VectorAccessible to batches : Map<VectorAccessible,BatchReference> in class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor | From | To | |
| Change Attribute Type conditions : List<JoinCondition> to condition : LogicalExpression in class org.apache.drill.exec.physical.config.NestedLoopJoinPOP | From | To | |
| Change Attribute Type input : RelNode to inputs : List<RelNode> in class org.apache.drill.exec.planner.logical.DrillOptiq.RexToDrill | From | To | |
| Extract Method | 2 | ||
| Extract Method public toDrill(context DrillParseContext, inputs List<RelNode>, expr RexNode) : LogicalExpression extracted from public toDrill(context DrillParseContext, input RelNode, expr RexNode) : LogicalExpression in class org.apache.drill.exec.planner.logical.DrillOptiq | From | To | |
| Extract Method public materialize(expr LogicalExpression, batches Map<VectorAccessible,BatchReference>, errorCollector ErrorCollector, functionLookupContext FunctionLookupContext, allowComplexWriterExpr boolean, unionTypeEnabled boolean) : LogicalExpression extracted from public materialize(expr LogicalExpression, batch VectorAccessible, errorCollector ErrorCollector, functionLookupContext FunctionLookupContext, allowComplexWriterExpr boolean, unionTypeEnabled boolean) : LogicalExpression in class org.apache.drill.exec.expr.ExpressionTreeMaterializer | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter batch : VectorAccessible to batches : Map<VectorAccessible,BatchReference> in method public materialize(expr LogicalExpression, batches Map<VectorAccessible,BatchReference>, errorCollector ErrorCollector, functionLookupContext FunctionLookupContext, allowComplexWriterExpr boolean, unionTypeEnabled boolean) : LogicalExpression in class org.apache.drill.exec.expr.ExpressionTreeMaterializer | From | To | |
| Rename Parameter input : RelNode to inputs : List<RelNode> in method package RexToDrill(context DrillParseContext, inputs List<RelNode>) in class org.apache.drill.exec.planner.logical.DrillOptiq.RexToDrill | From | To | |
| Rename Parameter batch : VectorAccessible to batches : Map<VectorAccessible,BatchReference> in method public MaterializeVisitor(batches Map<VectorAccessible,BatchReference>, errorCollector ErrorCollector, allowComplexWriter boolean, unionTypeEnabled boolean) in class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor | From | To |