drill 9411b26ece34ed8b2f498deea5e41f1901eb1013

9411b26ece34ed8b2f498deea5e41f1901eb1013

Files Diff

Added: 19
Removed: 1
Renamed: 0
Modified: 24

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	34
Pull Up Method public visitQuotedStringConstant(e QuotedString, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitQuotedStringConstant(e QuotedString, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private getUnionAssertFunctionForType(type MinorType, arg LogicalExpression) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private getUnionAssertFunctionForType(type MinorType, arg LogicalExpression) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitUnknown(e LogicalExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitUnknown(e LogicalExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitFloatConstant(fExpr FloatExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitFloatConstant(fExpr FloatExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitTimeConstant(intExpr TimeExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitTimeConstant(intExpr TimeExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitFunctionHolderExpression(holder FunctionHolderExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitFunctionHolderExpression(holder FunctionHolderExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private getExceptionFunction(message String) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private getExceptionFunction(message String) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitIfExpression(ifExpr IfExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitIfExpression(ifExpr IfExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private validateNewExpr(newExpr LogicalExpression) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private validateNewExpr(newExpr LogicalExpression) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitIntervalDayConstant(intExpr IntervalDayExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitIntervalDayConstant(intExpr IntervalDayExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitIntConstant(intExpr IntExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitIntConstant(intExpr IntExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitDecimal9Constant(decExpr Decimal9Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitDecimal9Constant(decExpr Decimal9Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitNullConstant(nullConstant TypedNullConstant, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitNullConstant(nullConstant TypedNullConstant, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private rewriteNullExpression(expr LogicalExpression, type MajorType) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private rewriteNullExpression(expr LogicalExpression, type MajorType) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitDecimal38Constant(decExpr Decimal38Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitDecimal38Constant(decExpr Decimal38Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private getConvertToNullableExpr(args List<LogicalExpression>, minorType MinorType, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private getConvertToNullableExpr(args List<LogicalExpression>, minorType MinorType, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitLongConstant(intExpr LongExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitLongConstant(intExpr LongExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitTimeStampConstant(intExpr TimeStampExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitTimeStampConstant(intExpr TimeStampExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitDoubleConstant(dExpr DoubleExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitDoubleConstant(dExpr DoubleExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitDecimal28Constant(decExpr Decimal28Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitDecimal28Constant(decExpr Decimal28Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private castEqual(pos ExpressionPosition, from MajorType, to MajorType) : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private castEqual(pos ExpressionPosition, from MajorType, to MajorType) : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitDecimal18Constant(decExpr Decimal18Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitDecimal18Constant(decExpr Decimal18Expression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private hasUnionInput(call FunctionCall) : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private hasUnionInput(call FunctionCall) : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitConvertExpression(e ConvertExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitConvertExpression(e ConvertExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitBooleanOperator(op BooleanOperator, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitBooleanOperator(op BooleanOperator, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitFunctionCall(call FunctionCall, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitFunctionCall(call FunctionCall, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private computePrecision(currentArg LogicalExpression) : int from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private computePrecision(currentArg LogicalExpression) : int from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private rewriteUnionFunction(call FunctionCall, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private rewriteUnionFunction(call FunctionCall, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private parseExpr(expr String) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTest to protected parseExpr(expr String) : LogicalExpression from class org.apache.drill.exec.ExecTest	From	To
Pull Up Method public visitDateConstant(intExpr DateExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitDateConstant(intExpr DateExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitIntervalYearConstant(intExpr IntervalYearExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitIntervalYearConstant(intExpr IntervalYearExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitCastExpression(e CastExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitCastExpression(e CastExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method public visitBooleanConstant(e BooleanExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to public visitBooleanConstant(e BooleanExpression, functionLookupContext FunctionLookupContext) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Method private getIsTypeExpressionForType(type MinorType, arg LogicalExpression) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private getIsTypeExpressionForType(type MinorType, arg LogicalExpression) : LogicalExpression from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Change Parameter Type	2
Change Parameter Type schemaElement : SchemaElement to precision : int in method private getMinorType(primitiveTypeName PrimitiveType.PrimitiveTypeName, length int, convertedType ConvertedType, precision int, scale int, options OptionManager) : TypeProtos.MinorType in class org.apache.drill.exec.store.parquet.columnreaders.ParquetToDrillTypeConverter	From	To
Change Parameter Type schemaElement : SchemaElement to precision : int in method private getDecimalType(precision int) : TypeProtos.MinorType in class org.apache.drill.exec.store.parquet.columnreaders.ParquetToDrillTypeConverter	From	To
Move Method	2
Move Method public isCompareFunction(functionName String) : boolean from class org.apache.drill.exec.store.parquet.ParquetCompareFunctionProcessor to private isCompareFunction(funcName String) : boolean from class org.apache.drill.exec.store.parquet.ParquetFilterBuilder	From	To
Move Method private parseExpr(expr String) : LogicalExpression from class org.apache.drill.exec.fn.interp.ExpressionInterpreterTest to protected parseExpr(expr String) : LogicalExpression from class org.apache.drill.exec.ExecTest	From	To
Rename Variable	2
Rename Variable newScanPrel : ScanPrel to newScanRel : ScanPrel in method protected doOnMatch(call RelOptRuleCall, filter FilterPrel, project ProjectPrel, scan ScanPrel) : void in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter	From	To
Rename Variable inputPrel : RelNode to inputRel : RelNode in method protected doOnMatch(call RelOptRuleCall, filter FilterPrel, project ProjectPrel, scan ScanPrel) : void in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter	From	To
Pull Up Attribute	7
Pull Up Attribute private errorCollector : ErrorCollector from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private errorCollector : ErrorCollector from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Attribute private unionTypeEnabled : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private unionTypeEnabled : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Attribute private validator : ExpressionValidator from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private validator : ExpressionValidator from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Attribute private errorCollectors : Deque<ErrorCollector> from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private errorCollectors : Deque<ErrorCollector> from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Attribute private materializedExpressions : Set<LogicalExpression> from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private materializedExpressions : Set<LogicalExpression> from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Attribute private UNION_FUNCTIONS : Set<String> from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private UNION_FUNCTIONS : Set<String> from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Pull Up Attribute private allowComplexWriter : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor to private allowComplexWriter : boolean from class org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor	From	To
Change Return Type	1
Change Return Type StoragePluginOptimizerRule to RelOptRule in method public getFilterOnProject(optimizerRulesContext OptimizerRulesContext) : RelOptRule in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter	From	To
Extract Superclass	1
Extract Superclass org.apache.drill.exec.expr.ExpressionTreeMaterializer.AbstractMaterializeVisitor from classes [org.apache.drill.exec.expr.ExpressionTreeMaterializer.MaterializeVisitor]	From	To
Rename Attribute	2
Rename Attribute context : OptimizerRulesContext to optimizerContext : OptimizerRulesContext in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter	From	To
Rename Attribute columnTypeMap : Map<SchemaPath,MajorType> to partitionColTypeMap : Map<SchemaPath,MajorType> in class org.apache.drill.exec.store.parquet.ParquetGroupScan	From	To
Extract Method	2
Extract Method public populateImplicitColumns(filePath String, selectionRoot String) : Map<String,String> extracted from public populateImplicitColumns(work FileWork, selectionRoot String) : Map<String,String> in class org.apache.drill.exec.store.ImplicitColumnExplorer	From	To
Extract Method public toMajorType(primitiveTypeName PrimitiveType.PrimitiveTypeName, length int, mode TypeProtos.DataMode, convertedType ConvertedType, precision int, scale int, options OptionManager) : TypeProtos.MajorType extracted from public toMajorType(primitiveTypeName PrimitiveType.PrimitiveTypeName, length int, mode TypeProtos.DataMode, schemaElement SchemaElement, options OptionManager) : TypeProtos.MajorType in class org.apache.drill.exec.store.parquet.columnreaders.ParquetToDrillTypeConverter	From	To
Extract And Move Method	1
Extract And Move Method public evaluateFunction(interpreter DrillSimpleFunc, args ValueHolder[], funcName String) : ValueHolder extracted from public visitFunctionHolderExpression(holderExpr FunctionHolderExpression, inIndex Integer) : ValueHolder in class org.apache.drill.exec.expr.fn.interpreter.InterpreterEvaluator.EvalVisitor & moved to class org.apache.drill.exec.expr.fn.interpreter.InterpreterEvaluator	From	To
Rename Parameter	6
Rename Parameter schemaElement : SchemaElement to precision : int in method private getMinorType(primitiveTypeName PrimitiveType.PrimitiveTypeName, length int, convertedType ConvertedType, precision int, scale int, options OptionManager) : TypeProtos.MinorType in class org.apache.drill.exec.store.parquet.columnreaders.ParquetToDrillTypeConverter	From	To
Rename Parameter schemaElement : SchemaElement to precision : int in method private getDecimalType(precision int) : TypeProtos.MinorType in class org.apache.drill.exec.store.parquet.columnreaders.ParquetToDrillTypeConverter	From	To
Rename Parameter context : OptimizerRulesContext to optimizerContext : OptimizerRulesContext in method private ParquetPushDownFilter(operand RelOptRuleOperand, id String, optimizerContext OptimizerRulesContext) in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter	From	To
Rename Parameter context : OptimizerRulesContext to optimizerRulesContext : OptimizerRulesContext in method public getFilterOnProject(optimizerRulesContext OptimizerRulesContext) : RelOptRule in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter	From	To
Rename Parameter context : OptimizerRulesContext to optimizerContext : OptimizerRulesContext in method public getFilterOnScan(optimizerContext OptimizerRulesContext) : StoragePluginOptimizerRule in class org.apache.drill.exec.store.parquet.ParquetPushDownFilter	From	To
Rename Parameter functionName : String to funcName : String in method private isCompareFunction(funcName String) : boolean in class org.apache.drill.exec.store.parquet.ParquetFilterBuilder	From	To

9411b26ece34ed8b2f498deea5e41f1901eb1013

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: