9667e92e1e87ce1826f0eac3f2396187dbfa8aaa
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 29
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Move And Rename Method | 1 | ||
Move And Rename Method private broadcastAggregatedRuntimeFilter(srcRuntimeFilterWritable RuntimeFilterWritable) : void from class org.apache.drill.exec.work.filter.RuntimeFilterRouter to private route(srcRuntimeFilterWritable RuntimeFilterWritable) : void from class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Move And Inline Method | 4 | ||
Move And Inline Method public setProbeSideGroupScan(probeSideGroupScan GroupScan) : void moved from class org.apache.drill.exec.work.filter.RuntimeFilterDef to class org.apache.drill.exec.planner.physical.visitor.RuntimeFilterVisitor & inlined to private generateRuntimeFilter(hashJoinPrel HashJoinPrel) : RuntimeFilterDef | From | To | |
Move And Inline Method public containOne() : boolean moved from class org.apache.drill.exec.work.filter.RuntimeFilterSink to class org.apache.drill.exec.physical.impl.filter.RuntimeFilterRecordBatch & inlined to private setupHashHelper() : void | From | To | |
Move And Inline Method public containOne() : boolean moved from class org.apache.drill.exec.work.filter.RuntimeFilterSink to class org.apache.drill.exec.physical.impl.filter.RuntimeFilterRecordBatch & inlined to private applyRuntimeFilter() : void | From | To | |
Move And Inline Method public containOne() : boolean moved from class org.apache.drill.exec.work.filter.RuntimeFilterSink to class org.apache.drill.exec.work.filter.RuntimeFilterSink.AsyncAggregateWorker & inlined to public run() : void | From | To | |
Change Parameter Type | 2 | ||
Change Parameter Type op : PhysicalOperator to targetOpVisitor : TargetPhysicalOperatorVisitor in method private findTargetWrapper(wrapper Wrapper, targetOpVisitor TargetPhysicalOperatorVisitor) : Wrapper in class org.apache.drill.exec.work.filter.RuntimeFilterRouter | From | To | |
Change Parameter Type sendToForeman : boolean to runtimeFilterDef : RuntimeFilterDef in method public sendOut(bloomFilters List<BloomFilter>, probeFields List<String>, runtimeFilterDef RuntimeFilterDef, hashJoinOpId int) : void in class org.apache.drill.exec.work.filter.RuntimeFilterReporter | From | To | |
Move Attribute | 2 | ||
Move Attribute private joinMjId2ScanMjId : Map<Integer,Integer> from class org.apache.drill.exec.work.filter.RuntimeFilterRouter to private joinMjId2ScanMjId : Map<Integer,Integer> from class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Move Attribute private drillbitContext : DrillbitContext from class org.apache.drill.exec.work.filter.RuntimeFilterRouter to private drillbitContext : DrillbitContext from class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Change Variable Type | 3 | ||
Change Variable Type probeSideScanOp : GroupScan to runtimeFilterIdentifier : long in method public visitOp(op PhysicalOperator, holder RFHelperHolder) : Void in class org.apache.drill.exec.work.filter.RuntimeFilterRouter.RuntimeFilterParallelismCollector | From | To | |
Change Variable Type tmpFilterRows : int to filteredRows : long in method private applyRuntimeFilter() : void in class org.apache.drill.exec.physical.impl.filter.RuntimeFilterRecordBatch | From | To | |
Change Variable Type groupScan : GroupScan to probeSideScanPrel : ScanPrel in method private generateRuntimeFilter(hashJoinPrel HashJoinPrel) : RuntimeFilterDef in class org.apache.drill.exec.planner.physical.visitor.RuntimeFilterVisitor | From | To | |
Rename Method | 3 | ||
Rename Method public getRuntimeFilterSink() : RuntimeFilterSink renamed to public getRuntimeFilter(rfIdentifier long) : RuntimeFilterWritable in class org.apache.drill.exec.ops.FragmentContext | From | To | |
Rename Method public getRuntimeFilterSink() : RuntimeFilterSink renamed to public getRuntimeFilter(rfIdentifier long) : RuntimeFilterWritable in class org.apache.drill.test.PhysicalOpUnitTestBase.MockExecutorFragmentContext | From | To | |
Rename Method private findPhysicalOpContainer(wrapper Wrapper, op PhysicalOperator) : Wrapper renamed to private findTargetWrapper(wrapper Wrapper, targetOpVisitor TargetPhysicalOperatorVisitor) : Wrapper in class org.apache.drill.exec.work.filter.RuntimeFilterRouter | From | To | |
Inline Method | 2 | ||
Inline Method public containOne() : boolean inlined to private aggregate(srcRuntimeFilterWritable RuntimeFilterWritable) : void in class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Rename Variable | 3 | ||
Rename Variable probeSideScanOp : GroupScan to runtimeFilterIdentifier : long in method public visitOp(op PhysicalOperator, holder RFHelperHolder) : Void in class org.apache.drill.exec.work.filter.RuntimeFilterRouter.RuntimeFilterParallelismCollector | From | To | |
Rename Variable condFieldIndex : int to fieldId : int in method public executeBuildPhase() : IterOutcome in class org.apache.drill.exec.physical.impl.join.HashJoinBatch | From | To | |
Rename Variable groupScan : GroupScan to probeSideScanPrel : ScanPrel in method private generateRuntimeFilter(hashJoinPrel HashJoinPrel) : RuntimeFilterDef in class org.apache.drill.exec.planner.physical.visitor.RuntimeFilterVisitor | From | To | |
Change Return Type | 2 | ||
Change Return Type RuntimeFilterSink to RuntimeFilterWritable in method public getRuntimeFilter(rfIdentifier long) : RuntimeFilterWritable in class org.apache.drill.exec.ops.FragmentContext | From | To | |
Change Return Type RuntimeFilterSink to RuntimeFilterWritable in method public getRuntimeFilter(rfIdentifier long) : RuntimeFilterWritable in class org.apache.drill.test.PhysicalOpUnitTestBase.MockExecutorFragmentContext | From | To | |
Replace Variable With Attribute | 1 | ||
Replace Variable With Attribute tmpFilterRows : int to filteredRows : long in method private applyRuntimeFilter() : void in class org.apache.drill.exec.physical.impl.filter.RuntimeFilterRecordBatch | From | To | |
Extract Superclass | 1 | ||
Extract Superclass org.apache.drill.exec.work.filter.RuntimeFilterRouter.TargetPhysicalOperatorVisitor from classes [org.apache.drill.exec.work.filter.RuntimeFilterRouter.WrapperOperatorsVisitor] | From | To | |
Rename Attribute | 3 | ||
Rename Attribute bufferAllocator : BufferAllocator to sendingAccountor : SendingAccountor in class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Rename Attribute future : Future to drillbitContext : DrillbitContext in class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Rename Attribute mask : int[] to bucketMask : int[] in class org.apache.drill.exec.work.filter.BloomFilter | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type bufferAllocator : BufferAllocator to sendingAccountor : SendingAccountor in class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Change Attribute Type future : Future to drillbitContext : DrillbitContext in class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To | |
Rename Parameter | 3 | ||
Rename Parameter op : PhysicalOperator to targetOpVisitor : TargetPhysicalOperatorVisitor in method private findTargetWrapper(wrapper Wrapper, targetOpVisitor TargetPhysicalOperatorVisitor) : Wrapper in class org.apache.drill.exec.work.filter.RuntimeFilterRouter | From | To | |
Rename Parameter sendToForeman : boolean to runtimeFilterDef : RuntimeFilterDef in method public sendOut(bloomFilters List<BloomFilter>, probeFields List<String>, runtimeFilterDef RuntimeFilterDef, hashJoinOpId int) : void in class org.apache.drill.exec.work.filter.RuntimeFilterReporter | From | To | |
Rename Parameter runtimeFilterWritable : RuntimeFilterWritable to srcRuntimeFilterWritable : RuntimeFilterWritable in method private aggregate(srcRuntimeFilterWritable RuntimeFilterWritable) : void in class org.apache.drill.exec.work.filter.RuntimeFilterSink | From | To |