99b6d0e6d2fc6dea165e9e809db4fc63d9a70d3a
Files Diff
- Added: 5
- Removed: 2
- Renamed: 0
- Modified: 32
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public errorMessageToException(errorMessage String) : void renamed to public errorClassNameToException(errorClassName String) : void in class org.apache.drill.exec.work.foreman.SqlUnsupportedException | From | To | |
| Change Parameter Type | 14 | ||
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.exec.rpc.user.QueryResultHandler.BufferingResultsListener | From | To | |
| Change Parameter Type excep : Throwable to excep : DrillUserException in method public fail(handle FragmentHandle, message String, excep DrillUserException) : void in class org.apache.drill.exec.work.fragment.StatusReporter | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.BaseTestQuery.SilentListener | From | To | |
| Change Parameter Type value : int to value : UserBitShared.DrillPBError.ErrorType in method public setErrorType(value UserBitShared.DrillPBError.ErrorType) : Builder in class org.apache.drill.exec.proto.UserBitShared.DrillPBError.Builder | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.exec.rpc.user.UserResultsListener | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.exec.server.rest.QueryWrapper.Listener | From | To | |
| Change Parameter Type excep : Throwable to excep : DrillUserException in method public fail(handle FragmentHandle, message String, excep DrillUserException) : void in class org.apache.drill.exec.work.fragment.AbstractStatusReporter | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.exec.store.parquet.TestParquetPhysicalPlan.ParquetResultsListener | From | To | |
| Change Parameter Type errorType : int to errorType : ErrorType in method public setErrorType(errorType ErrorType) : DrillPBError in class org.apache.drill.exec.proto.beans.DrillPBError | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.exec.store.parquet.ParquetResultListener | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.exec.client.DrillClient.ListHoldingResultsListener | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.exec.client.PrintingResultsListener | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.jdbc.impl.DrillResultSetImpl.ResultsListener | From | To | |
| Change Parameter Type ex : RpcException to ex : DrillUserException in method public submissionFailed(ex DrillUserException) : void in class org.apache.drill.SingleRowListener | From | To | |
| Rename Variable | 4 | ||
| Rename Variable rpce : RpcException to dre : DrillUserException in method public testForeman_setInjectionViaAlterSystem() : void in class org.apache.drill.exec.server.TestDrillbitResilience | From | To | |
| Rename Variable wrappers : StackTraceElementWrapper[] to stackTrace : StackTraceElement[] in method private getWrapperBuilder(ex Throwable, includeAllStack boolean) : ExceptionWrapper.Builder in class org.apache.drill.common.exceptions.ErrorHelper | From | To | |
| Rename Variable cause : Throwable to dse : DrillUserException in method public fail(cause Throwable) : void in class org.apache.drill.exec.ops.FragmentContext | From | To | |
| Rename Variable rpce : RpcException to dre : DrillUserException in method private testForeman(desc String) : void in class org.apache.drill.exec.server.TestDrillbitResilience | From | To | |
| Change Return Type | 4 | ||
| Change Return Type int to ErrorType in method public getErrorType() : ErrorType in class org.apache.drill.exec.proto.beans.DrillPBError | From | To | |
| Change Return Type int to UserBitShared.DrillPBError.ErrorType in method public getErrorType() : UserBitShared.DrillPBError.ErrorType in class org.apache.drill.exec.proto.UserBitShared.DrillPBError.Builder | From | To | |
| Change Return Type int to UserBitShared.DrillPBError.ErrorType in method public getErrorType() : UserBitShared.DrillPBError.ErrorType in class org.apache.drill.exec.proto.UserBitShared.DrillPBError | From | To | |
| Change Return Type int to UserBitShared.DrillPBError.ErrorType in method public getErrorType() : UserBitShared.DrillPBError.ErrorType in class org.apache.drill.exec.proto.UserBitShared.DrillPBErrorOrBuilder | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.drill.exec.work.ErrorHelper moved to org.apache.drill.common.exceptions.ErrorHelper | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type rpce : RpcException to dre : DrillUserException in method public testForeman_setInjectionViaAlterSystem() : void in class org.apache.drill.exec.server.TestDrillbitResilience | From | To | |
| Change Variable Type wrappers : StackTraceElementWrapper[] to stackTrace : StackTraceElement[] in method private getWrapperBuilder(ex Throwable, includeAllStack boolean) : ExceptionWrapper.Builder in class org.apache.drill.common.exceptions.ErrorHelper | From | To | |
| Change Variable Type cause : Throwable to dse : DrillUserException in method public fail(cause Throwable) : void in class org.apache.drill.exec.ops.FragmentContext | From | To | |
| Change Variable Type rpce : RpcException to dre : DrillUserException in method private testForeman(desc String) : void in class org.apache.drill.exec.server.TestDrillbitResilience | From | To | |
| Extract Method | 25 | ||
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledComparisonWithNonscalarSubquery() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testExplainPlanOuterJoinWithInequality() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledExplainplanForComparisonWithNonscalarSubquery() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testInnerJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledExcept() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testExplainPlanForCartesianJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testImplicitCartesianJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledNaturalJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledCastTINYINT() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledCastREAL() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testSubqueryWithoutCorrelatedJoinCondition() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testMultipleJoinsWithOneNonEqualJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledCardinality() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledExceptALL() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testMultipleUnsupportedOperatorations() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testOuterJoinWithInequality() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledUnion() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledIntersect() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testLeftOuterJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledUnionDistinct() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledIntersectALL() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledCrossJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testNonEqualJoin() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledWindowFunctions() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Extract Method private throwAsUnsupportedException(ex DrillUserException) : void extracted from public testDisabledCastSMALLINT() : void in class org.apache.drill.TestDisabledFunctionality | From | To | |
| Change Attribute Type | 9 | ||
| Change Attribute Type errorType_ : int to errorType_ : UserBitShared.DrillPBError.ErrorType in class org.apache.drill.exec.proto.UserBitShared.DrillPBError | From | To | |
| Change Attribute Type resultException : Exception to resultException : DrillUserException in class org.apache.drill.exec.work.foreman.Foreman.ForemanResult | From | To | |
| Change Attribute Type ex : RpcException to ex : DrillUserException in class org.apache.drill.exec.rpc.user.QueryResultHandler.BufferingResultsListener | From | To | |
| Change Attribute Type errorType_ : int to errorType_ : UserBitShared.DrillPBError.ErrorType in class org.apache.drill.exec.proto.UserBitShared.DrillPBError.Builder | From | To | |
| Change Attribute Type exception : Exception to exception : DrillUserException in class org.apache.drill.exec.client.PrintingResultsListener | From | To | |
| Change Attribute Type errorType : int to errorType : ErrorType in class org.apache.drill.exec.proto.beans.DrillPBError | From | To | |
| Change Attribute Type exception : Exception to exception : DrillUserException in class org.apache.drill.exec.server.rest.QueryWrapper.Listener | From | To | |
| Change Attribute Type ex : RpcException to ex : DrillUserException in class org.apache.drill.jdbc.impl.DrillResultSetImpl.ResultsListener | From | To | |
| Change Attribute Type exception : Exception to exception : DrillUserException in class org.apache.drill.BaseTestQuery.SilentListener | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter errorMessage : String to errorClassName : String in method public errorClassNameToException(errorClassName String) : void in class org.apache.drill.exec.work.foreman.SqlUnsupportedException | From | To | |
| Rename Parameter msg : String to suffix : String in method protected handleAndRaise(suffix String, e Exception) : void in class org.apache.drill.exec.store.easy.json.JSONRecordReader | From | To |