9dc81e199cbabedbdd68acfa676a66a022b51907
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 24
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public testDatePredicateAgaistDrillCTASPost1_8() : void renamed to public testDatePredicateAgainstDrillCTASPost1_8() : void in class org.apache.drill.exec.store.parquet.TestParquetFilterPushDown | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public getSelectionRoot() : Path from class org.apache.drill.exec.store.parquet.ParquetRowGroupScan to public getSelectionRoot() : Path from class org.apache.drill.exec.store.parquet.AbstractParquetRowGroupScan | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type readerList : List<RecordReader> to readerList : List<? extends RecordReader> in method public ScanBatch(context FragmentContext, oContext OperatorContext, readerList List<? extends RecordReader>, implicitColumnList List<Map<String,String>>) in class org.apache.drill.exec.physical.impl.ScanBatch | From | To | |
| Pull Up Attribute | 8 | ||
| Pull Up Attribute private operatorContext : OperatorContext from class org.apache.drill.exec.store.parquet2.DrillParquetReader to protected operatorContext : OperatorContext from class org.apache.drill.exec.store.CommonParquetRecordReader | From | To | |
| Pull Up Attribute private fragmentContext : FragmentContext from class org.apache.drill.exec.store.parquet2.DrillParquetReader to protected fragmentContext : FragmentContext from class org.apache.drill.exec.store.CommonParquetRecordReader | From | To | |
| Pull Up Attribute private operatorContext : OperatorContext from class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader to protected operatorContext : OperatorContext from class org.apache.drill.exec.store.CommonParquetRecordReader | From | To | |
| Pull Up Attribute private fragmentContext : FragmentContext from class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader to protected fragmentContext : FragmentContext from class org.apache.drill.exec.store.CommonParquetRecordReader | From | To | |
| Pull Up Attribute private footer : ParquetMetadata from class org.apache.drill.exec.store.parquet2.DrillParquetReader to protected footer : ParquetMetadata from class org.apache.drill.exec.store.CommonParquetRecordReader | From | To | |
| Pull Up Attribute public parquetReaderStats : ParquetReaderStats from class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader to public parquetReaderStats : ParquetReaderStats from class org.apache.drill.exec.store.CommonParquetRecordReader | From | To | |
| Pull Up Attribute private footer : ParquetMetadata from class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader to protected footer : ParquetMetadata from class org.apache.drill.exec.store.CommonParquetRecordReader | From | To | |
| Pull Up Attribute private selectionRoot : Path from class org.apache.drill.exec.store.parquet.ParquetRowGroupScan to protected selectionRoot : Path from class org.apache.drill.exec.store.parquet.AbstractParquetRowGroupScan | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader.Metric moved to org.apache.drill.exec.store.CommonParquetRecordReader.Metric | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.drill.exec.store.CommonParquetRecordReader from classes [org.apache.drill.exec.store.parquet.columnreaders.ParquetRecordReader, org.apache.drill.exec.store.parquet2.DrillParquetReader] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute fileSystem : DrillFileSystem to drillFileSystem : DrillFileSystem in class org.apache.drill.exec.store.parquet2.DrillParquetReader | From | To | |
| Extract Variable | 3 | ||
| Extract Variable theFilterRel : Filter in method protected doOnMatch(call RelOptRuleCall, filter FilterPrel, project ProjectPrel, scan ScanPrel) : void from class org.apache.drill.exec.store.parquet.ParquetPushDownFilter | From | To | |
| Extract Variable columnTypeInfoMap : ConcurrentHashMap<Metadata_V4.ColumnTypeMetadata_v4.Key,Metadata_V4.ColumnTypeMetadata_v4> in method public populateNonInterestingColumnsStats(schemaPaths Set<SchemaPath>, parquetTableMetadata MetadataBase.ParquetTableMetadataBase) : Map<SchemaPath,ColumnStatistics> from class org.apache.drill.exec.store.parquet.ParquetTableMetadataUtils | From | To | |
| Extract Variable theNewFilter : Filter in method protected doOnMatch(call RelOptRuleCall, filter FilterPrel, project ProjectPrel, scan ScanPrel) : void from class org.apache.drill.exec.store.parquet.ParquetPushDownFilter | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type reader : RecordReader to reader : CommonParquetRecordReader in method private createReaderAndImplicitColumns(context ExecutorFragmentContext, rowGroupScan AbstractParquetRowGroupScan, oContext OperatorContext, columnExplorer ColumnExplorer, readers List<CommonParquetRecordReader>, implicitColumns List<Map<String,String>>, mapWithMaxColumns Map<String,String>, rowGroup RowGroupReadEntry, fs DrillFileSystem, footer ParquetMetadata, readSchemaOnly boolean) : Map<String,String> in class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator | From | To | |
| Change Variable Type readers : List<RecordReader> to readers : List<CommonParquetRecordReader> in method protected getBatch(context ExecutorFragmentContext, rowGroupScan AbstractParquetRowGroupScan, oContext OperatorContext) : ScanBatch in class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type readers : Iterator<RecordReader> to readers : Iterator<? extends RecordReader> in class org.apache.drill.exec.physical.impl.ScanBatch | From | To | |
| Change Attribute Type PARQUET_ROWGROUP_FILTER_PUSHDOWN_PLANNING_THRESHOLD : PositiveLongValidator to PARQUET_ROWGROUP_FILTER_PUSHDOWN_PLANNING_THRESHOLD : LongValidator in class org.apache.drill.exec.planner.physical.PlannerSettings | From | To | |
| Extract Method | 3 | ||
| Extract Method private createReaderAndImplicitColumns(context ExecutorFragmentContext, rowGroupScan AbstractParquetRowGroupScan, oContext OperatorContext, columnExplorer ColumnExplorer, readers List<CommonParquetRecordReader>, implicitColumns List<Map<String,String>>, mapWithMaxColumns Map<String,String>, rowGroup RowGroupReadEntry, fs DrillFileSystem, footer ParquetMetadata, readSchemaOnly boolean) : Map<String,String> extracted from protected getBatch(context ExecutorFragmentContext, rowGroupScan AbstractParquetRowGroupScan, oContext OperatorContext) : ScanBatch in class org.apache.drill.exec.store.parquet.AbstractParquetScanBatchCreator | From | To | |
| Extract Method public getFilterPredicate(filterExpr LogicalExpression, udfUtilities UdfUtilities, functionImplementationRegistry FunctionImplementationRegistry, optionManager OptionManager, omitUnsupportedExprs boolean, supportsFileImplicitColumns boolean, tupleSchema TupleSchema) : FilterPredicate extracted from public getFilterPredicate(filterExpr LogicalExpression, udfUtilities UdfUtilities, functionImplementationRegistry FunctionImplementationRegistry, optionManager OptionManager, omitUnsupportedExprs boolean) : FilterPredicate in class org.apache.drill.exec.physical.base.AbstractGroupScanWithMetadata | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method private getParquetFileMetadata_v4(parquetTableMetadata ParquetTableMetadata_v4, file FileStatus, fs FileSystem, allColumnsInteresting boolean, columnSet Set<String>, readerConfig ParquetReaderConfig) : ParquetFileAndRowCountMetadata extracted from protected runInner() : ParquetFileAndRowCountMetadata in class org.apache.drill.exec.store.parquet.metadata.Metadata.MetadataGatherer & moved to class org.apache.drill.exec.store.parquet.metadata.Metadata | From | To |