drill 9fd1430db69309c2e476007de851142f778ddb62

9fd1430db69309c2e476007de851142f778ddb62

Files Diff

Added: 5
Removed: 0
Renamed: 0
Modified: 53

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	4
Move And Rename Method public setHandle(value ExecProtos.FragmentHandle) : Builder from class org.apache.drill.exec.proto.BitData.BitClientHandshake.Builder to public setReceivingMajorFragmentId(value int) : Builder from class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Move And Rename Method public mergeHandle(value ExecProtos.FragmentHandle) : Builder from class org.apache.drill.exec.proto.BitData.BitClientHandshake.Builder to public setReceivingMajorFragmentId(value int) : Builder from class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Move And Rename Method public DataProtobufLengthDecoder(allocator BufferAllocator, outOfMemoryHandler OutOfMemoryHandler) from class org.apache.drill.exec.rpc.data.DataProtobufLengthDecoder to public Client(allocator BufferAllocator, outOfMemoryHandler OutOfMemoryHandler) from class org.apache.drill.exec.rpc.data.DataProtobufLengthDecoder.Client	From	To
Move And Rename Method public clearHandle() : Builder from class org.apache.drill.exec.proto.BitData.BitClientHandshake.Builder to public clearReceivingMinorFragmentId() : Builder from class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Parameter Type	9
Change Parameter Type sender : ResponseSender to sender : AckSender in method public handle(manager FragmentManager, fragmentBatch FragmentRecordBatch, data DrillBuf, sender AckSender) : void in class org.apache.drill.exec.rpc.data.DataResponseHandlerImpl	From	To
Change Parameter Type value : ExecProtos.FragmentHandle to value : UserBitShared.QueryId in method public mergeQueryId(value UserBitShared.QueryId) : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Parameter Type value : ExecProtos.FragmentHandle to value : UserBitShared.QueryId in method public setQueryId(value UserBitShared.QueryId) : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Parameter Type sender : ResponseSender to sender : AckSender in method public RawFragmentBatch(header FragmentRecordBatch, body DrillBuf, sender AckSender) in class org.apache.drill.exec.record.RawFragmentBatch	From	To
Change Parameter Type builderForValue : ExecProtos.FragmentHandle.Builder to builderForValue : UserBitShared.QueryId.Builder in method public setQueryId(builderForValue UserBitShared.QueryId.Builder) : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Parameter Type value : ExecProtos.FragmentHandle to value : int in method public setReceivingMajorFragmentId(value int) : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Parameter Type sender : ResponseSender to sender : AckSender in method public enqueueResponse(sender AckSender) : void in class org.apache.drill.exec.work.batch.ResponseSenderQueue	From	To
Change Parameter Type remoteHandle : FragmentHandle to endpoint : DrillbitEndpoint in method public getDataTunnel(endpoint DrillbitEndpoint) : DataTunnel in class org.apache.drill.exec.ops.FragmentContext	From	To
Move Method	1
Move Method protected decode(ctx ChannelHandlerContext, in ByteBuf, out List<Object>) : void from class org.apache.drill.exec.rpc.data.DataProtobufLengthDecoder to protected decode(ctx ChannelHandlerContext, in ByteBuf, out List<Object>) : void from class org.apache.drill.exec.rpc.data.DataProtobufLengthDecoder.Client	From	To
Move Attribute	1
Move Attribute private OUTPUT_BATCH_SIZE : int from class org.apache.drill.exec.physical.impl.join.JoinTemplate to private OUTPUT_BATCH_SIZE : int from class org.apache.drill.exec.physical.impl.join.JoinStatus	From	To
Rename Class	1
Rename Class org.apache.drill.exec.work.batch.TestUnlimitedBatchBuffer.MySender renamed to org.apache.drill.exec.work.batch.TestUnlimitedBatchBuffer.MyAckSender	From	To
Merge Variable	1
Merge Variable [e : FragmentSetupException, handle : FragmentHandle] to fragmentBatch : FragmentRecordBatch in method protected handle(connection BitServerConnection, rpcType int, pBody ByteBuf, body ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.data.DataServer	From	To
Change Variable Type	4
Change Variable Type subBuilder : ExecProtos.FragmentHandle.Builder to subBuilder : UserBitShared.QueryId.Builder in method private FragmentRecordBatch(input CodedInputStream, extensionRegistry ExtensionRegistryLite) in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch	From	To
Change Variable Type totalcount : long to totalCount : int in method public innerNext() : IterOutcome in class org.apache.drill.exec.physical.impl.xsort.ExternalSortBatch	From	To
Change Variable Type handle : FragmentHandle to targetCount : int in method protected handle(connection BitServerConnection, rpcType int, pBody ByteBuf, body ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.data.DataServer	From	To
Change Variable Type s : ResponseSender to s : AckSender in method public flushResponses(count int) : int in class org.apache.drill.exec.work.batch.ResponseSenderQueue	From	To
Extract Variable	2
Extract Variable svBuffer : DrillBuf in method public build(context FragmentContext, outputContainer VectorContainer) : void from class org.apache.drill.exec.physical.impl.sort.SortRecordBatchBuilder	From	To
Extract Variable destCount : int in method public BroadcastSenderRootExec(context FragmentContext, incoming RecordBatch, config BroadcastSender) from class org.apache.drill.exec.physical.impl.broadcastsender.BroadcastSenderRootExec	From	To
Extract Method	2
Extract Method private transfer(target Accountor, buf DrillBuf, size long, release boolean) : boolean extracted from public transferTo(target Accountor, buf DrillBuf, size long) : boolean in class org.apache.drill.exec.memory.Accountor	From	To
Extract Method public getEmptyLast(queryId QueryId, sendMajorFragmentId int, sendMinorFragmentId int, receiveMajorFragmentId int, receiveMinorFragmentIds int[]) : FragmentWritableBatch extracted from public getEmptyLast(queryId QueryId, sendMajorFragmentId int, sendMinorFragmentId int, receiveMajorFragmentId int, receiveMinorFragmentId int) : FragmentWritableBatch in class org.apache.drill.exec.record.FragmentWritableBatch	From	To
Rename Method	15
Rename Method public getHandleOrBuilder() : ExecProtos.FragmentHandleOrBuilder renamed to public getQueryIdOrBuilder() : UserBitShared.QueryIdOrBuilder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch	From	To
Rename Method public clearHandle() : Builder renamed to public clearQueryId() : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method public getHandleOrBuilder() : ExecProtos.FragmentHandleOrBuilder renamed to public getQueryIdOrBuilder() : UserBitShared.QueryIdOrBuilder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method public hasHandle() : boolean renamed to public hasQueryId() : boolean in class org.apache.drill.exec.proto.BitData.FragmentRecordBatchOrBuilder	From	To
Rename Method public getHandleOrBuilder() : ExecProtos.FragmentHandleOrBuilder renamed to public getQueryIdOrBuilder() : UserBitShared.QueryIdOrBuilder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatchOrBuilder	From	To
Rename Method public hasHandle() : boolean renamed to public hasQueryId() : boolean in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch	From	To
Rename Method public mergeHandle(value ExecProtos.FragmentHandle) : Builder renamed to public mergeQueryId(value UserBitShared.QueryId) : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method public getHandle() : ExecProtos.FragmentHandle renamed to public getQueryId() : UserBitShared.QueryId in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method public hasHandle() : boolean renamed to public hasQueryId() : boolean in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method public send(r Response) : void renamed to public sendOk() : void in class org.apache.drill.exec.work.batch.TestUnlimitedBatchBuffer.MyAckSender	From	To
Rename Method public setHandle(builderForValue ExecProtos.FragmentHandle.Builder) : Builder renamed to public setQueryId(builderForValue UserBitShared.QueryId.Builder) : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method private getHandleFieldBuilder() : SingleFieldBuilder<org.apache.drill.exec.proto.ExecProtos.FragmentHandle,org.apache.drill.exec.proto.ExecProtos.FragmentHandle.Builder,org.apache.drill.exec.proto.ExecProtos.FragmentHandleOrBuilder> renamed to private getQueryIdFieldBuilder() : SingleFieldBuilder<org.apache.drill.exec.proto.UserBitShared.QueryId,org.apache.drill.exec.proto.UserBitShared.QueryId.Builder,org.apache.drill.exec.proto.UserBitShared.QueryIdOrBuilder> in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method public getHandle() : ExecProtos.FragmentHandle renamed to public getQueryId() : UserBitShared.QueryId in class org.apache.drill.exec.proto.BitData.FragmentRecordBatchOrBuilder	From	To
Rename Method public getHandleBuilder() : ExecProtos.FragmentHandle.Builder renamed to public getQueryIdBuilder() : UserBitShared.QueryId.Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Method public setHandle(value ExecProtos.FragmentHandle) : Builder renamed to public setQueryId(value UserBitShared.QueryId) : Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Variable	2
Rename Variable handle : FragmentHandle to targetCount : int in method protected handle(connection BitServerConnection, rpcType int, pBody ByteBuf, body ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.data.DataServer	From	To
Rename Variable totalcount : long to totalCount : int in method public innerNext() : IterOutcome in class org.apache.drill.exec.physical.impl.xsort.ExternalSortBatch	From	To
Change Return Type	11
Change Return Type ExecProtos.FragmentHandleOrBuilder to UserBitShared.QueryIdOrBuilder in method public getQueryIdOrBuilder() : UserBitShared.QueryIdOrBuilder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Return Type ExecProtos.FragmentHandle to UserBitShared.QueryId in method public getQueryId() : UserBitShared.QueryId in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Return Type ExecProtos.FragmentHandle.Builder to UserBitShared.QueryId.Builder in method public getQueryIdBuilder() : UserBitShared.QueryId.Builder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Return Type ExecProtos.FragmentHandleOrBuilder to UserBitShared.QueryIdOrBuilder in method public getQueryIdOrBuilder() : UserBitShared.QueryIdOrBuilder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatchOrBuilder	From	To
Change Return Type ExecProtos.FragmentHandle to UserBitShared.QueryId in method public getQueryId() : UserBitShared.QueryId in class org.apache.drill.exec.proto.BitData.FragmentRecordBatchOrBuilder	From	To
Change Return Type boolean to void in method public add(rbd RecordBatchData) : void in class org.apache.drill.exec.physical.impl.sort.SortRecordBatchBuilder	From	To
Change Return Type void to boolean in method private outputToBatch(inIndex int) : boolean in class org.apache.drill.exec.physical.impl.aggregate.StreamingAggTemplate	From	To
Change Return Type ExecProtos.FragmentHandleOrBuilder to UserBitShared.QueryIdOrBuilder in method public getQueryIdOrBuilder() : UserBitShared.QueryIdOrBuilder in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch	From	To
Change Return Type SingleFieldBuilder<org.apache.drill.exec.proto.ExecProtos.FragmentHandle,org.apache.drill.exec.proto.ExecProtos.FragmentHandle.Builder,org.apache.drill.exec.proto.ExecProtos.FragmentHandleOrBuilder> to SingleFieldBuilder<org.apache.drill.exec.proto.UserBitShared.QueryId,org.apache.drill.exec.proto.UserBitShared.QueryId.Builder,org.apache.drill.exec.proto.UserBitShared.QueryIdOrBuilder> in method private getQueryIdFieldBuilder() : SingleFieldBuilder<org.apache.drill.exec.proto.UserBitShared.QueryId,org.apache.drill.exec.proto.UserBitShared.QueryId.Builder,org.apache.drill.exec.proto.UserBitShared.QueryIdOrBuilder> in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Return Type void to boolean in method private outputToBatchPrev(b1 InternalBatch, inIndex int, outIndex int) : boolean in class org.apache.drill.exec.physical.impl.aggregate.StreamingAggTemplate	From	To
Change Return Type ResponseSender to AckSender in method public getSender() : AckSender in class org.apache.drill.exec.record.RawFragmentBatch	From	To
Extract Superclass	1
Extract Superclass org.apache.drill.exec.rpc.data.AckSender from classes [org.apache.drill.exec.work.batch.TestUnlimitedBatchBuffer.MyAckSender]	From	To
Rename Attribute	4
Rename Attribute INSTANCE : RelOptRule to DIST_INSTANCE : RelOptRule in class org.apache.drill.exec.planner.physical.HashJoinPrule	From	To
Rename Attribute mySender : MySender to myAckSender : MyAckSender in class org.apache.drill.exec.work.batch.TestUnlimitedBatchBuffer	From	To
Rename Attribute handleBuilder_ : SingleFieldBuilder<org.apache.drill.exec.proto.ExecProtos.FragmentHandle,org.apache.drill.exec.proto.ExecProtos.FragmentHandle.Builder,org.apache.drill.exec.proto.ExecProtos.FragmentHandleOrBuilder> to queryIdBuilder_ : SingleFieldBuilder<org.apache.drill.exec.proto.UserBitShared.QueryId,org.apache.drill.exec.proto.UserBitShared.QueryId.Builder,org.apache.drill.exec.proto.UserBitShared.QueryIdOrBuilder> in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Rename Attribute handle_ : ExecProtos.FragmentHandle to queryId_ : UserBitShared.QueryId in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Attribute Type	6
Change Attribute Type q : Queue<ResponseSender> to q : Queue<AckSender> in class org.apache.drill.exec.work.batch.ResponseSenderQueue	From	To
Change Attribute Type sender : ResponseSender to sender : AckSender in class org.apache.drill.exec.record.RawFragmentBatch	From	To
Change Attribute Type handle_ : ExecProtos.FragmentHandle to queryId_ : UserBitShared.QueryId in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Attribute Type handleBuilder_ : SingleFieldBuilder<org.apache.drill.exec.proto.ExecProtos.FragmentHandle,org.apache.drill.exec.proto.ExecProtos.FragmentHandle.Builder,org.apache.drill.exec.proto.ExecProtos.FragmentHandleOrBuilder> to queryIdBuilder_ : SingleFieldBuilder<org.apache.drill.exec.proto.UserBitShared.QueryId,org.apache.drill.exec.proto.UserBitShared.QueryId.Builder,org.apache.drill.exec.proto.UserBitShared.QueryIdOrBuilder> in class org.apache.drill.exec.proto.BitData.FragmentRecordBatch.Builder	From	To
Change Attribute Type mySender : MySender to myAckSender : MyAckSender in class org.apache.drill.exec.work.batch.TestUnlimitedBatchBuffer	From	To
Change Attribute Type tunnels : Map<FragmentHandle,DataTunnel> to tunnels : Map<DrillbitEndpoint,DataTunnel> in class org.apache.drill.exec.ops.FragmentContext	From	To
Extract And Move Method	1
Extract And Move Method public isOutgoingBatchFull() : boolean extracted from public doJoin(status JoinStatus) : boolean in class org.apache.drill.exec.physical.impl.join.JoinTemplate & moved to class org.apache.drill.exec.physical.impl.join.JoinStatus	From	To
Rename Parameter	1
Rename Parameter remoteHandle : FragmentHandle to endpoint : DrillbitEndpoint in method public getDataTunnel(endpoint DrillbitEndpoint) : DataTunnel in class org.apache.drill.exec.ops.FragmentContext	From	To

9fd1430db69309c2e476007de851142f778ddb62

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: