a2190fa0f2376958930edfd90f253a8ef4b5a34a
Files Diff
- Added: 2
- Removed: 1
- Renamed: 0
- Modified: 15
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 3 | ||
Rename Method public getVectorWithOrdinal(name String) : VectorWithOrdinal renamed to public getChildVectorWithOrdinal(name String) : VectorWithOrdinal in class org.apache.drill.exec.vector.complex.RepeatedListVector | From | To | |
Rename Method public get(name String, clazz Class<T>) : T renamed to public getChild(name String, clazz Class<T>) : T in class org.apache.drill.exec.vector.complex.RepeatedListVector | From | To | |
Rename Method public abstract getVectorWithOrdinal(name String) : VectorWithOrdinal renamed to public getChildVectorWithOrdinal(name String) : VectorWithOrdinal in class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method | 13 | ||
Pull Up Method public getPrimitiveVectors() : List<ValueVector> from class org.apache.drill.exec.vector.complex.MapVector to public getPrimitiveVectors() : List<ValueVector> from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public getField() : MaterializedField from class org.apache.drill.exec.vector.complex.RepeatedMapVector to public getField() : MaterializedField from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public size() : int from class org.apache.drill.exec.vector.complex.MapVector to public size() : int from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public allocateNew() : void from class org.apache.drill.exec.vector.complex.MapVector to public allocateNew() : void from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public close() : void from class org.apache.drill.exec.vector.complex.MapVector to public close() : void from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public getField() : MaterializedField from class org.apache.drill.exec.vector.complex.RepeatedListVector to public getField() : MaterializedField from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public getField() : MaterializedField from class org.apache.drill.exec.vector.complex.MapVector to public getField() : MaterializedField from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public allocateNew() : void from class org.apache.drill.exec.vector.complex.RepeatedListVector to public allocateNew() : void from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public size() : int from class org.apache.drill.exec.vector.complex.RepeatedMapVector to public size() : int from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public allocateNew() : void from class org.apache.drill.exec.vector.complex.RepeatedMapVector to public allocateNew() : void from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public allocateNewSafe() : boolean from class org.apache.drill.exec.vector.complex.MapVector to public allocateNewSafe() : boolean from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public getBuffers(clear boolean) : DrillBuf[] from class org.apache.drill.exec.vector.complex.MapVector to public getBuffers(clear boolean) : DrillBuf[] from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Method public addOrGet(name String, type MajorType, clazz Class<T>) : T from class org.apache.drill.exec.vector.complex.MapVector to public addOrGet(name String, type MajorType, clazz Class<T>) : T from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Rename Variable | 4 | ||
Rename Variable e : Map.Entry<String,ValueVector> to field : MaterializedField in method public getObject(index int) : Object in class org.apache.drill.exec.vector.complex.RepeatedMapVector.RepeatedMapAccessor | From | To | |
Rename Variable v : ValueVector to newVector : ValueVector in method public MapSingleCopier(from RepeatedMapVector, to MapVector) in class org.apache.drill.exec.vector.complex.RepeatedMapVector.MapSingleCopier | From | To | |
Rename Variable k : String to fieldName : String in method public getObject(index int) : Object in class org.apache.drill.exec.vector.complex.RepeatedMapVector.RepeatedMapAccessor | From | To | |
Rename Variable e : Map.Entry<String,ValueVector> to child : String in method public MapSingleCopier(from RepeatedMapVector, to MapVector) in class org.apache.drill.exec.vector.complex.RepeatedMapVector.MapSingleCopier | From | To | |
Inline Method | 2 | ||
Inline Method public iterator() : Iterator<ValueVector> inlined to public fieldNameIterator() : Iterator<String> in class org.apache.drill.exec.vector.complex.RepeatedMapVector | From | To | |
Inline Method public iterator() : Iterator<ValueVector> inlined to public fieldNameIterator() : Iterator<String> in class org.apache.drill.exec.vector.complex.MapVector | From | To | |
Pull Up Attribute | 3 | ||
Pull Up Attribute private allocator : BufferAllocator from class org.apache.drill.exec.vector.complex.MapVector to protected allocator : BufferAllocator from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Attribute private field : MaterializedField from class org.apache.drill.exec.vector.complex.MapVector to private field : MaterializedField from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Pull Up Attribute private callBack : CallBack from class org.apache.drill.exec.vector.complex.MapVector to protected callBack : CallBack from class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Rename Class | 1 | ||
Rename Class org.apache.drill.exec.vector.complex.RepeatedMapVector.MapTransferPair renamed to org.apache.drill.exec.vector.complex.RepeatedMapVector.RepeatedMapTransferPair | From | To | |
Move Class | 1 | ||
Move Class org.apache.drill.exec.vector.complex.AbstractContainerVector.VectorWithOrdinal moved to org.apache.drill.exec.vector.complex.VectorWithOrdinal | From | To | |
Replace Variable With Attribute | 1 | ||
Replace Variable With Attribute v : ValueVector to offsets : UInt4Vector in method public close() : void in class org.apache.drill.exec.vector.complex.RepeatedMapVector | From | To | |
Change Variable Type | 3 | ||
Change Variable Type e : Map.Entry<String,ValueVector> to field : MaterializedField in method public getObject(index int) : Object in class org.apache.drill.exec.vector.complex.RepeatedMapVector.RepeatedMapAccessor | From | To | |
Change Variable Type e : Map.Entry<String,ValueVector> to child : String in method public MapSingleCopier(from RepeatedMapVector, to MapVector) in class org.apache.drill.exec.vector.complex.RepeatedMapVector.MapSingleCopier | From | To | |
Change Variable Type v : ValueVector to offsets : UInt4Vector in method public close() : void in class org.apache.drill.exec.vector.complex.RepeatedMapVector | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type ephPair : MapTransferPair to ephPair : RepeatedMapTransferPair in class org.apache.drill.exec.vector.complex.RepeatedMapVector | From | To | |
Extract And Move Method | 4 | ||
Extract And Move Method public getChild(name String) : ValueVector extracted from public reader(name String) : FieldReader in class org.apache.drill.exec.vector.complex.impl.RepeatedMapReaderImpl & moved to class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Extract And Move Method public iterator() : Iterator<ValueVector> extracted from public fieldNameIterator() : Iterator<String> in class org.apache.drill.exec.vector.complex.RepeatedMapVector & moved to class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Extract And Move Method public getChild(name String) : ValueVector extracted from public reader(name String) : FieldReader in class org.apache.drill.exec.vector.complex.impl.SingleMapReaderImpl & moved to class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To | |
Extract And Move Method public iterator() : Iterator<ValueVector> extracted from public fieldNameIterator() : Iterator<String> in class org.apache.drill.exec.vector.complex.MapVector & moved to class org.apache.drill.exec.vector.complex.AbstractContainerVector | From | To |