a4f62e9b5d0e69585b91042236c1ca68e1d628bc
Files Diff
- Added: 36
- Removed: 2
- Renamed: 0
- Modified: 25
Link to commit
Third party dependencies:
| Dependency Action | |
|---|---|
| Updated | |
| From org.apache.hbase:hbase-client 1.1.1-mapr-1602-m7-5.2.0 To 1.1.3 | |
| From com.mapr.hadoop:maprfs 5.2.1-mapr To 6.0.1-mapr | |
| From org.ojai:ojai 1.1 To 2.0.1-mapr-1804 | |
| From org.apache.hbase:hbase-client 1.1.3 To 1.1.1-mapr-1602-m7-5.2.0 | |
| From com.mapr.db:maprdb 5.2.1-mapr To 6.0.1-mapr | |
| From com.mapr.fs:mapr-hbase 5.2.1-mapr To 6.0.1-mapr |
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type writer : MapOrListWriterImpl to writer : MapOrListWriter in method protected writeBinary(writer MapOrListWriter, fieldName String, buf ByteBuffer) : void in class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter | From | To | |
| Change Parameter Type writer : MapOrListWriterImpl to writer : MapOrListWriter in method protected writeString(writer MapOrListWriter, fieldName String, value String) : void in class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter | From | To | |
| Change Parameter Type reader : DBDocumentReaderBase to reader : DocumentReader in method protected writeToListOrMap(writer MapOrListWriterImpl, reader DocumentReader) : void in class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter | From | To | |
| Change Parameter Type formatPluginConfig : MapRDBFormatPluginConfig to formatPlugin : MapRDBFormatPlugin in method protected MaprDBJsonRecordReader(subScanSpec MapRDBSubScanSpec, formatPlugin MapRDBFormatPlugin, projectedColumns List<SchemaPath>, context FragmentContext) in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Move Method | 8 | ||
| Move Method private dataReadError(t Throwable) : UserException from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to public dataReadError(logger Logger, t Throwable) : UserException from class org.apache.drill.exec.store.mapr.PluginErrorHandler | From | To | |
| Move Method private schemaChangeException(t Throwable, format String, args Object...) : SchemaChangeException from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to public schemaChangeException(logger Logger, t Throwable, format String, args Object...) : SchemaChangeException from class org.apache.drill.exec.store.mapr.PluginErrorHandler | From | To | |
| Move Method private writeBinary(writer MapOrListWriterImpl, fieldName String, buf ByteBuffer) : void from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to protected writeBinary(writer MapOrListWriter, fieldName String, buf ByteBuffer) : void from class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter | From | To | |
| Move Method private dataReadError(t Throwable, format String, args Object...) : UserException from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to public dataReadError(logger Logger, t Throwable, format String, args Object...) : UserException from class org.apache.drill.exec.store.mapr.PluginErrorHandler | From | To | |
| Move Method private writeToListOrMap(writer MapOrListWriterImpl, reader DBDocumentReaderBase) : void from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to protected writeToListOrMap(writer MapOrListWriterImpl, reader DocumentReader) : void from class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter | From | To | |
| Move Method private dataReadError(format String, args Object...) : UserException from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to public dataReadError(logger Logger, format String, args Object...) : UserException from class org.apache.drill.exec.store.mapr.PluginErrorHandler | From | To | |
| Move Method private writeString(writer MapOrListWriterImpl, fieldName String, value String) : void from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to protected writeString(writer MapOrListWriter, fieldName String, value String) : void from class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter | From | To | |
| Move Method private unsupportedError(format String, args Object...) : UserException from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to public unsupportedError(logger Logger, format String, args Object...) : UserException from class org.apache.drill.exec.store.mapr.PluginErrorHandler | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private MILLISECONDS_IN_A_DAY : long from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader to protected MILLISECONDS_IN_A_DAY : long from class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter | From | To | |
| Extract Class | 3 | ||
| Extract Class org.apache.drill.exec.store.mapr.db.json.AllTextValueWriter from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Extract Class org.apache.drill.exec.store.mapr.db.json.NumbersAsDoubleValueWriter from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Extract Class org.apache.drill.exec.store.mapr.db.json.OjaiValueWriter from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Extract Variable | 4 | ||
| Extract Variable pluginRegistry : StoragePluginRegistry in method public createPluginAndGetConf(ctx DrillbitContext) : Configuration from class com.mapr.drill.maprdb.tests.MaprDBTestsSuite | From | To | |
| Extract Variable fp : FieldPath in method protected transformColumns(columns Collection<SchemaPath>) : Collection<SchemaPath> from class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Extract Variable subScanSpec : MapRDBSubScanSpec in method public applyAssignments(incomingEndpoints List<DrillbitEndpoint>) : void from class org.apache.drill.exec.store.mapr.db.MapRDBGroupScan | From | To | |
| Extract Method | 1 | ||
| Extract Method public getGroupScan(userName String, selection FileSelection, columns List<SchemaPath>, indexDesc IndexDesc) : AbstractGroupScan extracted from public getGroupScan(userName String, selection FileSelection, columns List<SchemaPath>) : AbstractGroupScan in class org.apache.drill.exec.store.mapr.db.MapRDBFormatPlugin | From | To | |
| Inline Method | 2 | ||
| Inline Method public deleteJsonTables() : void inlined to public cleanupTests() : void in class com.mapr.drill.maprdb.tests.MaprDBTestsSuite | From | To | |
| Inline Method public createJsonTables() : void inlined to public setupTests() : void in class com.mapr.drill.maprdb.tests.MaprDBTestsSuite | From | To | |
| Rename Variable | 1 | ||
| Rename Variable e : DBException to ex : DBException in method public setup(context OperatorContext, output OutputMutator) : void in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Change Return Type | 3 | ||
| Change Return Type JsonTableGroupScan to GroupScan in method public clone(scanSpec JsonScanSpec) : GroupScan in class org.apache.drill.exec.store.mapr.db.json.JsonTableGroupScan | From | To | |
| Change Return Type JsonSubScanSpec to MapRDBSubScanSpec in method protected getSubScanSpec(tfi TabletFragmentInfo) : MapRDBSubScanSpec in class org.apache.drill.exec.store.mapr.db.json.JsonTableGroupScan | From | To | |
| Change Return Type Object to byte[] in method public getSerializedFilter() : byte[] in class org.apache.drill.exec.store.mapr.db.json.JsonScanSpec | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute tableName : String to subScanSpec : MapRDBSubScanSpec in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Rename Attribute table : Table to stats : MapRDBStatistics in class org.apache.drill.exec.store.mapr.db.json.JsonTableGroupScan | From | To | |
| Rename Attribute tabletInfos : TabletInfo[] to fullTableRowCount : double in class org.apache.drill.exec.store.mapr.db.json.JsonTableGroupScan | From | To | |
| Rename Attribute projectedFields : FieldPath[] to scannedFields : FieldPath[] in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Rename Attribute pluginCreated : boolean to pluginsUpdated : boolean in class com.mapr.drill.maprdb.tests.MaprDBTestsSuite | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type tabletInfos : TabletInfo[] to fullTableRowCount : double in class org.apache.drill.exec.store.mapr.db.json.JsonTableGroupScan | From | To | |
| Change Attribute Type table : Table to stats : MapRDBStatistics in class org.apache.drill.exec.store.mapr.db.json.JsonTableGroupScan | From | To | |
| Change Attribute Type tableName : String to subScanSpec : MapRDBSubScanSpec in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Change Attribute Type logger : org.slf4j.Logger to logger : Logger in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public setColumns(columns List<SchemaPath>) : void extracted from public MaprDBJsonRecordReader(subScanSpec MapRDBSubScanSpec, formatPluginConfig MapRDBFormatPluginConfig, projectedColumns List<SchemaPath>, context FragmentContext) in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader & moved to class org.apache.drill.exec.store.mapr.db.json.JsonTableGroupScan | From | To | |
| Extract And Move Method protected format(sql String) : String extracted from public testPushDownSubField8() : void in class com.mapr.drill.maprdb.tests.json.TestSimpleJson & moved to class com.mapr.drill.maprdb.tests.json.BaseJsonTest | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter formatPluginConfig : MapRDBFormatPluginConfig to formatPlugin : MapRDBFormatPlugin in method protected MaprDBJsonRecordReader(subScanSpec MapRDBSubScanSpec, formatPlugin MapRDBFormatPlugin, projectedColumns List<SchemaPath>, context FragmentContext) in class org.apache.drill.exec.store.mapr.db.json.MaprDBJsonRecordReader | From | To |