b55e2328d929df5d361c038f63fdeffadb0e544c
Files Diff
- Added: 27
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private setupAddWindowValue(cg ClassGenerator<WindowFramer>, functions Map<WindowFunction,TypedFieldId>) : void from class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch to package generateCode(cg ClassGenerator<WindowFramer>) : void from class org.apache.drill.exec.physical.impl.window.WindowFunction.Ranking | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type context : FragmentContext to oContext : OperatorContext in method public WindowDataBatch(batch VectorAccessible, oContext OperatorContext) in class org.apache.drill.exec.physical.impl.window.WindowDataBatch | From | To | |
| Change Parameter Type length : int to length : long in method public Partition(length long) in class org.apache.drill.exec.physical.impl.window.Partition | From | To | |
| Rename Variable | 2 | ||
| Rename Variable wf : WindowFunction to winfun : WindowFunction in method private createFramer(batch VectorAccessible) : WindowFramer in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Rename Variable aggExprs : List<LogicalExpression> to functions : List<WindowFunction> in method private createFramer(batch VectorAccessible) : WindowFramer in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Change Return Type | 3 | ||
| Change Return Type int to long in method public getRemaining() : long in class org.apache.drill.exec.physical.impl.window.Partition | From | To | |
| Change Return Type int to long in method private computePartitionSize(start int) : long in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Return Type FragmentContext to OperatorContext in method public getContext() : OperatorContext in class org.apache.drill.exec.physical.impl.window.WindowDataBatch | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute context : FragmentContext to oContext : OperatorContext in class org.apache.drill.exec.physical.impl.window.WindowDataBatch | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type remaining : int to remaining : long in method private countPeers(start int) : int in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Variable Type length : int to length : long in method private newPartition(current WindowDataBatch, currentRow int) : void in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Variable Type length : int to length : long in method private computePartitionSize(start int) : long in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Change Variable Type aggExprs : List<LogicalExpression> to functions : List<WindowFunction> in method private createFramer(batch VectorAccessible) : WindowFramer in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type length : int to length : long in class org.apache.drill.exec.physical.impl.window.Partition | From | To | |
| Change Attribute Type remaining : int to remaining : long in class org.apache.drill.exec.physical.impl.window.Partition | From | To | |
| Change Attribute Type context : FragmentContext to oContext : OperatorContext in class org.apache.drill.exec.physical.impl.window.WindowDataBatch | From | To | |
| Extract Method | 4 | ||
| Extract Method private cleanPartition() : void extracted from public doWork() : void in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Extract Method private newPartition(current WindowDataBatch, currentRow int) : void extracted from public doWork() : void in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Extract Method private processRow(row int) : void extracted from private processPartition(currentRow int) : int in class org.apache.drill.exec.physical.impl.window.DefaultFrameTemplate | From | To | |
| Extract Method private generateFramer(keyExprs List<LogicalExpression>, orderExprs List<LogicalExpression>, functions List<WindowFunction>) : WindowFramer extracted from private createFramer(batch VectorAccessible) : WindowFramer in class org.apache.drill.exec.physical.impl.window.WindowFrameRecordBatch | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter context : FragmentContext to oContext : OperatorContext in method public WindowDataBatch(batch VectorAccessible, oContext OperatorContext) in class org.apache.drill.exec.physical.impl.window.WindowDataBatch | From | To |