b6e59ec350c7cc7f467896abba4476cfcfc9077e
Files Diff
- Added: 8
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method protected handleReponse(throttle ConnectionThrottle, rpcType int, pBody ByteBuf, dBody ByteBuf) : Response renamed to protected handle(connection UserToBitConnection, rpcType int, pBody ByteBuf, dBody ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.user.UserClient | From | To | |
| Rename Method public closeSession() : void renamed to private cleanup() : void in class org.apache.drill.exec.rpc.user.UserServer.BitToUserConnection | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public getAllocator() : BufferAllocator from class org.apache.drill.exec.rpc.user.UserServer.UserClientConnectionImpl to public getAllocator() : BufferAllocator from class org.apache.drill.exec.rpc.AbstractServerConnection | From | To | |
| Change Parameter Type | 6 | ||
| Change Parameter Type handler : RpcConnectionHandler<ServerConnection> to handler : RpcConnectionHandler<UserToBitConnection> in method public getWrappedConnectionHandler(handler RpcConnectionHandler<UserToBitConnection>) : RpcConnectionHandler<UserToBitConnection> in class org.apache.drill.exec.rpc.user.QueryResultHandler | From | To | |
| Change Parameter Type connection : ServerConnection to connection : UserToBitConnection in method public connectionSucceeded(connection UserToBitConnection) : void in class org.apache.drill.exec.rpc.user.QueryResultHandler.ChannelClosedHandler | From | To | |
| Change Parameter Type throttle : ConnectionThrottle to connection : UserToBitConnection in method protected handle(connection UserToBitConnection, rpcType int, pBody ByteBuf, dBody ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.user.UserClient | From | To | |
| Change Parameter Type connection : UserClientConnectionImpl to connection : BitToUserConnection in method public handle(connection BitToUserConnection, rpcType int, pBody ByteBuf, dBody ByteBuf, responseSender ResponseSender) : void in class org.apache.drill.exec.rpc.user.UserServerRequestHandler | From | To | |
| Change Parameter Type connection : UserClientConnectionImpl to connection : BitToUserConnection in method protected getHandshakeHandler(connection BitToUserConnection) : ServerHandshakeHandler<UserToBitHandshake> in class org.apache.drill.exec.rpc.user.UserServer | From | To | |
| Change Parameter Type parentHandler : RpcConnectionHandler<ServerConnection> to parentHandler : RpcConnectionHandler<UserToBitConnection> in method public ChannelClosedHandler(parentHandler RpcConnectionHandler<UserToBitConnection>) in class org.apache.drill.exec.rpc.user.QueryResultHandler.ChannelClosedHandler | From | To | |
| Move Method | 1 | ||
| Move Method protected handle(connection UserClientConnectionImpl, rpcType int, pBody ByteBuf, dBody ByteBuf, responseSender ResponseSender) : void from class org.apache.drill.exec.rpc.user.UserServer to public handle(connection BitToUserConnection, rpcType int, pBody ByteBuf, dBody ByteBuf, responseSender ResponseSender) : void from class org.apache.drill.exec.rpc.user.UserServerRequestHandler | From | To | |
| Change Return Type | 3 | ||
| Change Return Type UserClientConnectionImpl to BitToUserConnection in method protected initRemoteConnection(channel SocketChannel) : BitToUserConnection in class org.apache.drill.exec.rpc.user.UserServer | From | To | |
| Change Return Type RpcConnectionHandler<ServerConnection> to RpcConnectionHandler<UserToBitConnection> in method public getWrappedConnectionHandler(handler RpcConnectionHandler<UserToBitConnection>) : RpcConnectionHandler<UserToBitConnection> in class org.apache.drill.exec.rpc.user.QueryResultHandler | From | To | |
| Change Return Type Response to void in method protected handle(connection UserToBitConnection, rpcType int, pBody ByteBuf, dBody ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.user.UserClient | From | To | |
| Move Attribute | 2 | ||
| Move Attribute package worker : UserWorker from class org.apache.drill.exec.rpc.user.UserServer to private worker : UserWorker from class org.apache.drill.exec.rpc.user.UserServerRequestHandler | From | To | |
| Move Attribute package impersonationManager : InboundImpersonationManager from class org.apache.drill.exec.rpc.user.UserServer to private impersonationManager : InboundImpersonationManager from class org.apache.drill.exec.rpc.user.UserConnectionConfig | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.drill.common.config.DrillProperties from class org.apache.drill.exec.rpc.user.UserSession | From | To | |
| Extract Class org.apache.drill.exec.rpc.user.UserConnectionConfig from class org.apache.drill.exec.rpc.user.UserServer | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.drill.exec.rpc.user.UserServer.UserClientConnectionImpl renamed to org.apache.drill.exec.rpc.user.UserServer.BitToUserConnection | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.drill.exec.rpc.AbstractServerConnection from classes [org.apache.drill.exec.rpc.user.UserServer.BitToUserConnection] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute props : UserProperties to properties : DrillProperties in class org.apache.drill.exec.client.DrillClient | From | To | |
| Extract Variable | 1 | ||
| Extract Variable userName : String in method public getHandshakeResponse(inbound UserToBitHandshake) : BitToUserHandshake from class org.apache.drill.exec.rpc.user.UserServer.getHandshakeHandler | From | To | |
| Change Attribute Type | 4 | ||
| Change Attribute Type props : UserProperties to properties : DrillProperties in class org.apache.drill.exec.client.DrillClient | From | To | |
| Change Attribute Type properties : Map<String,String> to properties : DrillProperties in class org.apache.drill.exec.rpc.user.UserSession | From | To | |
| Change Attribute Type parentHandler : RpcConnectionHandler<ServerConnection> to parentHandler : RpcConnectionHandler<UserToBitConnection> in class org.apache.drill.exec.rpc.user.QueryResultHandler.ChannelClosedHandler | From | To | |
| Change Attribute Type logger : org.slf4j.Logger to logger : Logger in class org.apache.drill.exec.rpc.user.UserClient | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter alloc : BufferAllocator to allocator : BufferAllocator in method public UserClient(clientName String, config DrillConfig, supportComplexTypes boolean, allocator BufferAllocator, eventLoopGroup EventLoopGroup, eventExecutor Executor) in class org.apache.drill.exec.rpc.user.UserClient | From | To | |
| Rename Parameter throttle : ConnectionThrottle to connection : UserToBitConnection in method protected handle(connection UserToBitConnection, rpcType int, pBody ByteBuf, dBody ByteBuf, sender ResponseSender) : void in class org.apache.drill.exec.rpc.user.UserClient | From | To |