bb29f19ff8807fd07cdaa9e7110c1a003b3da15b
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 38
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type catalog : CalciteCatalogReader to catalog : DrillCalciteCatalogReader in method private SqlConverter(parent SqlConverter, defaultSchema SchemaPlus, rootSchema SchemaPlus, catalog DrillCalciteCatalogReader) in class org.apache.drill.exec.planner.sql.SqlConverter | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [settings : PlannerSettings, functions : FunctionImplementationRegistry, defaultSchema : SchemaPlus, operatorTable : SqlOperatorTable] to context : QueryContext in method public SqlConverter(context QueryContext) in class org.apache.drill.exec.planner.sql.SqlConverter | From | To | |
| Extract Variable | 1 | ||
| Extract Variable tableSchema : List<String> in method public getPlan(sqlNode SqlNode) : PhysicalPlan from class org.apache.drill.exec.planner.sql.handlers.DropTableHandler | From | To | |
| Inline Variable | 1 | ||
| Inline Variable schemaPath : String in method public getPlan(sqlNode SqlNode) : PhysicalPlan from class org.apache.drill.exec.planner.sql.handlers.ViewHandler.CreateView | From | To | |
| Extract Method | 3 | ||
| Extract Method public createNewTable(tableName String, partitionColumns List<String>, storageStrategy StorageStrategy) : CreateTableEntry extracted from public createNewTable(tableName String, partitionColumns List<String>) : CreateTableEntry in class org.apache.drill.exec.store.AbstractSchema | From | To | |
| Extract Method private checkDuplicatedObjectExistence(drillSchema AbstractSchema, tableName String, config DrillConfig, userSession UserSession) : void extracted from public getPlan(sqlNode SqlNode) : PhysicalPlan in class org.apache.drill.exec.planner.sql.handlers.CreateTableHandler | From | To | |
| Extract Method private validateViewCreationPossibility(drillSchema AbstractSchema, view SqlCreateView, context QueryContext) : void extracted from public getPlan(sqlNode SqlNode) : PhysicalPlan in class org.apache.drill.exec.planner.sql.handlers.ViewHandler.CreateView | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type catalog : CalciteCatalogReader to catalog : DrillCalciteCatalogReader in class org.apache.drill.exec.planner.sql.SqlConverter | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public dropViewFromSchema(drillSchema AbstractSchema, viewName String) : void extracted from public getPlan(sqlNode SqlNode) : PhysicalPlan in class org.apache.drill.exec.planner.sql.handlers.ViewHandler.DropView & moved to class org.apache.drill.exec.planner.sql.handlers.SqlHandlerUtil | From | To | |
| Extract And Move Method public dropTableFromSchema(drillSchema AbstractSchema, tableName String) : void extracted from public getPlan(sqlNode SqlNode) : PhysicalPlan in class org.apache.drill.exec.planner.sql.handlers.DropTableHandler & moved to class org.apache.drill.exec.planner.sql.handlers.SqlHandlerUtil | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter partitonColumns : List<String> to partitionColumns : List<String> in method public createNewTable(tableName String, partitionColumns List<String>, storageStrategy StorageStrategy) : CreateTableEntry in class org.apache.drill.exec.store.dfs.WorkspaceSchemaFactory.WorkspaceSchema | From | To |